[Bug 16001] New: Use standard message dialog when there are no cities to list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Bug ID: 16001 Summary: Use standard message dialog when there are no cities to list Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/cities.pl OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In Administration -> Cities and towns, if there are no cities defined that information should be shown in the standard <div class="dialog message"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48760&action=edit Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- This might be user error, but I applied the patch and see no difference. Nicole -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48760|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51584&action=edit Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51584|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51623&action=edit [SIGNED-OFF] Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Better view, no errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51623|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51667&action=edit Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Better view, no errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14888 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 [Bug 14888] Move the cities related code to Koha::Cities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org