[Bug 6634] New: manager_id not populated when paying fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Bug #: 6634 Summary: manager_id not populated when paying fines Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Patrons AssignedTo: ian.walls@bywatersolutions.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Created attachment 4743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4743 sample accountlines data The accountlines table has a manager_id field but this field is not populated when you pay fines (or in some other instances). This field should be populated with the person who is logged in at the time the fine is paid or at the time any change is made to the account so you can track who's doing what with money in your library. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-07-27 01:13:18 UTC --- Created attachment 4745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4745 another sample with account type -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2696 Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-07-27 11:50:09 UTC --- Created attachment 4754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4754 patch This patch actually helps bug 2696 along a bit by putting the item number back in the database when a payment is made - making it possible to print that was paid for on the account page. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-12 16:54:29 UTC --- This patch touches two C4 modules; could I get a second signoff? I'm not comfortable marking this as "passed QA" when only me and one of my fellow ByWaterians have checked it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-14 12:37:06 UTC --- I did some additional testing on the bug and it seems there is still no manager_id saved in accountlines when you do a 'writeoff'. To reproduce: - create manual invoice. Example. Sundry, 0.25 - writeoff fine from pay fines page Paying fines the way described on the bugs was working perfectly. I am signing off on this as the bug only mentions paying fines and I see no problems there. The writeoff problem can is a separate bug and can be fixed in a follow up. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4754|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-14 12:37:45 UTC --- Created attachment 4991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4991 [SIGNED-OFF] Bugs 6634: manager_id not recorded for payments and rental charges Manager_id, the borrowernumber of the staff person doing the action, was not recorded for payments, rental charges, or rental charges on renewals. This patch implements that. This patch also adds the recording of itemnumber in a payment, by taking the itemnumber of the account that it's paying off. This addresses bug 2696, though it does not make any change to the display logic of the Payments line in the staff client. To test: 1. Check out an item with an issuing charge 2. Renew the item 3. Pay one of the rental charges on the item 4. Verify in koha.accountlines that each of the three above operations recorded your borrowernumber in accountlines.manager_id Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6718 Patch Status|Needs Signoff |Signed Off --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-14 13:10:16 UTC --- Files separate bug 6718 for writeoff problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-14 13:20:32 UTC --- Thank you, Katrin, for your thorough testing. The writeoff issue can be covered with a separate bug report. Marking this one as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-15 03:32:47 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 16:38:48 UTC --- I just tested and the manager_id is NULL (i've checked, the code is here). I added a manual debt => manager_id=1, it's OK I added a payement through "pay fine" > tested both pay amount and "pay" on the left of the debt line in both cases, I got manager_ID=NULL -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Patch Pushed |--- --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 16:39:19 UTC --- a patch has been pushed, but it fixes only a part of the problem -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P1 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-02 20:28:00 UTC --- I am removing the patch sent status as more work is needed on this bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pelletiermaxime@gmail.com --- Comment #12 from Maxime Pelletier <pelletiermaxime@gmail.com> 2012-02-03 21:30:16 UTC --- This was broken again with the patch for bug 5713 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4991|0 |1 is obsolete| | --- Comment #13 from Maxime Pelletier <pelletiermaxime@gmail.com> 2012-02-07 15:42:46 UTC --- Created attachment 7478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7478 patch to populate manager_id and itemnumber when paying fines New patch to populate manager_id and itemnumber when paying a fine and also added the same for partial fines. Based on 3.6.0, so let me know if it doesn't apply on 3.6.x. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Fred P <fred.pierre@smfpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fred.pierre@smfpl.org --- Comment #14 from Fred P <fred.pierre@smfpl.org> 2012-02-08 16:05:26 UTC --- Does anyone else get the behavior that if you create three manual invoices and pay one, that the other two have their outstanding balance zeroed out? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 --- Comment #15 from Fred P <fred.pierre@smfpl.org> 2012-02-08 17:37:51 UTC --- Turns out that a writeoff uses a smallint value for the account no, the account no is used to clear the amountoustanding. The account no is supposed to increment, but writeoff assigns the maximum value to the smallint, it fails to increment, and the next accountline is assigned the same (maximum) value for account no. The next time you apply a payment, all of the accountlines with that account no receive the same processing. It's only a writeoff that affects this, and I am using 3.5, not sure if this manifests in 3.6. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 --- Comment #16 from Fred P <fred.pierre@smfpl.org> 2012-02-08 18:39:24 UTC --- Sorry to jump in on your bug, I am going to write the "Writeoff" issue up as a separate bug. Thatcher suggested it was similar to bug#3498, but I think it is different enough that it needs separate documentation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7478|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> 2012-02-09 14:53:12 UTC --- Created attachment 7527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7527 [SIGNED-OFF] Bug 6634 manager_id and itemnumber not populated when paying fines Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Owen Leonard <oleonard@myacpl.org> 2012-02-09 14:54:45 UTC --- Tested successfully in master following this procedure (Comment 5): 1. Check out an item with an issuing charge 2. Renew the item 3. Pay one of the rental charges on the item 4. Verify in koha.accountlines that each of the three above operations recorded your borrowernumber in accountlines.manager_id manager_id was correctly populated for all transactions. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 14:38:33 UTC --- QA comment small patch, code is OK. Will push it, but my tests shows that there is one case that is still not covered: when paying fines with the button "Pay Selected" or "Pay Amount", the columns are still NULL (manager_id and itemnumber) When paying from "Pay" or "Pay Amount", it's OK though I see in the sub recordpayement that the same kind of fix should be made: my $usth = $dbh->prepare( "INSERT INTO accountlines (borrowernumber, accountno,date,amount,description,accounttype,amountoutstanding) VALUES (?,?,now(),?,'Payment,thanks','Pay',?)" The sub chargelostitem has also the same problem: my $sth2=$dbh->prepare("INSERT INTO accountlines (borrowernumber,accountno,date,amount,description,accounttype,amountoutstanding,itemnumber) VALUES (?,?,now(),?,?,'L',?,?)"); (itemnumber is OK, but manager_id is not) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 14:39:14 UTC --- The 1st patch has been pushed, status resetted to "assigned" to address the 2 other cases identified -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7527|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6718 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 --- Comment #21 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 8676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8676&action=edit Fix 3 other cases of manager_id not populated Sorry for missing them at first and taking this long to send a new patch! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P3 Status|ASSIGNED |Needs Signoff Severity|critical |enhancement -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- If there were still instances where this was broken I must not have tested all the possible cases. Can you describe what other operations need testing? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #22)
If there were still instances where this was broken I must not have tested all the possible cases. Can you describe what other operations need testing?
(not sure you were answering my QA comment, but thinking so) I haven't tested, it's just that i've checked the code, and some "INSERT" clauses where lacking the manager_id & itemnumber parameters. Maybe that's some dead/unreachable code, but that's a code we have in recordpayement and chargelostitem subs -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Irma Birchall <irma@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |irma@calyx.net.au --- Comment #24 from Irma Birchall <irma@calyx.net.au> --- I have tested the payment of fines and Paul has verified in koha.accountlines.manager_id that each of the operations recorded the borrowernumber and the manager_id details. This patch can be signed off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Ian Walls <koha.sekjal@gmail.com> --- Adds managerid recording to recordpayment(), chargelostitem(), and recordpayment_selectaccts() subroutines. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Severity|enhancement |normal --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> --- New follow-up pushed (it's not an ENH, chris_c, I think those patches should to ported to 3.8) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version|rel_3_6 |rel_3_8 --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org