[Bug 28236] New: Selecting database columns for system preferences in standard and dev installs is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Bug ID: 28236 Summary: Selecting database columns for system preferences in standard and dev installs is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 22844, 9812 With bug 22844 we introduced a pick list of database columns for system preferences where such a list was required. However, the list is in a plain json file under the templates directory. This works fine for packages, but because of bug 9812 those directories are not accessible to the outside world for both standard and dev type installs using the make process. We need to resolve this somehow.. and it raises the question as to whether templates should be available to view on packages at all? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 [Bug 9812] Several files shouldn't be exposed or browseable through a URL https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jon.turner@ptfs-europe.com, | |jonathan.druart+koha@gmail. | |com, magnus@libriotech.no, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Should we just produce an API route for that... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Or use the API specs that are already available perhaps? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi --- Comment #3 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- We have finally started our upgrading process to the newest Koha release and this problem came out when our superlibrarian was trying to set again systempreferences. This is a kind of show stopper. Maybe we could open those json-files from Apache? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | Status|NEW |Needs Signoff --- Comment #4 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 124424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124424&action=edit Bug 28236: Selecting database columns for system preferences in standard and dev installs is broken This patch grants json files from koha-tmpl. Otherwise systempreferences won't be able to fetch them. TEST PLAN: 1) Try to set systempreference BorrowerUnwantedField. 2) The modal is empty. 3) Modify Apache configurations like in this patch. 4) Try again set the systempreference. 5) The modal should show list of parameters. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oops, I totally missed that you had added a patch here... looks good, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126645&action=edit Bug 28236: Selecting database columns for system preferences in standard and dev installs is broken This patch grants json files from koha-tmpl. Otherwise systempreferences won't be able to fetch them. TEST PLAN: 1) Try to set systempreference BorrowerUnwantedField. 2) The modal is empty. 3) Modify Apache configurations like in this patch. 4) Try again set the systempreference. 5) The modal should show list of parameters. Sponsored-by: Koha-Suomi Oy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> ---
From Martin request, I test this since we use dev install in production servers. We usually use Nginx but we have some Apache installs (because of Sibboleth).
Works fine, I reproduce the HTTP 403 without this patch. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126645|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127248&action=edit Bug 28236: Allow access to json files from apache config This patch grants json files from koha-tmpl. Otherwise systempreferences won't be able to fetch them. TEST PLAN: 1) Try to set systempreference BorrowerUnwantedField. 2) The modal is empty. 3) Modify Apache configurations like in this patch. 4) Try again set the systempreference. 5) The modal should show list of parameters. Sponsored-by: Koha-Suomi Oy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> JD Amended patch: replace tab characters and reword commit title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Congratulations for your first patch pushed, Johanna! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 --- Comment #11 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Jonathan Druart from comment #10)
Congratulations for your first patch pushed, Johanna!
Nice, thank you very much. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes Apache access to release notes| |json files in koha-tmpl for | |non-package installs. This | |causes issues for system | |preferences where there is | |a pick list for database | |columns. | | | |Bug 22844 | |introduced a pick list of | |database columns for system | |preferences where such a | |list was required. This | |list is in a plain json | |file under the templates | |directory. This works fine | |for packages, but because | |of bug 9812 (which limited | |browser access to selected | |files) those directories | |are not accessible to the | |outside world for both | |standard and dev type | |installs using the make | |process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28236 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org