[Bug 43314] New: Add cron reminder to AnonymizeLastBorrower/AnonymizeLastBorrowerDays description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Bug ID: 43314 Summary: Add cron reminder to AnonymizeLastBorrower/AnonymizeLastBorrowerDays description Initiative type: --- Sponsorship --- status: Product: Koha Version: 26.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 23260 Target Milestone: --- The new AnonymizeLastBorrower/AnonymizeLastBorrowerDays system preference set should have a note that the anonymize_last_borrowers.pl and batch_anonymize.pl crons are required for them to function properly, similar to the notes for MembershipExpiryDaysNotice ("NOTE: This system preference requires the misc/cronjobs/membership_expiry.pl cronjob. Ask your system administrator to schedule it.") and the multiple DefaultLongOverdue preferences ("NOTE: This system preference requires the misc/cronjobs/longoverdue.pl cronjob. Ask your system administrator to schedule it."). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 [Bug 23260] Anonymize (remove) patron data from items_last_borrower -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 --- Comment #1 from Sara Brown <sbrown@bywatersolutions.com> --- Correction: the note should only include that anonymize_last_borrowers.pl is required (I misunderstood when thinking that batch_anonymize.pl was also necessary). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 205390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205390&action=edit Bug 43314: Add hint about cronjob to the syspref To test: 1. APPLY PATCH and restart_all 2. Look at the AnonymizeLastBorrower system pref. 3. The hint should read: NOTE: This system preference requires the misc/cronjobs/anonymize_last_borrowers.pl cronjob. Ask your system administrator to schedule it. 4. Confirm that makes sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|26.05 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 205663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205663&action=edit Bug 43314: Add hint about cronjob to the AnonymizeLastBorrower system preference To test: 1. APPLY PATCH and restart_all 2. Look at the AnonymizeLastBorrower system pref. 3. The hint should read: NOTE: This system preference requires the misc/cronjobs/anonymize_last_borrowers.pl cronjob. Ask your system administrator to schedule it. 4. Confirm that makes sense. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #205390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a note to the release notes| |AnonymizeLastBorrower | |system preference with a | |hint about needing to run | |the cron job. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|martin.renvoize@openfifth.c |andrew@bywatersolutions.com |o.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205663|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 207791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207791&action=edit Bug 43314: Add hint about cronjob to the AnonymizeLastBorrower system preference To test: 1. APPLY PATCH and restart_all 2. Look at the AnonymizeLastBorrower system pref. 3. The hint should read: NOTE: This system preference requires the misc/cronjobs/anonymize_last_borrowers.pl cronjob. Ask your system administrator to schedule it. 4. Confirm that makes sense. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.06 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Does this note make sense when this script is already enabled in cron.daily? Note that if you dont use this pref, it creates an ugly "run-parts: /etc/cron.daily/koha-common exited with return code 1" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #7)
Does this note make sense when this script is already enabled in cron.daily?
We use the same message on 18 other sysprefs already, but we could consider alternatives if you have suggestions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43314 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew Fuerste-Henry from comment #8)
(In reply to Marcel de Rooy from comment #7)
Does this note make sense when this script is already enabled in cron.daily?
We use the same message on 18 other sysprefs already, but we could consider alternatives if you have suggestions.
My main suggestion would be to remove the confusing run-parts warn (which reads as an error and will certainly confuse people). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org