[Bug 38474] New: t/db_dependent/Letters.t can fail randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 Bug ID: 38474 Summary: t/db_dependent/Letters.t can fail randomly Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com 17:00:43 koha_1 | # Failed test 'Time status changed equals time queued when created in message_queue table' 17:00:43 koha_1 | # at t/db_dependent/Letters.t line 156. 17:00:43 koha_1 | # got: '2024-11-15 16:00:00' 17:00:43 koha_1 | # expected: '2024-11-15 15:59:59' 17:00:43 koha_1 | # Looks like you failed 1 test of 103. 17:00:43 koha_1 | [16:00:09] t/db_dependent/Letters.t .................................................... It looks like it took a little longer than expected maybe and the test fails because of it. If this is the issue, we could make it a little more robust. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- It should use t::lib::Dates::compare -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Again Koha_Main_U24/214 18:30:25 koha_1 | # Failed test 'Time status changed equals time queued when created in message_queue table' 18:30:25 koha_1 | # at t/db_dependent/Letters.t line 156. 18:30:25 koha_1 | # got: '2025-02-05 17:27:07' 18:30:25 koha_1 | # expected: '2025-02-05 17:27:06' 18:30:25 koha_1 | # Looks like you failed 1 test of 104. 18:30:25 koha_1 | [17:27:13] t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177676&action=edit Bug 38474: Prevent Letters.t to fail on slow server We must always use t::lib::Dates::compare when we compare dates in tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com Severity|minor |normal Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Skip for 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38474 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Test suite, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org