http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 10879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10879&action=edit Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen This patch changes the div classes, so that the prompts for action stand out and actually grab the attention of the user. It also adds more precise, descriptive language for the prompt messages and fixes the grammar (e.g. comma splices). The most important part being the second instruction where staff are prompted to check-in the item to continue processing the hold for the next patron in the holds queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10879|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11794&action=edit Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen This patch re-implements and adapts the changes dcook@prosentient.com.au submitted in a patch which no longer applies. I have changed the "alert" style messages to "message" style to match the style which is applied to "hold found" messages elsewhere. I have also revised the language in a way that I think is more clear and accurate. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11794|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 11795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11795&action=edit [SIGNED-OFF] Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen This patch re-implements and adapts the changes dcook@prosentient.com.au submitted in a patch which no longer applies. I have changed the "alert" style messages to "message" style to match the style which is applied to "hold found" messages elsewhere. I have also revised the language in a way that I think is more clear and accurate. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- String changes only. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #6)

Question:

Owen, you replace: - <p>This hold placed <snip> at the library : <b> [% branchname %] </b>, Please transfer this hold.

by + Please retain this item and check it in to process the hold.

IE: you loose the information of the branch you must transfer it to. Was it intended ?

Woudln't it be better to have + <h2>This item is on hold for pick-up at another library ([% branchname %])</h2>

or something like that?

I don't mean to speak for Owen, but the branchname information isn't particularly useful or relevant at this stage. Really, the staff member just needs to know that the item needs to be transferred (rather than shelved at their location), and that they process the transfer by checking in the item. Once they check it in, they'll see the branch to transfer it to and have the option of printing a slip, I believe. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12637|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master (would it be considered by chris_c as a bugfix I would not object) -- You are receiving this mail because: You are watching all bug changes.