https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 François Pichenot <fpichenot@ville-roubaix.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132842|0 |1 is obsolete| | --- Comment #2 from François Pichenot <fpichenot@ville-roubaix.fr> --- Created attachment 132864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132864&action=edit Bug 30430: UNIMARC XSLT add field B214 display test plan : - Apply patch - Find a record with a B214 - Check on both Opac-Details and Opac-Result that the field is displayed. - Do the same checks on catalogue/search results and catalogue/details in Staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 François Pichenot <fpichenot@ville-roubaix.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132872|0 |1 is obsolete| | --- Comment #4 from François Pichenot <fpichenot@ville-roubaix.fr> --- Created attachment 133235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133235&action=edit Bug 30430: UNIMARC XSLT add field B214 display test plan : - Apply patch - Find a record with a B214 - Check on both Opac-Details and Opac-Result that the field is displayed. - Do the same checks on catalogue/search results and catalogue/details in Staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133235|0 |1 is obsolete| | --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 134560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134560&action=edit Bug 30430: UNIMARC XSLT add field B214 display test plan : - Apply patch - Find a record with a B214 - Check on both Opac-Details and Opac-Result that the field is displayed. - Do the same checks on catalogue/search results and catalogue/details in Staff interface. - Add a 210 field to the record (legacy) - It should be displayed as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 134652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134652&action=edit Bug 30430 : (QA follow-up) fix display of 210 only if no 214 + added 214r/s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134652|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 134668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134668&action=edit Bug 30430 : (QA follow-up) fix display of 210 only if no 214 + added 214r/s Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fpichenot@ville-roubaix.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #14 from Séverine Queune <severine.queune@bulac.fr> --- Ha (In reply to Katrin Fischer from comment #12)

Can you explain how to catalog a B214? (Why the B and not just 214?)

Hi Katrin ! 'B_xxx' is means 'bibliographic'. It's quite an automatism that we have to precede the name of the field in order not to confuse it with the same number field of the authorities which would be 'A_xxx'. So in that case, saying 'field 214' works fine too :)

...

Thanks Arthur for providing a sample record - that made it much easier to test! (In reply to Arthur Suzuki from comment #13) Hi david,

(In reply to David Nind from comment #11) thx for the signoff, actually, the mrc file has been provided by Severine Queune, I've just uploaded it to bugzilla.

Thank you for testing David ! I didn't because the code partially comes the BULAC stylesheet, I don't think it would be fair signing it :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134667|0 |1 is obsolete| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136758&action=edit Bug 30430: UNIMARC XSLT add field B214 display test plan : - Apply patch - Find a record with a B214 - Check on both Opac-Details and Opac-Result that the field is displayed. - Do the same checks on catalogue/search results and catalogue/details in Staff interface. - Add a 210 field to the record (legacy) - It should be displayed as well Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136760&action=edit Bug 30430: (QA follow-up) Several fixes Several fixes : - Replace tab with spaces tag_210 : - Class 'value' and not 'valeur' - Loop on subfields must restrict to abcdg otherwise last() may not be correct (ie 214r and 214s) tag_214 : - Condition for coma after b should be same as after a : "position() != last()" tag_210 and tag_214 : - Space before ':' like in other fields - ':' before c or g does not exist in opac, removed from intranet file - Search links in intranet fixed (where composed with opac-search ^^) - Search links using 'str:encode-uri' like other places - Simplify title attribute with only 'Search for publisher' => Bad idea to use double quotes in a text tag_214_s and tag_214_r : - Loop on field+subfield otherwise last() may not be correct I've fixed intranet and copied to OPAC (only adapted search links) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136758|0 |1 is obsolete| | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136761&action=edit Bug 30430: UNIMARC XSLT add field B214 display test plan : - Apply patch - Find a record with a B214 - Check on both Opac-Details and Opac-Result that the field is displayed. - Do the same checks on catalogue/search results and catalogue/details in Staff interface. - Add a 210 field to the record (legacy) - It should be displayed as well Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136760|0 |1 is obsolete| | --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 136763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136763&action=edit Bug 30430: (QA follow-up) Several fixes Several fixes : - Replace tab with spaces tag_210 : - Class 'value' and not 'valeur' - Loop on subfields must restrict to abcdg otherwise last() may not be correct (ie 214r and 214s) tag_214 : - Condition for coma after b should be same as after a : "position() != last()" tag_210 and tag_214 : - Space before ':' like in other fields - ':' before c or g does not exist in opac, removed from intranet file - Search links in intranet fixed (where composed with opac-search ^^) - Search links using 'str:encode-uri' like other places - Simplify title attribute with only 'Search for publisher' => Bad idea to use double quotes in a text tag_214_s and tag_214_r : - Loop on field+subfield otherwise last() may not be correct I've fixed intranet and copied to OPAC (only adapted search links) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Great thanks for UNIMARC users ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430 --- Comment #25 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Lucas Gass from comment #24)

Enhancement will not be backported to 22.05.x series unless requested.

Hi Lucas, It would be great to have this in 22.05.x. This way our partners at BibLibre could benefit from this bug they helped to work on in a reasonable delay. I could also backport to 21.11.x. Thanks in advance, Arthur -- You are receiving this mail because: You are watching all bug changes.