[Bug 8324] New: User created lists sort by title just after editing sort order (call by opac-shelves.pl without sort parameter)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Priority: P5 - low Change sponsored?: --- Bug ID: 8324 Assignee: oleonard@myacpl.org Summary: User created lists sort by title just after editing sort order (call by opac-shelves.pl without sort parameter) Severity: enhancement Classification: Unclassified OS: All Reporter: veron@veron.ch Hardware: All Status: NEW Version: master Component: OPAC Product: Koha If you edit a user defined list in Opac, change the sort and then klick 'Save', the list always is displayed in title order (and not in the selected order). This is due to the fact that save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults to 'title'). If you go back to lists, choose in the table the list from List name, the param is correct and the list displays in expected order. Should be fixed because end users will think that changing the sort order is broken. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|User created lists sort by |Redisplay OPAC list with |title just after editing |correct sort after edit |sort order (call by | |opac-shelves.pl without | |sort parameter) | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20280&action=edit Bug 8324 - Redisplay OPAC list with correct sort after edit If you are viewing the contents of a list, edit it, change the default sort, and save your list will be redisplayed sorted by title no matter what default sort you chose. Lists do not automatically sort by their default sort, they must be opened with the sort parameter. This patch adds the list's sort parameter to the redirect after editing. To test, open an existing list in the OPAC which contains items. Click the "Edit list" link at the top of the list contents view. Change the default sort to something new. Click "Save." If the list is redisplayed using the new default sort the patch worked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20280|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20348&action=edit Bug 8324 - Redisplay OPAC list with correct sort after edit If you are viewing the contents of a list, edit it, change the default sort, and save your list will be redisplayed sorted by title no matter what default sort you chose. Lists do not automatically sort by their default sort, they must be opened with the sort parameter. This patch adds the list's sort parameter to the redirect after editing. To test, open an existing list in the OPAC which contains items. Click the "Edit list" link at the top of the list contents view. Change the default sort to something new. Click "Save." If the list is redisplayed using the new default sort the patch worked. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Quite odd, I cannot reproduce the issue. Without the patch: Opac > lists > my list. The default sort is "title". I am on the list results view and I click on the "Edit list" link. I change the "Sort this list by" value to "author", save. The results list is sorted by author. What I miss? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3)
Quite odd, I cannot reproduce the issue. Without the patch: Opac > lists > my list. The default sort is "title". I am on the list results view and I click on the "Edit list" link. I change the "Sort this list by" value to "author", save. The results list is sorted by author.
What I miss?
I too cannot reproduce this bug. Kyle -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Marking as Failed QA until we have a resolution for this. Owen, can you retest and let us know if you think this patch is still necessary? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Marc Véron <veron@veron.ch> --- I reported this bug in 2012. I can no longer reproduce the behaviour on current master (3.15.00.028) I hope it's OK to set it to RESOLVED WORKSFORME Marc -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org