[Bug 29936] New: Add ability to disable hold capture via SIP checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Bug ID: 29936 Summary: Add ability to disable hold capture via SIP checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Some libraries would like patrons to be able to return items via SIP, but for those returns to not automatically trigger the hold capture and automatic transfer process. (Akin to disabling 'AutomaticItemReturn' in the preferences which allows librarians to pick the action at the point of check-in), but for SIP devices. This enhancement would in effect makes the functionality that bug 3638 introduced optional. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, isn't that what HoldsNeedProcessingSIP does? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Interesting.. very nearly. I had entirely forgotten about that new preference.. however, it doesn't appear to resolve the transfers issue.. i.e. the hold is still captured, though it's marked as processing.. in the SIP code itself, the item may then be set to in transfer.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I really wish Holds and Transfers were better tied together.. it's somewhat mad that a hold can be set to in transfer without it actually triggering a transfer (in code) and thus you have to follow any call to ModReserveAffect with a Transfer anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- In fact.. our customer doesn't want SIP returns to result in holds captured at all in my understanding. They often have patrons just ignore the self check prompt to put the item into the exceptions bin and thus items are reshelved and not actually captured for the hold at all.. SO what they want is for the message to appear just in case the patron pays attention and thus puts the item in the exceptions bin.. but for the actual capture to require a staff check-in as the next step. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131555&action=edit Bug 29936: Add unit tests This patch adds a unit test for the new functionality introduced with holds_get_captured allowing for holds to still be highlighted to patrons at checkin but not mark them as found/transfered in the system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131556&action=edit Bug 29936: Add holds_get_captured option to sip config This patch adds a new option to the SIP config, allowing for hold capture to be disabled on difference devices. We still notice the hold and alert the user, but we do not trigger the update in the system to mark the hold as found (waiting, processing or in transit). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #7 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Thanks for this, Martin - we have this running on our live system and all is working well. Happy for my sign off to be added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131555|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131575&action=edit Bug 29936: Add unit tests This patch adds a unit test for the new functionality introduced with holds_get_captured allowing for holds to still be highlighted to patrons at checkin but not mark them as found/transfered in the system. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131556|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131576&action=edit Bug 29936: Add holds_get_captured option to sip config This patch adds a new option to the SIP config, allowing for hold capture to be disabled on difference devices. We still notice the hold and alert the user, but we do not trigger the update in the system to mark the hold as found (waiting, processing or in transit). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, thanks for confirming Sally. Signoff line added :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131575|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131577&action=edit Bug 29936: Add unit tests This patch adds a unit test for the new functionality introduced with holds_get_captured allowing for holds to still be highlighted to patrons at checkin but not mark them as found/transfered in the system. Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131576|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131578&action=edit Bug 29936: Add holds_get_captured option to sip config This patch adds a new option to the SIP config, allowing for hold capture to be disabled on difference devices. We still notice the hold and alert the user, but we do not trigger the update in the system to mark the hold as found (waiting, processing or in transit). Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |This enhancement adds a new released in| |`holds_get_captured` | |configuration option to SIP | |accounts. | | | |The new option | |defaults to enabled, as has | |been the case since bug | |3638 was pushed. However, | |it allows for disabling | |hold capture so that items | |are not automatically | |assigned to holds at SIP | |check-in; The alerts | |messages will continue to | |show, however, to allow | |items to be put to one side | |and then captured by a | |subsequent staff check-in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131577|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133763&action=edit Bug 29936: Add unit tests This patch adds a unit test for the new functionality introduced with holds_get_captured allowing for holds to still be highlighted to patrons at checkin but not mark them as found/transfered in the system. Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133764&action=edit Bug 29936: Add holds_get_captured option to sip config This patch adds a new option to the SIP config, allowing for hold capture to be disabled on difference devices. We still notice the hold and alert the user, but we do not trigger the update in the system to mark the hold as found (waiting, processing or in transit). Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133765&action=edit Bug 29936: (follow-up) Remove useless warining Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This enhancement adds a new |This enhancement adds a new released in|`holds_get_captured` |`holds_get_captured` |configuration option to SIP |configuration option to SIP |accounts. |accounts. | | |The new option |The new option |defaults to enabled, as has |defaults to |been the case since bug |enabled,22.05.00, to allow |3638 was pushed. However, |items to be put to one side |it allows for disabling |and then captured by a |hold capture so that items |subsequent staff check-in., |are not automatically |it allows for disabling |assigned to holds at SIP |hold capture so that items |check-in; The alerts |are not automatically |messages will continue to |assigned to holds at SIP |show, however, to allow |check-in; The alerts |items to be put to one side |messages will continue to |and then captured by a |show, however, as has been |subsequent staff check-in. |the case since bug 3638 was | |pushed. However Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|This enhancement adds a new |22.05.00 released in|`holds_get_captured` | |configuration option to SIP | |accounts. | | | |The new option | |defaults to | |enabled,22.05.00, to allow | |items to be put to one side | |and then captured by a | |subsequent staff check-in., | |it allows for disabling | |hold capture so that items | |are not automatically | |assigned to holds at SIP | |check-in; The alerts | |messages will continue to | |show, however, as has been | |the case since bug 3638 was | |pushed. However | Text to go in the| |This enhancement adds a new release notes| |`holds_get_captured` | |configuration option to SIP | |accounts. | | | |The new option | |defaults to enabled, as has | |been the case since bug | |3638 was pushed. However, | |it allows for disabling | |hold capture so that items | |are not automatically | |assigned to holds at SIP | |check-in; The alerts | |messages will continue to | |show, however, to allow | |items to be put to one side | |and then captured by a | |subsequent staff check-in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29936 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org