https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #1 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206027&action=edit Bug 42625: Add record source library group exemption schema Test plan: 1. Apply all patches, run updatedatabase.pl, yarn build and yarn api:bundle, then restart Plack 2. Administration > Library groups > New group. Enter a title, check "Use for record source editing", save, then add library A to the group with "Add library" 3. Administration > Record sources > New record source. Enter a name, leave "Can be edited" unchecked, select the group under "Editable by library groups" and save. Edit it again: the group is selected 4. Cataloging > MARC modification templates > New template. On the template page pick the source under "Set record source" and save. Do not add an action 5. Cataloging > Batch record modification > "Enter a list of record numbers". Enter a biblionumber, pick the template, continue and modify. The job reports success and the record's detail page shows "Record source: <name>" with a lock icon 6. Log in as a cataloguer from library B with edit_catalogue and records_batchmod but not edit_locked_records. On the record, Edit > Edit record is disabled with "This record is locked". Run step 5 again: the job reports "Its record source is locked and you do not have permission to edit it" 7. Log in as a cataloguer from library A with the same permissions. Edit > Edit record opens the editor 8. Still as this cataloguer, open the template from step 4. The "Set record source" form is replaced by read only text that names the source and the "Set record source" permission 9. As superlibrarian, edit the library group, uncheck "Use for record source editing" and click Update. Cancel the confirmation: the modal stays open. Click Update again and confirm. Edit the record source: no group is selected 10. Create a second, editable record source and a template that sets it. Batch modify the record from step 5 with it. The detail page shows the second source without a lock icon 11. Cataloging > Stage records for import. Upload a MARC file, pick the template from step 4 and stage. Open the job, click "View batch" and import the batch. The imported record shows the template's source 12. Start two Connexion daemons (misc/bin/connexion_import_daemon.pl) with import_mode: direct, different ports and marc_modification_template_id set to the two templates. Send a compatible marc record to each port. Each new record shows its daemon's source and Manage staged records lists one webservice batch per daemon 13. Run: prove t/db_dependent/Koha/RecordSource.t t/db_dependent/Koha/Patron.t t/db_dependent/Koha/Biblio.t t/db_dependent/LibraryGroups.t t/db_dependent/Koha/MarcModificationTemplates.t t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblio.t t/db_dependent/ImportBatch.t t/db_dependent/api/v1/library_groups.t t/db_dependent/api/v1/record_sources.t 14. Run: yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts,t/cypress/integration/Tools/MarcModificationTemplateRecordSource_spec.ts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #3 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206029&action=edit Bug 42625: Add Koha::Patron->can_edit_records_from -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206031&action=edit Bug 42625: Add /library_groups list endpoint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #7 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206033&action=edit Bug 42625: Accept and return library groups on record sources api -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206035&action=edit Bug 42625: Add library group selector to record source form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206037&action=edit Bug 42625: Add tests for RecordSource->library_groups -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #13 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206039&action=edit Bug 42625: Add tests for can_be_edited group exemption -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #15 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206041&action=edit Bug 42625: Add tests for record source library group API -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #17 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206043&action=edit Bug 42625: Add tests for group flag unlink behaviour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #19 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206045&action=edit Bug 42625: Add tests for batch update lock permissions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #21 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206047&action=edit Bug 42625: Add record source to import batches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #23 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206049&action=edit Bug 42625: Add record source selector to template admin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #25 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206051&action=edit Bug 42625: Apply template record source when staging and committing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #27 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206053&action=edit Bug 42625: Forward modification template from Connexion daemon -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #29 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206055&action=edit Bug 42625: Add tests for template record source objects -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #31 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206057&action=edit Bug 42625: Require set_record_sources to set a template record source -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #33 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206059&action=edit Bug 42625: Skip locked records when committing an import batch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #35 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206061&action=edit Bug 42625: DO NOT PUSH - DBIC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |CLAMS list of Sponsors| | Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206027|0 |1 is obsolete| | Attachment #206028|0 |1 is obsolete| | Attachment #206029|0 |1 is obsolete| | Attachment #206030|0 |1 is obsolete| | Attachment #206031|0 |1 is obsolete| | Attachment #206032|0 |1 is obsolete| | Attachment #206033|0 |1 is obsolete| | Attachment #206034|0 |1 is obsolete| | Attachment #206035|0 |1 is obsolete| | Attachment #206036|0 |1 is obsolete| | Attachment #206037|0 |1 is obsolete| | Attachment #206038|0 |1 is obsolete| | Attachment #206039|0 |1 is obsolete| | Attachment #206040|0 |1 is obsolete| | Attachment #206041|0 |1 is obsolete| | Attachment #206042|0 |1 is obsolete| | Attachment #206043|0 |1 is obsolete| | Attachment #206044|0 |1 is obsolete| | Attachment #206045|0 |1 is obsolete| | Attachment #206046|0 |1 is obsolete| | Attachment #206047|0 |1 is obsolete| | Attachment #206048|0 |1 is obsolete| | Attachment #206049|0 |1 is obsolete| | Attachment #206050|0 |1 is obsolete| | Attachment #206051|0 |1 is obsolete| | Attachment #206052|0 |1 is obsolete| | Attachment #206053|0 |1 is obsolete| | Attachment #206054|0 |1 is obsolete| | Attachment #206055|0 |1 is obsolete| | Attachment #206056|0 |1 is obsolete| | Attachment #206057|0 |1 is obsolete| | Attachment #206058|0 |1 is obsolete| | Attachment #206059|0 |1 is obsolete| | Attachment #206060|0 |1 is obsolete| | Attachment #206061|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #37 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206322&action=edit Bug 42625: Add library group accessor to Koha::RecordSource Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #39 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206324&action=edit Bug 42625: Honour library group exemptions in can_be_edited Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #41 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206326&action=edit Bug 42625: Add swagger spec for /library_groups Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #43 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206328&action=edit Bug 42625: Add record source editing flag to library groups admin Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #45 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206330&action=edit Bug 42625: Skip locked records in batch record modification Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #47 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206332&action=edit Bug 42625: Add tests for Patron->can_edit_records_from Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #49 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206334&action=edit Bug 42625: Add tests for /library_groups endpoint Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #51 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206336&action=edit Bug 42625: Unlink record sources when group flag is unchecked Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #53 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206338&action=edit Bug 42625: Add Cypress test for record source group selector Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #55 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206340&action=edit Bug 42625: Add record source to MARC modification templates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #57 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206342&action=edit Bug 42625: Add Koha objects for MARC modification templates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #59 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206344&action=edit Bug 42625: Take batch modification record source from template Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #61 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206346&action=edit Bug 42625: Accept modification template in svc/import_bib Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #63 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206348&action=edit Bug 42625: Add tests for record source in import batches Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #65 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206350&action=edit Bug 42625: Add tests for batch update record source from template Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #67 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206352&action=edit Bug 42625: Add Cypress test for template record source permission Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #69 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 206354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206354&action=edit Bug 42625: Add tests for locked records in BatchCommitRecords Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #71 from Brendan Lawlor <blawlor@clamsnet.org> --- This works as described and all the tests pass. I used Claude Sonnet 5 to help with testing step 12. With the two daemons running it used this command to send marc records to the daemon (updated to port 5501 for the second daemon: docker exec kohadev-koha-1 bash -c "(cat /tmp/connexion_overlay_452.mrc; printf '\000') | nc -q8 localhost 5500" which output: Success. Batch number 9 - biblio record number 452 overlaid by import. http://kohadev-intra.myDNSname.org:8081/cgi-bin/koha/catalogue/detail.pl?bib... I was able to create records with different sources this way. I would like to know what commands to do step 12 in ktd, but this did seem to work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- A user with edit_catalogue but not edit_locked_records should have "Modify record using template," "Replace record via z39.50," and "Delete record" disabled in the Edit dropdown on a locked bib record. These actions are correctly prevented with this code, but the user shouldn't be allowed to select them in the first place. With this code, a user records_batchmod but not set_record_sources can successfully use a batch mod template to edit the source of a record. A user without set_record_sources should not be able to select a template that contains a source change when performing a batch modification. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #73 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206516&action=edit Bug 42625: (QA follow-up) Disable locked record actions in Edit menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #75 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 206518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206518&action=edit Bug 42625: (QA follow-up) Add tests for locked record Edit menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36372 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #77 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Spotted two more things, but after these I think we're all set: Per new coding guidelines, the MARC mod template object you're adding here should include the option to record creation, modification, and deletion in the action logs (logging controlled by a syspref, module added to the filters in the log viewer) https://wiki.koha-community.org/wiki/Coding_Guidelines#ACTN2:_New_additions_... When I create a new MARC Mod Template by duplicating an existing template, the source change from my original template is not carried over to the new one, only the MARC actions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206321|0 |1 is obsolete| | Attachment #206322|0 |1 is obsolete| | Attachment #206323|0 |1 is obsolete| | Attachment #206324|0 |1 is obsolete| | Attachment #206327|0 |1 is obsolete| | Attachment #206328|0 |1 is obsolete| | Attachment #206329|0 |1 is obsolete| | Attachment #206330|0 |1 is obsolete| | Attachment #206331|0 |1 is obsolete| | Attachment #206332|0 |1 is obsolete| | Attachment #206333|0 |1 is obsolete| | Attachment #206335|0 |1 is obsolete| | Attachment #206336|0 |1 is obsolete| | Attachment #206337|0 |1 is obsolete| | Attachment #206338|0 |1 is obsolete| | Attachment #206339|0 |1 is obsolete| | Attachment #206340|0 |1 is obsolete| | Attachment #206341|0 |1 is obsolete| | Attachment #206342|0 |1 is obsolete| | Attachment #206343|0 |1 is obsolete| | Attachment #206344|0 |1 is obsolete| | Attachment #206345|0 |1 is obsolete| | Attachment #206346|0 |1 is obsolete| | Attachment #206347|0 |1 is obsolete| | Attachment #206348|0 |1 is obsolete| | Attachment #206349|0 |1 is obsolete| | Attachment #206350|0 |1 is obsolete| | Attachment #206351|0 |1 is obsolete| | Attachment #206352|0 |1 is obsolete| | Attachment #206353|0 |1 is obsolete| | Attachment #206354|0 |1 is obsolete| | Attachment #206355|0 |1 is obsolete| | Attachment #206516|0 |1 is obsolete| | Attachment #206517|0 |1 is obsolete| | Attachment #206518|0 |1 is obsolete| | Attachment #206519|0 |1 is obsolete| | Attachment #206325|0 |1 is obsolete| | Attachment #206326|0 |1 is obsolete| | Attachment #206334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #79 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208247&action=edit Bug 42625: Add library group accessor to Koha::RecordSource Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #81 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208249&action=edit Bug 42625: Honour library group exemptions in can_be_edited Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #83 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208251&action=edit Bug 42625: Accept and return library groups on record sources api Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #85 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208253&action=edit Bug 42625: Add library group selector to record source form Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #87 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208255&action=edit Bug 42625: Add tests for RecordSource->library_groups Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #89 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208257&action=edit Bug 42625: Add tests for can_be_edited group exemption Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #91 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208259&action=edit Bug 42625: Unlink record sources when group flag is unchecked Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #93 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208261&action=edit Bug 42625: Add Cypress test for record source group selector Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #95 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208263&action=edit Bug 42625: Add record source to MARC modification templates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #97 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208265&action=edit Bug 42625: Add Koha objects for MARC modification templates Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #99 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208267&action=edit Bug 42625: Take batch modification record source from template Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #101 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208269&action=edit Bug 42625: Accept modification template in svc/import_bib Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #103 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208271&action=edit Bug 42625: Add tests for record source in import batches Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #105 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208273&action=edit Bug 42625: Add tests for batch update record source from template Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #107 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208275&action=edit Bug 42625: Add Cypress test for template record source permission Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #109 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208277&action=edit Bug 42625: Add tests for locked records in BatchCommitRecords Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #111 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208279&action=edit Bug 42625: (QA follow-up) Hide source templates in batch modification Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #113 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208281&action=edit Bug 42625: (QA follow-up) Add tests for batch mod template filter Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #115 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208283&action=edit Bug 42625: (QA follow-up) Log MARC modification template changes Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #117 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208285&action=edit Bug 42625: (QA follow-up) Add tests for template action logs Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #119 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Created attachment 208287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208287&action=edit Bug 42625: DO NOT PUSH - DBIC Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|several new |several new |functionalities. |functionalities. |- When creating or editing |- When creating or editing |library groups, one can now |library groups, one can now |set the option "Use for |set the option "Use for |record source editing". |record source editing". |- When creating record |- When creating record |sources, one can define one |sources, one can define one |or more library groups to |or more library groups to |be allowed to edit records |be allowed to edit records |with this source. Only |with this source. Only |groups with the "Use for |groups with the "Use for |record source editing" |record source editing" |option set will be |option set will be |accessible for this |accessible for this |purpose. |purpose. |- When a record has a |- When a record has a |source set and that source |source set and that source |is editable by one or more |is editable by one or more |library groups, the record |library groups, the record |will only be editable by |will only be editable by |superlibrarians, users with |superlibrarians, users with |edit_locked_records |edit_locked_records |permission, and users with |permission, and users with |edit_catalogue permission |edit_catalogue permission |whose home library is in |whose home library is in |one of those groups. |one of those groups. |- Users with |- Users with |marc_modification_templates |marc_modification_templates |and set_record_sources |and set_record_sources |permissions are able to |permissions are able to |create MARC modification |create MARC modification |templates that change the |templates that change the |record source of a record. |record source of a record. |Changes to record source |Changes to record source |may be combined with |may be combined with |changes to MARC data or may |changes to MARC data or may |be saved in a template that |be saved in a template that |does not change MARC data. |does not change MARC data. |- Users with |- Users with |records_batchmod and |records_batchmod and |set_record_sources |set_record_sources |permissions may use MARC |permissions may use MARC |modification templates |modification templates |containing record source |containing record source |changes when performing |changes when performing |record batch modifications. |record batch modifications. |- When a user with |- When a user with |records_batchmod permission |records_batchmod permission |but without |but without |edit_locked_records |edit_locked_records |permission performs a batch |permission performs a batch |modification on a group of |modification on a group of |records containing one or |records containing one or |more locked records, the |more locked records, the |locked records that were |locked records that were |not modified are noted in |not modified are noted in |the background job details. |the background job details. |- The OCLC Connexion daemon |- The OCLC Connexion daemon |can now be configured to |can now be configured to |apply a MARC modification |apply a MARC modification |template when importing |template when importing |records. |records. |- Creation, modification, |- Creation, modification, |and deletion of MARC |and deletion of MARC |modification templates will |modification templates will |now be logged if the new |now be logged if the new |MarcModificationTemplatesLo |MarcModificationTemplatesLo |g system prefrence is |g system preference is |enabled. |enabled. This logging does | |not include the changes to | |the actions related to a | |MARC modification template. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #120 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208347&action=edit Bug 42625: Add record source library group exemption schema Test plan: 1. Apply all patches, run updatedatabase.pl, yarn build and yarn api:bundle, then restart Plack 2. Administration > Library groups > New group. Enter a title, check "Use for record source editing", save, then add library A to the group with "Add library" 3. Administration > Record sources > New record source. Enter a name, leave "Can be edited" unchecked, select the group under "Editable by library groups" and save. Edit it again: the group is selected 4. Cataloging > MARC modification templates > New template. On the template page pick the source under "Set record source" and save. Do not add an action 5. Cataloging > Batch record modification > "Enter a list of record numbers". Enter a biblionumber, pick the template, continue and modify. The job reports success and the record's detail page shows "Record source: <name>" with a lock icon 6. Log in as a cataloguer from library B with edit_catalogue and records_batchmod but not edit_locked_records. On the record, Edit > Edit record is disabled with "This record is locked". Run step 5 again: the job reports "Its record source is locked and you do not have permission to edit it" 7. Log in as a cataloguer from library A with the same permissions. Edit > Edit record opens the editor 8. Still as this cataloguer, open the template from step 4. The "Set record source" form is replaced by read only text that names the source and the "Set record source" permission 9. As superlibrarian, edit the library group, uncheck "Use for record source editing" and click Update. Cancel the confirmation: the modal stays open. Click Update again and confirm. Edit the record source: no group is selected 10. Create a second, editable record source and a template that sets it. Batch modify the record from step 5 with it. The detail page shows the second source without a lock icon 11. Cataloging > Stage records for import. Upload a MARC file, pick the template from step 4 and stage. Open the job, click "View batch" and import the batch. The imported record shows the template's source 12. Start two Connexion daemons (misc/bin/connexion_import_daemon.pl) with import_mode: direct, different ports and marc_modification_template_id set to the two templates. Send a compatible marc record to each port. Each new record shows its daemon's source and Manage staged records lists one webservice batch per daemon 13. Run: prove t/db_dependent/Koha/RecordSource.t t/db_dependent/Koha/Patron.t t/db_dependent/Koha/Biblio.t t/db_dependent/LibraryGroups.t t/db_dependent/Koha/MarcModificationTemplates.t t/db_dependent/Koha/BackgroundJob/BatchUpdateBiblio.t t/db_dependent/ImportBatch.t t/db_dependent/api/v1/library_groups.t t/db_dependent/api/v1/record_sources.t 14. Run: yarn cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts,t/cypress/integration/Tools/MarcModificationTemplateRecordSource_spec.ts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #122 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208349&action=edit Bug 42625: Add Koha::Patron->can_edit_records_from Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #124 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208351&action=edit Bug 42625: Add record source editing flag to library groups API Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #126 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208353&action=edit Bug 42625: Add record source editing flag to library groups admin Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #128 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208355&action=edit Bug 42625: Skip locked records in batch record modification Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #130 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208357&action=edit Bug 42625: Add tests for Patron->can_edit_records_from Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #132 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208359&action=edit Bug 42625: Add tests for record source library group API Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #134 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208361&action=edit Bug 42625: Add tests for group flag unlink behaviour Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #136 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208363&action=edit Bug 42625: Add tests for batch update lock permissions Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #138 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208365&action=edit Bug 42625: Add record source to import batches Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #140 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208367&action=edit Bug 42625: Add record source selector to template admin Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #142 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208369&action=edit Bug 42625: Apply template record source when staging and committing Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #144 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208371&action=edit Bug 42625: Forward modification template from Connexion daemon Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #146 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208373&action=edit Bug 42625: Add tests for template record source objects Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #148 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208375&action=edit Bug 42625: Require set_record_sources to set a template record source Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #150 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208377&action=edit Bug 42625: Skip locked records when committing an import batch Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #152 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208379&action=edit Bug 42625: (QA follow-up) Disable locked record actions in Edit menu Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #154 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208381&action=edit Bug 42625: (QA follow-up) Add tests for locked record Edit menu Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #156 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208383&action=edit Bug 42625: (QA follow-up) Add MarcModificationTemplatesLog syspref Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #158 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208385&action=edit Bug 42625: (QA follow-up) Copy record source on template duplicate Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #160 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208387&action=edit Bug 42625: (QA follow-up) Add tests for duplicate record source Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #162 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208389&action=edit Bug 42625: (QA follow-up) Update MARCImportCommitBatch.t for num_locked BatchCommitRecords now returns a seventh value, the number of records skipped because they are locked. The mocked return values in MARCImportCommitBatch.t only supplied six, so $num_locked was undef and the job raised 'uninitialized value' warnings, failing Test::NoWarnings. This patch adds the seventh value to the existing mocks and adds a case covering a batch where some records are skipped as locked. Test plan: 1. prove t/db_dependent/Koha/BackgroundJob/MARCImportCommitBatch.t 2. All tests pass, with no warnings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #164 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 208391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208391&action=edit Bug 42625: (QA follow-up) Require set_record_sources in svc/import_bib svc/import_bib only requires editcatalogue:edit_catalogue, but it accepts a marc_modification_template_id and stamps that template's record source on the webservice batch and the records committed from it. Any cataloguer could therefore assign a record source through the webservice, bypassing the set_record_sources permission that batch record modification and staging enforce. This patch refuses the request with status 'failed' and error 'set_record_source_not_allowed' when the template sets a record source and the authenticated user lacks set_record_sources. Templates without a record source keep working as before. Test plan: 1. Run yarn cypress run --spec t/cypress/integration/Tools/MarcModificationTemplateRecordSource_spec.ts 2. All tests pass: a superlibrarian posting to svc/import_bib with a template that sets a record source gets status 'ok', and a user with only edit_catalogue gets status 'failed' with error 'set_record_source_not_allowed' Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42625 --- Comment #166 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- In hindsight, this should have been several distinct bugs from the start. I worry that it's going to be prohibitively difficult to pick them apart now, but this would have been better as: Bug 1 - Tie record sources to library groups Bug 2 - Improve enforcement of record locking Bug 3 - Add ability to change record source via MARC mod template Bug 4 - Add ability to apply MARC mod template via Connexion import -- You are receiving this mail because: You are watching all bug changes.