[Bug 11763] New: Consolidate fund action links into menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Bug ID: 11763 Summary: Consolidate fund action links into menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/aqbudgets.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 11578 Similar to the change made in Bug 10615, we should move the Edit/Delete/Add child links to a menu. This will save space and make the links more distinct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25273&action=edit Bug 11763 - Consolidate fund action links into menu This patch moves the fund Edit/Delete/Add child links on the fund view into a pop-up menu, allow the table to be more compact and the links to be more distinct. To test you must apply the patches on Bug 11578 if necessary. Apply the patch and view the funds list page (Administration -> Funds). For each line there should be an "Actions" menu containing the Edit/Delete/Add cihld links. Each should function correctly. Test with inactive budgets shown and hidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25273|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25281&action=edit Bug 11763 - Consolidate fund action links into menu This patch moves the fund Edit/Delete/Add child links on the fund view into a pop-up menu, allow the table to be more compact and the links to be more distinct. To test you must apply the patches on Bug 11578 if necessary. Apply the patch and view the funds list page (Administration -> Funds). For each line there should be an "Actions" menu containing the Edit/Delete/Add cihld links. Each should function correctly. Test with inactive budgets shown and hidden. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It is unusual to open the action list above the button, but it works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, it looks like the depending bug is still waiting for sign off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #3)
Hm, it looks like the depending bug is still waiting for sign off?
Hm, yes :) I cannot sign it off, I am the author of the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The dependent bug still needs a sign off - hoping to get back to this soon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
The dependent bug still needs a sign off - hoping to get back to this soon.
Does someone check the BLOCKED queue? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I was hoping the developers would, but you might be right that it could get lost there. For me I was looking at this bug for the fifth time or so, realizing that I couldn't really test it yet. Someone, please signoff 11578? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Summary|Consolidate fund action |[DEPENDENCY STILL NEEDS |links into menu |SIGNOFF] Consolidate fund | |action links into menu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|[DEPENDENCY STILL NEEDS |Consolidate fund action |SIGNOFF] Consolidate fund |links into menu |action links into menu | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25281|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27770&action=edit [PASSED QA] Bug 11763 - Consolidate fund action links into menu This patch moves the fund Edit/Delete/Add child links on the fund view into a pop-up menu, allow the table to be more compact and the links to be more distinct. To test you must apply the patches on Bug 11578 if necessary. Apply the patch and view the funds list page (Administration -> Funds). For each line there should be an "Actions" menu containing the Edit/Delete/Add cihld links. Each should function correctly. Test with inactive budgets shown and hidden. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It is unusual to open the action list above the button, but it works. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple patch, easy to test. No regressions. Passed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11763 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org