[Bug 18561] New: Use font awesome icons for plus signs in forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Bug ID: 18561 Summary: Use font awesome icons for plus signs in forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | Component|Staff Client |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63289&action=edit Bug 18561: Use Font Awesome icons for plus (and minus) signs in forms Test plan: 0. Apply the patch 1. Go to these forms and confirm that you can see new plus (minus) sign icon and that this cion does work as before - Acquisiton - search for orders form in header - Patrons - patron search in header - Advanced catalogue search - more options has to be activated - Opac - advanced search - more options has to be activated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Owen, does it make sense to you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I think this would not work well with screen readers. I suppose they way it is right now (with a text +) is probably not great for screen readers either. Filament Group has a good reputation for thoughtful articles on this kind of thing: https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html Their "Critical icons" section is interesting, but requires the js library Modernizr. I think this issue requires some more discussion and investigation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #3)
I think this would not work well with screen readers. I suppose they way it is right now (with a text +) is probably not great for screen readers either.
Filament Group has a good reputation for thoughtful articles on this kind of thing:
https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html
Their "Critical icons" section is interesting, but requires the js library Modernizr.
I think this issue requires some more discussion and investigation.
Good point Owen, thanks! Accessibility should be important for us of course... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Indeed but a lot of the template use Font Awesome icons for important actions. Maybe using "title" attribute can provide an alternate text. My 2c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As far as I could see, these templates have all been changed since. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org