[Bug 6299] New: Provide a list of authorized values for relator terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Bug #: 6299 Summary: Provide a list of authorized values for relator terms Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: tomascohen@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Provide the user an optional thesaurus that can be linked from "relator term" fields in cataloguing frameworks. For MARC21 there exists a list: MARC Code List for Relators http://www.loc.gov/marc/relators/relaterm.html Caveats: - The default values description should be translatable. Perhaps On-the-fly translation, or as a fixed list of values in the templates. Something to discuss. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |tomascohen@gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-06-07 14:30:04 UTC --- Created attachment 4398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4398 Initial patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-07-06 16:23:15 UTC --- can you include 'how to test' instructions here? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-07-07 16:20:36 UTC --- To test: Make a normal install, choose 'MARC Code List for Relators, as of http://www.loc.gov/marc/relators/relaterm.html (marc21_relatorterms)" in the Optional data section of the Choose frameworks step. Then edit a MARC Framework and choose to link 700$e to the list of authorized values MARCRELATOR Success should be: - You can choose to install MaRC relator terms data - You can link to that list in your frameworks -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4398|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-07-07 17:31:35 UTC --- Created attachment 4577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4577 Fix category name lenght MARCRELATOR is larger than the 10 char limit of the field. It is now called RELTERMS. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-07-09 12:09:03 UTC --- Okay, and how do we test this if we're a library upgrading - not a new install? There should be an option for those who are on Koha already and just upgrading from an older version (as I am on my test machine). Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-07-18 17:46:31 UTC --- Prompting the user for loading 'new in koha' sample data is not a feature Koha provides right now. Maybe there could be a new bug filled for that. As of this bug, it should be signed-off if it happens to work on new installs, as any other optional data's SQL files. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> 2011-07-22 09:55:50 UTC --- Not tested on a new install, but with $ mysql -u user -p db_name < installer/data/mysql/en/optional/marc21_relatorterms.sql and it works fine. Waiting for someone testing on a new install. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-04 10:32:45 UTC ---
There should be an option for those who are on Koha already and just upgrading from an older version (as I am on my test machine).
I think this patch provides an excellent addition of sample MARC data. The install script offers the option as advertised. (Did not run it though.) But I agree with Nicole that only this patch will not help existing installs. An experienced user may run mysql from the command-line, but that seems not to be enough. (How would he know at first?) An informational warning on the updatedatabase screen could be helpful as well as additional information in the INSTALL files. (But even these two things may be overlooked easily.) Additionally, minor point: Should you better test on the existence of RELTERMS in the table before inserting? I already have RELTERM in my data; could easily have been RELTERMS too. If RELTERMS should exist somewhere already, you would probably want to insert them under a different name. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-08-04 12:08:01 UTC --- Marcel, (In reply to comment #8)
There should be an option for those who are on Koha already and just upgrading from an older version (as I am on my test machine).
As stated before, I asked on this on IRC and I was told there is no way to handle this properly (i.e. prompt the user to make desitions on this). As I see it, this is not different to sample patron types and such. If you think I should add an advice on updatedatabase.pl just let me know. If you think we should have a method for prompting the user to make a desition just let me know, and we can fill a new bug to work on that. Regards To+ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-04 13:01:55 UTC --- (In reply to comment #9)
As I see it, this is not different to sample patron types and such.
I think you are right about that. I would however add at least a statement to the upgrading user via the updatedatabase script telling him that he could add relator terms now (if you mention that you are adding under RELTERMS, you partially cover my other remark about the name too). So, I would be willing to sign off. I now tested the patch on an empty db. That worked okay. But unfortunately I saw then that several of the descriptions are somehow truncated in your list (sound should be sound designer, supporting should be supporting host, etc.) It seems that a lot of the two-or-more-words descriptions only contain one word. (You have 80 chars there.) Therefore I suggest to let somebody correct this list first and add a line to updatedatabase. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4577|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-08-04 20:51:56 UTC --- Created attachment 4847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4847 Complete list, complete strings As noted by Marcel, strings where truncated. Fixed that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-08-04 20:53:38 UTC --- Created attachment 4848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4848 advertise availability in updatedatabase.pl I put it in a different patch so the resubmited patch when need to rebase is smaller :-P I assume 3 or 4 rebases follow. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> 2011-08-05 08:49:17 UTC --- Created attachment 4855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4855 Screenshot of updatedb page Printing a '\n' in updatedatabase.pl cause lines to be treated as html list items (see screenshot). I think you must keep only the last line feed (just esthetical issue however). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4848|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-08-08 14:47:51 UTC --- Created attachment 4890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4890 advertise availability in updatedatabase.pl (single line) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-08-08 14:53:16 UTC --- If anyone is about to sign this please wait until I provide a es-ES script, now that language is on master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-10 13:44:33 UTC --- (In reply to comment #15)
If anyone is about to sign this please wait until I provide a es-ES script, now that language is on master. Tomas, I am signing off now on both patches. Please send a small followup fix for Spanish.
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4847|0 |1 is obsolete| | --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-10 13:49:10 UTC --- Created attachment 4937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4937 Signed patch (complete strings) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4890|0 |1 is obsolete| | --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-10 13:50:50 UTC --- Created attachment 4938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4938 Signed patch (updatedatabase advertisement) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> 2011-08-10 14:48:01 UTC --- Created attachment 4940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4940 es-ES was missing es-ES translation will come when our happy librarians finish translating. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4940|0 |1 is obsolete| | --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-11 07:09:17 UTC --- Created attachment 4957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4957 Signed follow up patch for Spanish -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 12:56:49 UTC --- Created attachment 5735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5735 Bug 6299 - add es-ES Translation will come next, when our librarians finish the translation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> August 11, 2011: Follow up for Spanish signed off. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 12:57:02 UTC --- Created attachment 5736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5736 Bug 6299 - Advertise this addition during upgrade Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> August 10, 2011: Fixed some small typos. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Oct 7th, 2011: rebased for master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4957|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4938|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 13:10:25 UTC --- QA comment: * installer only patch * add some datas in authorised values, nothing "dangerous" My only concern is that fr, de, ... versions are also in english. But that can be addessed in another patch, and should not delay passed QA imo so, marking "passed QA", but chris, I wouldn't complain if you set "failed QA" because of the language comment I made -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Failed QA --- Comment #24 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-06 14:56:53 UTC --- updatedatabase.pl patch has <<<<<<<<< HEAD relic. I recommend that we remove any of the SQL files for languages that do not have their translations in place. It's extra work for a system administrator to remove those untranslated values after they're added, and the lack of support for certain languages is not advertised. The sysadmin will still have the choice to upload an existing language. In addition to removing these untranslated SQL files, I also recommend altering the updatedatabase.pl script to indicate exactly which languages are currently supported. Marking as Failed QA until the git merge relic is removed, and the recommendations for handling untranslated files is addressed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 15:08:55 UTC --- yikes ! sorry for the <<<< relic, it's me !!! OK for the translation proposal, that's a good option. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4937|0 |1 is obsolete| | --- Comment #26 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 15:44:34 UTC --- Created attachment 7371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7371 Bug 6299 - Provide a list of authorized values for Relator terms Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> August 10,2011: Tested install and upgrade. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> January 28, 2012: Removed untranslated non-en SQL relator term files. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7371|0 |1 is obsolete| | --- Comment #27 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 15:44:48 UTC --- Created attachment 7372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7372 Bug 6299 - Advertise this addition during upgrade Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> August 10, 2011: Fixed some small typos. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Oct 7th, 2011: rebased for master Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> January 12, 2012: Noted that RELTERMs are currently available only for en. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5736|0 |1 is obsolete| | Attachment #7372|0 |1 is obsolete| | --- Comment #28 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 15:46:00 UTC --- Created attachment 7373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7373 Bug 6299 - Provide a list of authorized values for Relator terms Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> August 10,2011: Tested install and upgrade. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> January 28, 2012: Removed untranslated non-en SQL relator term files. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #29 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 15:46:10 UTC --- Created attachment 7374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7374 Bug 6299 - Advertise this addition during upgrade Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> August 10, 2011: Fixed some small typos. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Oct 7th, 2011: rebased for master Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> January 12, 2012: Noted that RELTERMs are currently available only for en. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #30 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 15:47:19 UTC --- Made the changes requested by Ian, and returning the status to signed off. Note that the "add es-ES" patch should *not* be applied, as it has not been translated yet. tcohen's comment indicates that a translation is in the works. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7374|0 |1 is obsolete| | --- Comment #31 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-29 13:41:31 UTC --- Created attachment 7378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7378 Bug 6299 - Advertise this addition during upgrade Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> August 10, 2011: Fixed some small typos. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Oct 7th, 2011: rebased for master Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> January 12, 2012: Noted that RELTERMs are currently available only for en. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #32 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-29 13:41:57 UTC --- Oops. I didn't actually change the status. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #33 from Frédéric Demians <frederic@tamil.fr> 2012-01-30 17:09:35 UTC --- The MARC Code List for Relators is here: http://www.loc.gov/marc/relators/relacode.html The translation of this table in French is available here: http://www.marc21.ca/040010-220-f.html -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #34 from Frédéric Demians <frederic@tamil.fr> 2012-01-30 18:16:49 UTC --- Created attachment 7389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7389 Relator codes in French -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #35 from Frédéric Demians <frederic@tamil.fr> 2012-01-30 18:17:45 UTC --- Additional sign-off required for 'Relator codes in Frenche' patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7389|0 |1 is obsolete| | --- Comment #36 from Frédéric Demians <frederic@tamil.fr> 2012-02-01 11:17:19 UTC --- Created attachment 7408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7408 Relator codes in French v2: fixing typos To test: Add it to your db cd <koha-root>/installer/data/mysql/fr-FR/marcflavour/marc21/Optionnel cat marc21_relatorterms.sql | mysql <koha-db> -u <koha-user> -p <koha-pwd> In Koha pro > Administration > Authorized values, you have a new RELTERMS list containing added relator codes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> 2012-02-01 13:07:41 UTC --- I've been out on vacations. Next week I'll provide a new patch for the spanish translation which I have at the office. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7408|0 |1 is obsolete| | --- Comment #38 from Frédéric Demians <frederic@tamil.fr> 2012-02-07 18:53:29 UTC --- Created attachment 7490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7490 Relator codes in French Fix a typo thanks to Tomás. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7490|0 |1 is obsolete| | --- Comment #39 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-08 12:02:11 UTC --- Created attachment 7500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7500 Bug 6299 Add relator codes for fr-FR Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Confirmed that the RELTERMS authorised values category is populated. Not knowing French I can't comment on the translations, but any errors can be corrected at a later date. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5735|0 |1 is obsolete| | --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> 2012-02-08 14:20:51 UTC --- Created attachment 7501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7501 Bug 6299 - add es-ES -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> 2012-02-08 14:23:37 UTC --- Spanish translation added, no signoff yet. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7501|0 |1 is obsolete| | --- Comment #42 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-08 17:07:30 UTC --- Created attachment 7509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7509 Bug 6299 - add es-ES Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Confirmed that the RELTERMS authorised values category is populated. Not knowing Spanish I can't comment on the translations, but any errors can be corrected at a later date. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #43 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 21:25:32 UTC --- QA comment: Those patches look OK, however, when trying to apply the FR & ES translations, I get a nasty: fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6299 - add es-ES When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". (same for FR) Any idea why Jared ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> 2012-02-14 13:28:48 UTC --- (In reply to comment #43)
QA comment:
Those patches look OK, however, when trying to apply the FR & ES translations, I get a nasty:
fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6299 - add es-ES When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort".
(same for FR)
Any idea why Jared ?
There must have been an addition to updatedatabase.pl that makes patches don't apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7378|0 |1 is obsolete| | Attachment #7500|0 |1 is obsolete| | Attachment #7509|0 |1 is obsolete| | --- Comment #45 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-14 16:55:50 UTC --- Created attachment 7637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7637 Bug 6299 Add relator codes for fr-FR Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Confirmed that the RELTERMS authorised values category is populated. Not knowing French I can't comment on the translations, but any errors can be corrected at a later date. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #46 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-14 16:56:04 UTC --- Created attachment 7638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7638 Bug 6299 - add es-ES Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Confirmed that the RELTERMS authorised values category is populated. Not knowing Spanish I can't comment on the translations, but any errors can be corrected at a later date. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 --- Comment #47 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-14 16:56:16 UTC --- Created attachment 7639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7639 Bug 6299 - Advertise this addition during upgrade Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> August 10, 2011: Fixed some small typos. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Oct 7th, 2011: rebased for master Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #48 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-14 16:57:01 UTC --- Rebased to fix the problem that Paul encountered. Reordered the patches to simplify later rebasings. Returning to Passed QA status. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #49 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-14 20:35:54 UTC --- perfect, this time, worked well ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6299 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org