[Bug 20014] New: When adding to basket from a staged file item budgets are selected my matching on code , not id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Bug ID: 20014 Summary: When adding to basket from a staged file item budgets are selected my matching on code, not id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Budget codes are not unique (duplicated on rollover) currently if you have two codes two will be marked selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70638&action=edit Bug 20014: Preselect item budget based on id not code To test: 1 - Have the same fund code in two budgets 2 - Have budget code defined in MarcItemFieldsToOrder 3 - Stage a file with some order items as defined above 4 - Inspect the fuinds drop down in the item, notice two lines are marked selected 5 - Apply patch 6 - Repeat 7 - Only one field should be selected, with a preference for active budget -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Zoe Bennett <zoebennett1308@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zoebennett1308@gmail.com Status|Needs Signoff |Failed QA --- Comment #2 from Zoe Bennett <zoebennett1308@gmail.com> --- We couldn't reproduce the bug we have tried putting two funds with the same code in one budget and two funds with the same code in two separate budgets and both times nothing was selected in the drop down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Retested on master, I can recreate: Setup a budget with some funds Duplicate the budget,make one of them inactive MarcFieldsToOrder: price: 975$p quantity: 975$q budget_code: 975$h MarcItemFieldsToOrder: homebranch: 975$a holdingbranch: 975$b itype: 975$y nonpublic_note: 975$x public_note: 975$z loc: 975$c ccode: 975$8 notforloan: 975$7 quantity: 975$q price: 975$g replacementprice: 975$v uri: 975$u 975 from record: =975 \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK You will need to adjust subfield $h to the name of on of your funds that is duplicated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com --- Comment #4 from Charles Farmer <charles.farmer@inlibro.com> ---
975 from record: =975 \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK
You will need to adjust subfield $h to the name of on of your funds that is duplicated
This will definitely have to be rephrased, because like Zoe Bennett, I couldn't reproduce the issue. I did as you said, created two budgets, with one fund that had the same code, and yet, when I used the staged file to add items to a new basket, there was only one budget name in the dropdown menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76113&action=edit Budget setup Example budgets/funds to illustrate issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76114&action=edit View of double selected elements on adding to basket View of the issue when adding from staged to basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76115&action=edit Example marc file for staging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Charles Farmer from comment #4)
975 from record: =975 \\$7-1$8b$cO$g8.90$hSHOES$p8.90$q1$u14.95$v14.95$yBOOK
You will need to adjust subfield $h to the name of on of your funds that is duplicated
This will definitely have to be rephrased, because like Zoe Bennett, I couldn't reproduce the issue.
I did as you said, created two budgets, with one fund that had the same code, and yet, when I used the staged file to add items to a new basket, there was only one budget name in the dropdown menu.
I added an example file and screenshots, I changed the fund name to show that both are selected, the problem persists if the names are the same or different -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When adding to basket from |When adding to basket from |a staged file item budgets |a staged file item budgets |are selected my matching on |are selected by matching on |code, not id |code, not id CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If I am not mistaken it will use the last added fund from an active budget when you have multiple active budgets with the same fund codes. This might still cause a surprise for people with a strange budget/fund creation history, but I don't see a better way to pick 'one' fund. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wish our code was less confusing - budget should be fund. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70638|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77872&action=edit Bug 20014: Preselect item budget based on id not code To test: 1 - Have the same fund code in two budgets 2 - Have budget code defined in MarcItemFieldsToOrder 3 - Stage a file with some order items as defined above 4 - Inspect the fuinds drop down in the item, notice two lines are marked selected 5 - Apply patch 6 - Repeat 7 - Only one field should be selected, with a preference for active budget Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77872|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78039&action=edit Bug 20014: Preselect item budget based on id not code To test: 1 - Have the same fund code in two budgets 2 - Have budget code defined in MarcItemFieldsToOrder 3 - Stage a file with some order items as defined above 4 - Inspect the fuinds drop down in the item, notice two lines are marked selected 5 - Apply patch 6 - Repeat 7 - Only one field should be selected, with a preference for active budget Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for 17.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20014 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12652 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org