[Bug 18993] New: Bump libtest-simple-perl to 1.302075
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Bug ID: 18993 Summary: Bump libtest-simple-perl to 1.302075 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org CC: mirko@abunchofthings.net This is needed for bugs 18055 and 18979 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18055, 18979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 [Bug 18055] Speed up '00-strict.t' test https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 [Bug 18979] Speed up 'valid-templates.t' tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mirko@abunchofthings.net |ity.org | --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Mirko, can you do this one please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 65296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65296&action=edit Bug 18993 - Bump libtest-simple-perl to 1.302075 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- I have backported libtest-simple-perl 1.302075-2 from Debian Unstable and uploaded it to all repositories. Version in Debian Jessie was only 1.001008-1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65296|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 65331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65331&action=edit Bug 18993 - Bump libtest-simple-perl to 1.302075 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Perl core has a sufficient version in v5.25.8
corelist -a Test::Simple […] v5.25.8 1.302073
For Debian that means perl-modules-5.26 will be the first alternative to libtest-simple-perl 1.302075. This should be reflected in debian/control(.in) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> ---
v5.25.8 1.302073
Obviously the version is lower … my bad. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65331|0 |1 is obsolete| | --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 65333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65333&action=edit Bug 18993 - Bump libtest-simple-perl to 1.302075 Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #8 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #7)
Created attachment 65333 [details] [review] Bug 18993 - Bump libtest-simple-perl to 1.302075
Signed-off-by: Mason James <mtj@kohaaloha.com>
looks good Mirko, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- 'Test::More' => { 'usage' => 'Core', 'required' => '1', 'min_ver' => '0.8' }, Shouldn't we upgrade the min_ver for this one here too ? Needs feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marcel, I do not understand. This bug report is about Test::Simple. 0.8 is old instead, but why do we need to fix it now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to Marcel de Rooy from comment #9)
'Test::More' => { 'usage' => 'Core', 'required' => '1', 'min_ver' => '0.8' },
Shouldn't we upgrade the min_ver for this one here too ?
Needs feedback
hi Marcel, the short answer is no Test::Simple has no dependency on Test::More, therefore there is no need to upgrade Test::More https://packages.debian.org/jessie/libtest-simple-perl https://packages.debian.org/stretch/libtest-simple-perl ..does that make sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Mason James from comment #11)
(In reply to Marcel de Rooy from comment #9)
'Test::More' => { 'usage' => 'Core', 'required' => '1', 'min_ver' => '0.8' },
Shouldn't we upgrade the min_ver for this one here too ?
Needs feedback
hi Marcel, the short answer is no
Test::Simple has no dependency on Test::More, therefore there is no need to upgrade Test::More
https://packages.debian.org/jessie/libtest-simple-perl https://packages.debian.org/stretch/libtest-simple-perl
..does that make sense?
Hey MJ, When I follow that link, I see that libtest-simple-perl includes Test::More ! Marcel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67563&action=edit Bug 18993: Bump Test::More to 1.302075 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So, moving on now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #15 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #14)
So, moving on now?
yes, looks good :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Mirko Tietgen from comment #6)
v5.25.8 1.302073
Obviously the version is lower … my bad.
The patch still references perl-modules-5.26 as an alternative to libtest-simple-perl. Shouldn't it be removed ? If 1.302073 is ok I think we should use that version in PerlDependencies.pm and debian/control -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Failing for comment 16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #18 from Mason James <mtj@kohaaloha.com> --- (In reply to Julian Maurice from comment #16)
(In reply to Mirko Tietgen from comment #6)
v5.25.8 1.302073
Obviously the version is lower … my bad.
The patch still references perl-modules-5.26 as an alternative to libtest-simple-perl. Shouldn't it be removed ? If 1.302073 is ok I think we should use that version in PerlDependencies.pm and debian/control
good news.. the tests PASS with 1.302073 i'll add a patch with the correction -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #19 from Mason James <mtj@kohaaloha.com> --- Created attachment 69173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69173&action=edit Bug 18993: Allow Test::More version 1.302073 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Mason James <mtj@kohaaloha.com> --- setting to status back to SO? good spotting Julian! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- libtest-simple-perl is listed twice in Build-Depends (debian/control), the first without version constraint (comes from __AUTODEPENDS__). This is probably nothing but maybe lintian will complain about that. But it's already like that in master, so this will not prevent QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65333|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69175&action=edit Bug 18993 - Bump libtest-simple-perl to 1.302075 Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67563|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69176&action=edit Bug 18993: Bump Test::More to 1.302075 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69173|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69177&action=edit Bug 18993: Allow Test::More version 1.302073 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bump libtest-simple-perl to |Bump libtest-simple-perl to |1.302075 |1.302073 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What is the current status here? This seems to be needed for two bugs which are blocked/in discussion.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Ah I forgot to change status to Passed QA. Fixed! Thanks Marcel -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Skipping for 17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Julian Maurice from comment #16)
(In reply to Mirko Tietgen from comment #6)
v5.25.8 1.302073
Obviously the version is lower … my bad.
The patch still references perl-modules-5.26 as an alternative to libtest-simple-perl. Shouldn't it be removed ? If 1.302073 is ok I think we should use that version in PerlDependencies.pm and debian/control
Speaking of perl-modules-5.26 -- I can't follow the https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way instructions to roll a custom package any more. It had perl-modules-5.22 and perl-modules-5.24, but those were removed too. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 --- Comment #30 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to M. Tompsett from comment #29)
Speaking of perl-modules-5.26 -- I can't follow the https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way instructions to roll a custom package any more. It had perl-modules-5.22 and perl-modules-5.24, but those were removed too. :(
Could you please open a new bug and give more details? (What are you trying to do? build-git-snapshot, something else? Which version of Koha, on which OS in what version? what is expected, what is actually happening?) Please add me to the CC list if you do and I'll have a look. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org