[Bug 39124] New: In lists dropdown, the option "view all" is always displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Bug ID: 39124 Summary: In lists dropdown, the option "view all" is always displayed Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org In the code of the OPAC, the "Lists" dropdown menu is supposed to display max. 10 lists and display a button "view all" if there are more than 10 lists. The button "view all" is always displayed and it is weird when there are few lists because "Public lists" and "Your lists" do the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 177990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177990&action=edit Bug 39124: In lists dropdown, the option "view all" is always displayed In the code of the OPAC, the "Lists" dropdown menu is supposed to display max. 10 lists and display a button "view all" if there are more than 10 lists. The button "view all" is always displayed and it is weird when there are few lists because "Public lists" and "Your lists" do the same. Test plan: 1 - On an OPAC with less than 10 public lists and 10 private lists, navigate to /cgi-bin/koha/opac-shelves.pl, click on the dropdown see there is a view all button for both types of lists 2 - APPLY PATCH 3 - Repeat 1, notice the buttons disappeared 4 - Create lists so there are >10 public and >10 private lists 5 - Repeat 1, notice the buttons reappeared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177990|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178096&action=edit Bug 39124: In lists dropdown, the option "view all" is always displayed In the code of the OPAC, the "Lists" dropdown menu is supposed to display max. 10 lists and display a button "view all" if there are more than 10 lists. The button "view all" is always displayed and it is weird when there are few lists because "Public lists" and "Your lists" do the same. Test plan: 1 - On an OPAC with less than 10 public lists and 10 private lists, navigate to /cgi-bin/koha/opac-shelves.pl, click on the dropdown see there is a view all button for both types of lists 2 - APPLY PATCH 3 - Repeat 1, notice the buttons disappeared 4 - Create lists so there are >10 public and >10 private lists 5 - Repeat 1, notice the buttons reappeared Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178096|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178445&action=edit Bug 39124: In lists dropdown, the option "view all" is always displayed In the code of the OPAC, the "Lists" dropdown menu is supposed to display max. 10 lists and display a button "view all" if there are more than 10 lists. The button "view all" is always displayed and it is weird when there are few lists because "Public lists" and "Your lists" do the same. Test plan: 1 - On an OPAC with less than 10 public lists and 10 private lists, navigate to /cgi-bin/koha/opac-shelves.pl, click on the dropdown see there is a view all button for both types of lists 2 - APPLY PATCH 3 - Repeat 1, notice the buttons disappeared 4 - Create lists so there are >10 public and >10 private lists 5 - Repeat 1, notice the buttons reappeared Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |baptiste.wojtkowski@biblibr | |e.com QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39124 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org