[Bug 25041] New: Links to 'pending' #ASKED tab in suggestions.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Bug ID: 25041 Summary: Links to 'pending' #ASKED tab in suggestions.pl is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It does not take you to correct tab #ASKED anchor for tab was removed by: commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 BUg 23594 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102337&action=edit Bug 25041: Restore #ASKED anchor in suggestions table On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 Bug 23594: Batch modification for itemtypes on suggestions page The anchors of the tabs on suggestion.pl has been replaced with tab_$count instead of the status code. There was a need at the time, but I cannot remember it. I restored the previous behavior, and did not find any regressions. Test plan: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It takes you to correct tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102337|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 102402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102402&action=edit Bug 25041: Restore #ASKED anchor in suggestions table On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 Bug 23594: Batch modification for itemtypes on suggestions page The anchors of the tabs on suggestion.pl has been replaced with tab_$count instead of the status code. There was a need at the time, but I cannot remember it. I restored the previous behavior, and did not find any regressions. Test plan: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It takes you to correct tab Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102402|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 102462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102462&action=edit Bug 25041: Restore #ASKED anchor in suggestions table On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 Bug 23594: Batch modification for itemtypes on suggestions page The anchors of the tabs on suggestion.pl has been replaced with tab_$count instead of the status code. There was a need at the time, but I cannot remember it. I restored the previous behavior, and did not find any regressions. Test plan: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It takes you to correct tab Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- not needed in 19.11 and prior - not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org