[Bug 18987] New: When browsing for a patron by last name the page processes indefinitely
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Bug ID: 18987 Summary: When browsing for a patron by last name the page processes indefinitely Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: blocker Priority: P1 - high Component: Patrons Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When browsing for a patron by last name the patron result page processes indefinitely instead of displaying results. This is after browser cache has been cleared. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 65287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65287&action=edit Bug 18987 - Added Koha::Account package pragma to Patron.pm Test plan: 1. On an up to date branch go to Patrons and try to browse for a patron by last name 2. Notice that the page processes indefinately 3. Apply patch 4. Repeat step 1 5. Notice the patron results are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I've noticed other scenarios where the patron result page processes indefinitely as well (typically when an invalid JSON response is returned), but I'll save that for another day. I'll check this out now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- The patron browse is super slow... but I imagine that pre-dates the patch, so I'll sign it off in a moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65287|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 65290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65290&action=edit Bug 18987 - Added Koha::Account package pragma to Patron.pm Test plan: 1. On an up to date branch go to Patrons and try to browse for a patron by last name 2. Notice that the page processes indefinately 3. Apply patch 4. Repeat step 1 5. Notice the patron results are displayed Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thanks David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The changes make sense but I do not recreate the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17585 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I guess it has been caused by bug 17585. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 [Bug 17585] Add the Koha::Patron->account method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Check your logs. Seeing problems with rounding large numbers etc? Than maybe running a few tests created very large numbers in patron related tables. And they could be the cause of no results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Fwiw, I created a database from scratch and inserted all the sample data, and that's how I reproduced it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65290|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65307&action=edit Bug 18987 - Added Koha::Account package pragma to Patron.pm Test plan: 1. On an up to date branch go to Patrons and try to browse for a patron by last name 2. Notice that the page processes indefinately 3. Apply patch 4. Repeat step 1 5. Notice the patron results are displayed Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Did not recreate but pushed anyway. Cannot hurt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Dependency and bug are not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org