[Bug 35592] New: Missing closing div tag in bookings alert in circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Bug ID: 35592 Summary: Missing closing div tag in bookings alert in circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |29002 QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159974&action=edit Bug 35592: Fix closing tag in bookings alert To test: 1 - View a record details page for a record with items 2 - Click on the 'Items' tab 3 - Change 'Bookable' to 'Yes' and update for an item 4 - View the details page - place a booking 5 - Checkout the item to the patron it is booked for 6 - Note the alert shows, but encompasses the whole page 7 - Apply patch 8 - Check in the item 9 - Checkout the item again 10 - Note the alert shows above the checkouts page as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159974|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 159983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159983&action=edit Bug 35592: Fix closing tag in bookings alert To test: 1 - View a record details page for a record with items 2 - Click on the 'Items' tab 3 - Change 'Bookable' to 'Yes' and update for an item 4 - View the details page - place a booking 5 - Checkout the item to the patron it is booked for 6 - Note the alert shows, but encompasses the whole page 7 - Apply patch 8 - Check in the item 9 - Checkout the item again 10 - Note the alert shows above the checkouts page as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I have signed off (from reviewing the patch), but I couldn't generate the issue described in the test plan. When I go to check out an item booked, I get this alert: Please confirm checkout Patron has this item booked for checkout on 12/19/2023 Allow early collection? Yes, check out (Y) No, don't check out (N) I don't get the alert, or know how to generate the area fixed in patch, which has the message "Item is booked by this user". Also, note bug 35532 - when using the "Place booking" button on the detail page, you need to double click the date to place a booking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159983|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159995&action=edit Bug 35592: Fix closing tag in bookings alert To test: 1 - View a record details page for a record with items 2 - Click on the 'Items' tab 3 - Change 'Bookable' to 'Yes' and update for an item 4 - View the details page - place a booking 5 - Checkout the item to the patron it is booked for 6 - Note the alert shows, but encompasses the whole page 7 - Apply patch 8 - Check in the item 9 - Checkout the item again 10 - Note the alert shows above the checkouts page as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the quick patch Nick.. Passing QA. I'll take a look at your comment shortly David. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Patch complexity|--- |Trivial patch CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35592 Bug 35592 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org