[Bug 9144] New: bulkmarcimport.pl - Problem identifying errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Bug ID: 9144 Summary: bulkmarcimport.pl - Problem identifying errors Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt@gmail.com Reporter: vfernandes@keep.pt The bulkmarcimport.pl uses replace instead of changing line, which difficults the track of the errors found in the migration. Solution: replace \r to \n -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |vfernandes@keep.pt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 --- Comment #1 from Vitor Fernandes <vfernandes@keep.pt> --- Created attachment 13675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13675&action=edit BUG 9144 modified: mist/migration_tools/bulkmarcimport.pl Replaced \r to \n. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13675|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13912&action=edit Bug 9144 - bulkmarcimport.pl - Problem identifying errors Replace \r with \n for newline in output for bulkmarcimport.pl \r is the newline character for OS X, \n is the newline character for Linux. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- We use \n for newlines everywhere else in Koha, so this is a sensible change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: one letter patch, passes QA ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13912|0 |1 is obsolete| | --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 14027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14027&action=edit Bug 9144 - bulkmarcimport.pl - Problem identifying errors Replace \r with \n for newline in output for bulkmarcimport.pl \r is the newline character for OS X, \n is the newline character for Linux. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I am inclined to push this patch, since I agree with Vitor's assessment that it would probably be easier to spot errors when using \n than when using \r. However, the sign off and QA appear to be predicated on the idea that this patch increases consistency, which it does not do. In light of this, I would request that Kyle and Paul confirm whether they would like their sign off and QA (respectively) to stand. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #6)
I am inclined to push this patch, since I agree with Vitor's assessment that it would probably be easier to spot errors when using \n than when using \r. However, the sign off and QA appear to be predicated on the idea that this patch increases consistency, which it does not do. In light of this, I would request that Kyle and Paul confirm whether they would like their sign off and QA (respectively) to stand.
I stand by my SO, for ease of readability. I suppose if we want full consistency, we would need to find every \r and \n in Koha and change them to \r\n. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #6)
I am inclined to push this patch, since I agree with Vitor's assessment that it would probably be easier to spot errors when using \n than when using \r. However, the sign off and QA appear to be predicated on the idea that this patch increases consistency, which it does not do. In light of this, I would request that Kyle and Paul confirm whether they would like their sign off and QA (respectively) to stand.
Jared, I don't understand what you're saying. (ie= I don't see where I said this patch improves consistency) back to passed QA, this patch is OK for me -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. (Paul, you didn't say explicitly that you were QAing the patch with the idea that it improved consistency, but that was implied by the commit message and I wanted to make sure you wholly approved) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9144 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org