[Bug 22087] New: It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Bug ID: 22087 Summary: It would be helpful to have City and State visible in member.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jzairo@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- When a staff member searches for a patron via the search patron box or filters a search through the patron module, they get results on members-home.pl or member.pl. The column for name includes firstname, surname, address and email. It would be beneficial to also see the city and state. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 102043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102043&action=edit Bug 22087: It would be helpful to have City and State visible in member.pl This patch adds City, State and Zipcode to the display of a patron search To test: 1) Do a patron search that retrieves more than one user so you see the results table 2) In the Names column, see that the patron address display without city, state and zipcode. 3) Install the patch 4) Repeat the search. City, state and zipcode will now display in the table. 5) Check that this is working from both member.pl and members-home.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from David Roberts <david.roberts@ptfs-europe.com> --- I've also added zipcode to this display, as there seemed little point in not displaying it if we are displaying all of the other address fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102043|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 102064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102064&action=edit Bug 22087: It would be helpful to have City and State visible in member.pl This patch adds City, State and Zipcode to the display of a patron search To test: 1) Do a patron search that retrieves more than one user so you see the results table 2) In the Names column, see that the patron address display without city, state and zipcode. 3) Install the patch 4) Repeat the search. City, state and zipcode will now display in the table. 5) Check that this is working from both member.pl and members-home.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think we should follow the same pattern we have already (in circ-menu.inc) and use the member-display-address-style-* include files instead, to match the AddressFormat syspref's value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|david.roberts@ptfs-europe.c |koha-bugs@lists.koha-commun |om |ity.org --- Comment #5 from David Roberts <david.roberts@ptfs-europe.com> --- I think I'm going to have to unassign this one. I'm competent to extend the functionality that is already in use, but not to change it completely, especially on the basis of a rather cryptic suggestion. :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102064|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102448&action=edit Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102449&action=edit Bug 22087: Add space between zipcode and country -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102450&action=edit Bug 22087: Add a no_line_break parameter to prevent new lines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102451&action=edit Bug 22087: DO NOT PUSH - CSS changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25070 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Keywords|Academy | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hello David, could you test these patches? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 [Bug 25070] Include files to display address and contact must be refactored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #11 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 102466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102466&action=edit Mangled display of patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #12 from David Roberts <david.roberts@ptfs-europe.com> --- Hi, I've tested but the search results screen is mangled. Firstly, there are no spaces between the address elements. This is also true when you display a single patron. Secondly, my search returns two users, but the usernames of each have got confused (see screenshot). Also, when I go to edit one of the users, I get an error: Software error: Template process failed: file error - member-alt-contact-style-us: not found at /home/david/kohaclone/C4/Templates.pm line 122. For help, please send mail to the webmaster (webmaster@ptfs-europe.co.uk), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102448|0 |1 is obsolete| | Attachment #102449|0 |1 is obsolete| | Attachment #102450|0 |1 is obsolete| | Attachment #102451|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102482&action=edit Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102483&action=edit Bug 22087: Add space between zipcode and country -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102484&action=edit Bug 22087: Add a no_line_break parameter to prevent new lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102485&action=edit Bug 22087: DO NOT PUSH - CSS changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Roberts from comment #12)
Hi, I've tested but the search results screen is mangled. Firstly, there are no spaces between the address elements. This is also true when you display a single patron. Secondly, my search returns two users, but the usernames of each have got confused (see screenshot). Also, when I go to edit one of the users, I get an error:
Software error: Template process failed: file error - member-alt-contact-style-us: not found at /home/david/kohaclone/C4/Templates.pm line 122. For help, please send mail to the webmaster (webmaster@ptfs-europe.co.uk), giving this error message and the time and date of the error.
I fixed the software error (on bug 25070), and the space problems. I got confused by the sample data: the street number is in the address field. However I do not understand your second point, what is confusing with the usernames (ie. what are you expecting to be displayed instead)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #18 from David Roberts <david.roberts@ptfs-europe.com> --- In my example, there are two users. David Roberts (dir) and Glyn Roberts (gdr). If you look at my screenshot, both users display the name David Roberts, and the second user is showing the cardnumber dir in brackets whereas it should be gdr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #19 from David Roberts <david.roberts@ptfs-europe.com> --- I've re-tested, and the address format looks much better now. There are still problems with the username. I've added a 3rd user to my system now, and it seems like each user in the list displays the name of the previous user. See screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #20 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 102486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102486&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102492&action=edit Bug 22087: Prevent variable names colision We should not use PROCESS: http://www.template-toolkit.org/docs/manual/Directives.html " The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template. " The 'patron' variable is reused by patron-title.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Roberts from comment #19)
I've re-tested, and the address format looks much better now. There are still problems with the username. I've added a 3rd user to my system now, and it seems like each user in the list displays the name of the previous user. See screenshot.
Right, good catch! That was a very unexpected behaviour, it is fixed now. The address parts do not look correct on your screenshot, you should not see the bullets. Refresh correctly your browser cache to get the latest css version. https://snipboard.io/sALU86.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #23 from David Roberts <david.roberts@ptfs-europe.com> --- Looks much better, although I quite liked the bullets! However, the email address is out of alignment now: https://snipboard.io/pX2kli.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102505&action=edit Bug 22087: Remove padding on li's -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102506&action=edit Bug 22087: Move the email into the list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102485|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102507&action=edit Bug 22087: DO NOT PUSH - CSS changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Roberts from comment #23)
Looks much better, although I quite liked the bullets!
I wanted to keep the view as compact as before. We could see later how to improve the display.
However, the email address is out of alignment now:
Fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #28 from David Roberts <david.roberts@ptfs-europe.com> --- Looks great. Happy to sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102507|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #29)
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css
I obsoleted the patch containing compiled CSS. Instead a "yarn build" step should be added to the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, I was a little too fast here as I had to also take care of the dependency bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|It would be helpful to have |Show city and state in |City and State visible in |patron search results |member.pl | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style.inc FAIL filters missing_filter at line 48 ( [%~ IF ( patron.zipcode ) ~%][%~ patron.zipcode | html %] [% END ~%][%~ patron.city | html ~%][%~ IF ( patron.state ) ~%][% line_break %][%~ patron.state | html ~%][%~ END ~%]) missing_filter at line 49 ( [%~ IF ( patron.country ) ~%][% line_break %][%~ patron.country | html ~%][%~ END ~%]) missing_filter at line 72 ( [%~ IF ( patron.zipcode ) ~%][%~ patron.zipcode | html %] [% END ~%][%~ patron.city | html ~%][%~ IF ( patron.state ) ~%][% line_break %][%~ patron.state | html ~%][%~ END ~%]) missing_filter at line 73 ( [%~ IF ( patron.country ) ~%][% line_break %][%~ patron.country | html ~%][%~ END ~%]) 2) I'd also like to suggest a visual change. At the moment the information is shown as a list, but I think as this is address information just a line break would work better. It will allow to just easily copy the addresses for use in a letter head or similar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102482|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107420&action=edit Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102483|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107421&action=edit Bug 22087: Add space between zipcode and country -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102484|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107422&action=edit Bug 22087: Add a no_line_break parameter to prevent new lines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102492|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107423&action=edit Bug 22087: Prevent variable names colision We should not use PROCESS: http://www.template-toolkit.org/docs/manual/Directives.html " The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template. " The 'patron' variable is reused by patron-title.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102505|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107424&action=edit Bug 22087: Remove padding on li's -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102506|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107425&action=edit Bug 22087: Move the email into the list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107427&action=edit Bug 22087: Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107428&action=edit Bug 22087: Display address on different line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #32)
1) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style.inc FAIL filters missing_filter at line 48 ( [%~ IF ( patron.zipcode ) ~%][%~ patron.zipcode | html %] [% END ~%][%~ patron.city | html ~%][%~ IF ( patron.state ) ~%][% line_break %][%~ patron.state | html ~%][%~ END ~%]) missing_filter at line 49 ( [%~ IF ( patron.country ) ~%][% line_break %][%~ patron.country | html ~%][%~ END ~%]) missing_filter at line 72 ( [%~ IF ( patron.zipcode ) ~%][%~ patron.zipcode | html %] [% END ~%][%~ patron.city | html ~%][%~ IF ( patron.state ) ~%][% line_break %][%~ patron.state | html ~%][%~ END ~%]) missing_filter at line 73 ( [%~ IF ( patron.country ) ~%][% line_break %][%~ patron.country | html ~%][%~ END ~%])
Done.
2) I'd also like to suggest a visual change. At the moment the information is shown as a list, but I think as this is address information just a line break would work better. It will allow to just easily copy the addresses for use in a letter head or similar.
As I said in comment 27, "I wanted to keep the view as compact as before" I added a follow-up but I don't think it's the way to go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Display is now: https://snipboard.io/MBu8cI.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- vs without the last patch: https://snipboard.io/qEsVt4.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107420|0 |1 is obsolete| | Attachment #107428|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107543&action=edit Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107421|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107544&action=edit Bug 22087: Add space between zipcode and country Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107422|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107545&action=edit Bug 22087: Add a no_line_break parameter to prevent new lines Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107423|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107546&action=edit Bug 22087: Prevent variable names colision We should not use PROCESS: http://www.template-toolkit.org/docs/manual/Directives.html " The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template. " The 'patron' variable is reused by patron-title.inc Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107424|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107547&action=edit Bug 22087: Remove padding on li's Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107425|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107548&action=edit Bug 22087: Move the email into the list Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107427|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107549&action=edit Bug 22087: Add missing filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, you were right - the last patch was not needed. I had forgotten to do a yarn build before when testing :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #53 from Lucas Gass <lucas@bywatersolutions.com> --- skipping enhancement for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org