http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23082|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23083&action=edit Bug 11287 - Import borrowers doesn't take into account the new debarment system The import patrons tool will add restrictions in the previous style ( directly to the borrowers table ). This will actually work, but will result in the restriction being un-removable, and will be overwritten by any new restrictions. Test Plan: 1) Apply this patch 2) Import new patrons with debarrments, note the debarment is created correctly 3) Import existing patrons with overwrite enabled, note that any new debarrment is added, and any existing debarrment is ignored -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23083|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23757&action=edit Bug 11287 - Import borrowers doesn't take into account the new debarment system The import patrons tool will add restrictions in the previous style ( directly to the borrowers table ). This will actually work, but will result in the restriction being un-removable, and will be overwritten by any new restrictions. Test Plan: 1) Apply this patch 2) Import new patrons with debarrments, note the debarment is created correctly 3) Import existing patrons with overwrite enabled, note that any new debarrment is added, and any existing debarrment is ignored Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as expected, and fixes the POD too -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23757|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23788&action=edit Bug 11287 - Import borrowers doesn't take into account the new debarment system The import patrons tool will add restrictions in the previous style ( directly to the borrowers table ). This will actually work, but will result in the restriction being un-removable, and will be overwritten by any new restrictions. Test Plan: 1) Apply this patch 2) Import new patrons with debarrments, note the debarment is created correctly 3) Import existing patrons with overwrite enabled, note that any new debarrment is added, and any existing debarrment is ignored Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as expected, and fixes the POD too Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- This probably won't affect my decision to push the patch, but one thing that occurs to me: even with the patch, there is overall a regression from 3.12. Specifically, prior to the new restriction system, a patron file could be used both to set and remove debarments. One example where one might want to remove debarments via patron import: imagine an academic library that receives patron updates frequently. If the patron owes money to the university, the bursar's office might want to be able to set a debarment to suspend the patron's library privileges. Once they settle their account with the bursar, the next patron import could lift the restriction. General question: are there Koha users out there who actually do this? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Thinking aloud, I wonder of adding a borrower_debarments.type value of "PATRON_IMPORT" that could be set and removed by the patron importer is the way to go. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm I think the advantage of Galen's idea would be that the existing format would not have to be changed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Doesn't solve the whole problem, but since it's better than the status quo, I've pushed it. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.