[Bug 37204] New: Add a booking has changed notice to update a patron should a booking be updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Bug ID: 37204 Summary: Add a booking has changed notice to update a patron should a booking be updated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, koha-bugs@lists.koha-community.org, kyle.m.hall@gmail.com, testopia@bugs.koha-community.org Depends on: 29002 Blocks: 36666 Sometimes a booking may need to be tweaked, the item assigned changed or the dates shifted slightly. We need a notice to let the patron know about the change and why. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36666 [Bug 36666] Bookings needs some slips and notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 |36195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 [Bug 36195] CSRF - testing reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36195 |36915 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36195 [Bug 36195] CSRF - testing reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 [Bug 36915] Send email notification when a booking is cancelled -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170805&action=edit Bug 37204: Add a booking has changed notice to update a patron should a booking be updated This is a first draft. When reading your initial statement again I'm asking myself whether a changed itemnumber is relevant to the patron. The way I see it, the relevant fields are: - pickup_library_id - start_date - end_date But maybe I'm not seeing it. To test: 1) Apply the patch 2) Make an item bookable 3) Add a booking for a given patron 4) Check the patron notices tab, should not contain any notices 5) Change either start date, end date or pickup library and save 6) Check the patron notices tab, should contain a notice with the updated details 7) Run the tests under t/db_dependent/Koha/Booking.t 8) Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Addendum: 1.1) Run reset_all on ktd to include the new sample notice for BOOKING_MODIFICATION -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37803 [Bug 37803] Add a booking has been created notice to infrom a patron on successful creation -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170805|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 170939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170939&action=edit Bug 37204: Add a booking has changed notice to update a patron should a booking be updated This is a first draft. When reading your initial statement again I'm asking myself whether a changed itemnumber is relevant to the patron. The way I see it, the relevant fields are: - pickup_library_id - start_date - end_date But maybe I'm not seeing it. To test: 1) Apply the patch 2) Make an item bookable 3) Add a booking for a given patron 4) Check the patron notices tab, should not contain any notices 5) Change either start date, end date or pickup library and save 6) Check the patron notices tab, should contain a notice with the updated details 7) Run the tests under t/db_dependent/Koha/Booking.t 8) Sign off Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Assignee|koha-bugs@lists.koha-commun |paul.derscheid@lmscloud.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170939|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172824&action=edit Bug 37204: Add a booking has changed notice to update a patron should a booking be updated This is a first draft. When reading your initial statement again I'm asking myself whether a changed itemnumber is relevant to the patron. The way I see it, the relevant fields are: - pickup_library_id - start_date - end_date But maybe I'm not seeing it. To test: 1) Apply the patch 2) Make an item bookable 3) Add a booking for a given patron 4) Check the patron notices tab, should not contain any notices 5) Change either start date, end date or pickup library and save 6) Check the patron notices tab, should contain a notice with the updated details 7) Run the tests under t/db_dependent/Koha/Booking.t 8) Sign off Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172825&action=edit Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter Thinking about the future, some libraries may wish to use the old_booking object details in their notice so I opt to pass it into GetPreparedLetter here to support that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks Paul. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172826&action=edit Bug 37204: (QA follow-up) Consistently pick notice library We should use the notice from the library that initiated the action that triggered the notice. This should be available to us always in the userenv. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172826|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172827&action=edit Bug 37204: (QA follow-up) Consistently pick notice library We should use the notice from the library that initiated the action that triggered the notice. This should be available to us always in the userenv. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172827|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172828&action=edit Bug 37204: (QA follow-up) Consistently pick notice library We should use the notice from the library that initiated the action that triggered the notice. This should be available to us always in the userenv. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36666 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36666 [Bug 36666] Bookings needs some slips and notices -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172824|0 |1 is obsolete| | --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173283&action=edit Bug 37204: Add a booking has changed notice to update a patron should a booking be updated This is a first draft. When reading your initial statement again I'm asking myself whether a changed itemnumber is relevant to the patron. The way I see it, the relevant fields are: - pickup_library_id - start_date - end_date But maybe I'm not seeing it. To test: 1) Apply the patch 2) Make an item bookable 3) Add a booking for a given patron 4) Check the patron notices tab, should not contain any notices 5) Change either start date, end date or pickup library and save 6) Check the patron notices tab, should contain a notice with the updated details 7) Run the tests under t/db_dependent/Koha/Booking.t 8) Sign off Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172825|0 |1 is obsolete| | --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173284&action=edit Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter Thinking about the future, some libraries may wish to use the old_booking object details in their notice so I opt to pass it into GetPreparedLetter here to support that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172828|0 |1 is obsolete| | --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 173285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173285&action=edit Bug 37204: (QA follow-up) Consistently pick notice library We should use the notice from the library that initiated the action that triggered the notice. This should be available to us always in the userenv. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement introduces release notes| |a notice to inform patrons | |of changes to their | |bookings, such as updates | |to the pickup library, | |start date, or end date, | |ensuring clear | |communication regarding any | |modifications. Keywords|release-notes-needed | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This adds a new notice, so needs documenting. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38490 [Bug 38490] All bookings notices should be available in the advanced messaging preferences -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38501 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38501 [Bug 38501] Prevent failures of Koha/Booking.t when run on MySQL8 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1117 Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Bug 37204 depends on bug 36915, which changed state. Bug 36915 Summary: Send email notification when a booking is cancelled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36915 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #16 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Documented in the Manual. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38501 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38501 [Bug 38501] Prevent failures of Koha/Booking.t when running tests on an updated database -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37204 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38490 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38490 [Bug 38490] All bookings notices should be available in the advanced messaging preferences -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org