[Bug 22045] New: cataloging UX enhancement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Bug ID: 22045 Summary: cataloging UX enhancement Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- Created attachment 83473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83473&action=edit vertical displaying tabs it would be nice if on the cat_addbiblio page the ui-tabs-nav (0-9 tabs) were either fixed OR also available at the bottom of the page so catalogers don't have to scroll all the way back up to the top of the page each time they want to switch tabs. I have experimented with displaying them vertical instead of horizontal, with a position of fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe Owen was working on something similar for the cataloguing editor - adding him CC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|cataloging UX enhancement |Cataloging UX enhancement - | |Improve access to tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This is what I was playing around with: https://zivotdesign.com/p/#1/15223413373574 The section links would float along with the toolbar. There were some issues with it that I was still working out, so I'll have to rebase and take another look if it's interesting to folks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 [Bug 21751] fixFloat toolbar not displaying properly in Chrome -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83770&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- I can't apply the patch. Applying: Bug 22045: Cataloging UX enhancement - Improve access to tabs fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 22045: Cataloging UX enhancement - Improve access to tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Maryse, this bug depends on bug 21751, it needs to be applied and tested first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83770|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84728&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84728|0 |1 is obsolete| | --- Comment #7 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84896&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikael.olangcay-brisebois@i | |nLibro.com --- Comment #8 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- It's a really nice UX enhancement, only thing I would modify is the numbering. It should start from 0 instead of 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Bug 22045 depends on bug 21751, which changed state. Bug 21751 Summary: fixFloat toolbar not displaying properly in Chrome https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Mikaël Olangcay Brisebois from comment #8)
It's a really nice UX enhancement, only thing I would modify is the numbering. It should start from 0 instead of 1.
My intention was to make the number more user-friendly, since normal people don't start counting at zero. However, I didn't consider that the MARC framework editor would have to be changed at the same time, so I'll have to save that for another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84984&action=edit Bug 22045: (follow-up) Revert change to numbering of tabs I wanted the tabs to be numbered like humans count, starting from 1. But if the MARC framework setup isn't changed as well it doesn't make sense. This patch removes the change. Also fixed: Some missing template filters, an errant console.log() removed. To test, apply the patch and open a new or existing record for editing. The tabs (now "Sections") should be labeled from 0-9. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84896|0 |1 is obsolete| | Attachment #84984|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84985&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84986&action=edit Bug 22045: (follow-up) Revert change to numbering of tabs I wanted the tabs to be numbered like humans count, starting from 1. But if the MARC framework setup isn't changed as well it doesn't make sense. This patch removes the change. Also fixed: Some missing template filters, an errant console.log() removed. To test, apply the patch and open a new or existing record for editing. The tabs (now "Sections") should be labeled from 0-9. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84985|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 84993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84993&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: John Doe <you@example.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84986|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 84994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84994&action=edit Bug 22045: (follow-up) Revert change to numbering of tabs I wanted the tabs to be numbered like humans count, starting from 1. But if the MARC framework setup isn't changed as well it doesn't make sense. This patch removes the change. Also fixed: Some missing template filters, an errant console.log() removed. To test, apply the patch and open a new or existing record for editing. The tabs (now "Sections") should be labeled from 0-9. Signed-off-by: John Doe <you@example.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84993|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 84995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84995&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84994|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 84996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84996&action=edit Bug 22045: (follow-up) Revert change to numbering of tabs I wanted the tabs to be numbered like humans count, starting from 1. But if the MARC framework setup isn't changed as well it doesn't make sense. This patch removes the change. Also fixed: Some missing template filters, an errant console.log() removed. To test, apply the patch and open a new or existing record for editing. The tabs (now "Sections") should be labeled from 0-9. Signed-off-by: John Doe <you@example.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84995|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 84997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84997&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84996|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 84998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84998&action=edit Bug 22045: (follow-up) Revert change to numbering of tabs I wanted the tabs to be numbered like humans count, starting from 1. But if the MARC framework setup isn't changed as well it doesn't make sense. This patch removes the change. Also fixed: Some missing template filters, an errant console.log() removed. To test, apply the patch and open a new or existing record for editing. The tabs (now "Sections") should be labeled from 0-9. Signed-off-by: John Doe <you@example.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #19 from David Nind <david@davidnind.com> --- Apologies, I couldn't figure out how to git rid of "John Doe" for attachment 84998. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Sometimes we have frameworks with some sections empty, this UI adapts well, but I can't change the tabs on biblio with such framework. Otherwise it looks good and much cleaner the before. I like it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85567&action=edit Bug 22045: (follow-up) Fix tab-switching when some tab numbers are missing This patch changes the way tab-switching is done so that it switching tabs based on tab id rather than tab index. Using tab index doesn't work when the tab number doesn't match the tab index. To test, apply the patch and load a record or blank editor using a MARC framework which doesn't include one or more tabs (for instance, by deleting the entries in the framework for one tab: DELETE FROM marc_subfield_structure WHERE frameworkcode = 'KT' AND tab = 4; ...backup first). In the MARC editor the numbered tabs should exclude that number. Tab-switching should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84997|0 |1 is obsolete| | --- Comment #22 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 85578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85578&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: John Doe <you@example.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84998|0 |1 is obsolete| | --- Comment #23 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 85579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85579&action=edit Bug 22045: (follow-up) Revert change to numbering of tabs I wanted the tabs to be numbered like humans count, starting from 1. But if the MARC framework setup isn't changed as well it doesn't make sense. This patch removes the change. Also fixed: Some missing template filters, an errant console.log() removed. To test, apply the patch and open a new or existing record for editing. The tabs (now "Sections") should be labeled from 0-9. Signed-off-by: John Doe <you@example.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85567|0 |1 is obsolete| | --- Comment #24 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 85580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85580&action=edit Bug 22045: (follow-up) Fix tab-switching when some tab numbers are missing This patch changes the way tab-switching is done so that it switching tabs based on tab id rather than tab index. Using tab index doesn't work when the tab number doesn't match the tab index. To test, apply the patch and load a record or blank editor using a MARC framework which doesn't include one or more tabs (for instance, by deleting the entries in the framework for one tab: DELETE FROM marc_subfield_structure WHERE frameworkcode = 'KT' AND tab = 4; ...backup first). In the MARC editor the numbered tabs should exclude that number. Tab-switching should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85581&action=edit ILL cataloguing framework This is framework we are using for ILL records, it has only two tabs ;) This is the one I used to testing. But it is only in Czech -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85582&action=edit Variant of tabs - maybe future enhancement I just try this, now I generated it by adding this code to intranetuserjs: $(document).ready(function() { $(".toolbar-tabs-container a[href='#tab0XX'], #tab0XX h3").text("Control and coded fields"); $(".toolbar-tabs-container a[href='#tab1XX'], #tab1XX h3").text("Main entry"); $(".toolbar-tabs-container a[href='#tab2XX'], #tab2XX h3").text("Title and edition"); $(".toolbar-tabs-container a[href='#tab3XX'], #tab3XX h3").text("Physical description"); $(".toolbar-tabs-container a[href='#tab4XX'], #tab4XX h3").text("Series"); $(".toolbar-tabs-container a[href='#tab5XX'], #tab5XX h3").text("Notes"); $(".toolbar-tabs-container a[href='#tab6XX'], #tab6XX h3").text("Subject Access"); $(".toolbar-tabs-container a[href='#tab7XX'], #tab7XX h3").text("Added and linking entry"); $(".toolbar-tabs-container a[href='#tab8XX'], #tab8XX h3").text("Series added entry and electronic access"); $(".toolbar-tabs-container a[href='#tab9XX'], #tab9XX h3").text("Koha related"); }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85578|0 |1 is obsolete| | Attachment #85579|0 |1 is obsolete| | Attachment #85580|0 |1 is obsolete| | --- Comment #27 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85583&action=edit Bug 22045: Cataloging UX enhancement - Improve access to tabs This patch makes style changes to the standard MARC editor with the goal of both making it more responsive and making it easier to navigate among tabs and tags. Tabs are now part of the page's toolbar, which floats as the page scrolls. In addition to the numbered tabs, there is also a section showing in-page links to the MARC tags which are available on that page. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. Open a blank or existing record in the standard cataloging editor. Test the redesigned tabs, the floating toolbar, and the in-page tag links. Confirm that everything works well at various browser widths. Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> Signed-off-by: John Doe <you@example.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #28 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85584&action=edit Bug 22045: (follow-up) Revert change to numbering of tabs I wanted the tabs to be numbered like humans count, starting from 1. But if the MARC framework setup isn't changed as well it doesn't make sense. This patch removes the change. Also fixed: Some missing template filters, an errant console.log() removed. To test, apply the patch and open a new or existing record for editing. The tabs (now "Sections") should be labeled from 0-9. Signed-off-by: John Doe <you@example.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #29 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85585&action=edit Bug 22045: (follow-up) Fix tab-switching when some tab numbers are missing This patch changes the way tab-switching is done so that it switching tabs based on tab id rather than tab index. Using tab index doesn't work when the tab number doesn't match the tab index. To test, apply the patch and load a record or blank editor using a MARC framework which doesn't include one or more tabs (for instance, by deleting the entries in the framework for one tab: DELETE FROM marc_subfield_structure WHERE frameworkcode = 'KT' AND tab = 4; ...backup first). In the MARC editor the numbered tabs should exclude that number. Tab-switching should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Josef Moravec from comment #26)
I just try this, now I generated it by adding this code to intranetuserjs:
$(document).ready(function() { $(".toolbar-tabs-container a[href='#tab0XX'], #tab0XX h3").text("Control and coded fields"); ....
It would be nice to be able to add these custom labels directly in the MARC framework configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #30)
(In reply to Josef Moravec from comment #26)
I just try this, now I generated it by adding this code to intranetuserjs:
$(document).ready(function() { $(".toolbar-tabs-container a[href='#tab0XX'], #tab0XX h3").text("Control and coded fields"); ....
It would be nice to be able to add these custom labels directly in the MARC framework configuration.
That is what I have in mind... ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 [Bug 22582] Authority plugin link broken by Bug 22045 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22582 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 [Bug 22582] Authority plugin link broken by Bug 22399 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |dpavlin@rot13.org Resolution|FIXED |--- --- Comment #34 from Dobrica Pavlinusic <dpavlin@rot13.org> --- This bug broke keyboard shortcuts because of following change: --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -31,7 +31,7 @@ $.fn.tabIndex = function () { return $(this).parent().children('div').index(this); }; $.fn.selectTabByID = function (tabID) { - $(this).tabs("option", "active", $(tabID).tabIndex()); + $(this).tabs("option", "active", $( "#" + tabID ).tabIndex()); }; $(document).ready(function() { without modification to calling which also prefix tabID with #, thus creating invalid ##tabID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 [Bug 22768] Basic MARC editor tab keyboard navigation broekn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22980 [Bug 22980] Unwanted console.log in simple MARC editor template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes release notes| |style changes to the | |standard MARC editor with | |the goal of making it more | |responsive and easier to | |navigate among tabs and | |tags. | | | |Tabs are now part of | |the page toolbar, which | |floats as the page scrolls. | |In addition to the numbered | |tabs, there is also a | |section showing in-page | |links to the MARC tags | |which are available on that | |page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Changing the status of this to reflect that it has been pushed to master and won't be backported. Bug 22768 will address Comment 34. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca --- Comment #36 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- *** Bug 17148 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24415 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415 [Bug 24415] Authority enhancement - Improve access to tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26623 [Bug 26623] MARC field links can take up too much space -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org