[Bug 34920] New: ERM breaks if an ERM authorized value is missing a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Bug ID: 34920 Summary: ERM breaks if an ERM authorized value is missing a description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: Laura.escamilla@bywatersolutions.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com To recreate: 1. Enable ERM module 2. Confirm that you can open the ERM module in the staff interface. 3. Go to the authorized values, select "ERM_AGREEMENT_CLOSURE_REASON" and edit the "Cancelled" authorized value by removing the description. Making this change with any of the ERM authorized values will result in an error. 4. Go back to the ERM module and notice that there is an error. "Something went wrong: Error: Expected string - got null." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Description is a required property on the API so either we need to set it as unrequired and allow it to be NULL, or we need to put a mechanism in place to prevent a description being deleted in the admin area so that no AV can have a NULL description Not sure what the best approach is here but it feels like we shouldn't be allowing NULL descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I don't think this is specific to ERM. This will affect any module using the authorised_values REST endpoint (Preservation module now also uses this same REST endpoint). This is to_api_mapping from Koha/AuthorisedValue.pm: id => 'authorised_value_id', category => 'category_name', authorised_value => 'value', lib => 'description', lib_opac => 'opac_description', imageurl => 'image_url', I think in other places in Koha we default to using authorised_value ("value" attribute in API) if lib ("description" in API) is falsy (null or empty). Although I agree with Matt that we shouldn't allow for NULL descriptions, the least we can do for now is prevent a staff user from possibly breaking usage of a module through allowed configuration options (in this case, editing an authorised value as described by Laura). On top of that, allowing the description to be null in the API will at least make it consistent with the database schema. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162036&action=edit Bug 34920: Make av description nullable in API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162037&action=edit Bug 34920: Default to using av.value is av.description is falsy Test plan: 1. Enable ERM module 2. Confirm that you can open the ERM module in the staff interface. 3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit the 'Cancelled' authorized value by removing the description. Making this change with any of the ERM authorized values will result in an error. 4. Go back to the ERM module and notice that there is an error. 'Something went wrong: Error: Expected string - got null.' 5. Apply patch. Run yarn js:build. Repeat test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162036|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162120&action=edit Bug 34920: Make av description nullable in API spec Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162037|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162121&action=edit Bug 34920: Default to using av.value is av.description is falsy Test plan: 1. Enable ERM module 2. Confirm that you can open the ERM module in the staff interface. 3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit the 'Cancelled' authorized value by removing the description. Making this change with any of the ERM authorized values will result in an error. 4. Go back to the ERM module and notice that there is an error. 'Something went wrong: Error: Expected string - got null.' 5. Apply patch. Run yarn js:build. Repeat test plan Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I agree with this approach and am as such signing off.. all works nicely in testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 [Bug 17390] Add REST API endpoint for Authorised Values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think there are several wrong things here. 1. Missing a cypress test 2. Missing a test to cover the REST API spec change 3. Do you really want this logic in the low level api-client fetch? What if you want to display a form to edit the AV? You will display the value in the description, which does not reflect the correct values 4. The dropdown list has an empty entry: https://snipboard.io/cAhiq0.jpg I am not sure what's best here. Maybe we need a fallback at higher level (in the template)? But that will need to be done in several places. For discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162600&action=edit Bug 34920: (QA follow-up): Return sorted av_cats to be able to test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162601&action=edit Bug 34920: (QA follow-up): Add API endpoint tests prove koha/t/db_dependent/api/v1/authorised_values.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- After further discussions it seems that we do not fallback to the code in other part of Koha. We just display an empty string if the description is not present. This seems wrong and not needed, we should require a description but that's for another bug report (add NOT NULL constraint at DB level). For now we could simply return an empty string if the value is NULL, and not change the REST API specs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36203 [Bug 36203] Authorised value's descriptions should not be NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@gmail.com Assignee|jonathan.druart@gmail.com |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162120|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162600|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162604&action=edit Bug 34920: Return sorted av_cats to be able to test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162605&action=edit Bug 34920: Add API endpoint tests prove koha/t/db_dependent/api/v1/authorised_values.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162608&action=edit Bug 34920: Ensure 'description' property is an empty string if 'lib' is null Test plan: 1. Enable ERM module 2. Confirm that you can open the ERM module in the staff interface. 3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit the 'Cancelled' authorized value by removing the description. Making this change with any of the ERM authorized values will result in an error. 4. Go back to the ERM module and notice that there is an error. 'Something went wrong: Error: Expected string - got null.' 5. Apply patch. Run yarn js:build. Repeat test plan 6. Create a new agreement. Pick status 'Closed'. 7. Open 'Closure reason'. Confirm there is an entry for 'Expired' and an empty entry below that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I'm unable to attach the following patch: https://github.com/PTFS-Europe/koha/commit/9d1047e1eb3e604868602a60ffd2cd04e... Error: 413 Request Entity Too Large -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162609&action=edit Bug 34920: Add cypress tests Run the agreements cypress test spec: cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162604|0 |1 is obsolete| | --- Comment #17 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163628&action=edit Bug 34920: Return sorted av_cats to be able to test Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162605|0 |1 is obsolete| | --- Comment #18 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163629&action=edit Bug 34920: Add API endpoint tests prove koha/t/db_dependent/api/v1/authorised_values.t Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162608|0 |1 is obsolete| | --- Comment #19 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163630&action=edit Bug 34920: Ensure 'description' property is an empty string if 'lib' is null Test plan: 1. Enable ERM module 2. Confirm that you can open the ERM module in the staff interface. 3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit the 'Cancelled' authorized value by removing the description. Making this change with any of the ERM authorized values will result in an error. 4. Go back to the ERM module and notice that there is an error. 'Something went wrong: Error: Expected string - got null.' 5. Apply patch. Run yarn js:build. Repeat test plan 6. Create a new agreement. Pick status 'Closed'. 7. Open 'Closure reason'. Confirm there is an entry for 'Expired' and an empty entry below that. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162609|0 |1 is obsolete| | --- Comment #20 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163631&action=edit Bug 34920: Add cypress tests Run the agreements cypress test spec: cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Shouldnt this be a bugfix ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #21)
Shouldnt this be a bugfix ?
Yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163628|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168257&action=edit Bug 34920: Return sorted av_cats to be able to test Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163629|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168258&action=edit Bug 34920: Add API endpoint tests prove koha/t/db_dependent/api/v1/authorised_values.t Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163630|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168259&action=edit Bug 34920: Ensure 'description' property is an empty string if 'lib' is null Test plan: 1. Enable ERM module 2. Confirm that you can open the ERM module in the staff interface. 3. Go to the authorized values, select 'ERM_AGREEMENT_CLOSURE_REASON' and edit the 'Cancelled' authorized value by removing the description. Making this change with any of the ERM authorized values will result in an error. 4. Go back to the ERM module and notice that there is an error. 'Something went wrong: Error: Expected string - got null.' 5. Apply patch. Run yarn js:build. Repeat test plan 6. Create a new agreement. Pick status 'Closed'. 7. Open 'Closure reason'. Confirm there is an entry for 'Expired' and an empty entry below that. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163631|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168260&action=edit Bug 34920: Add cypress tests Run the agreements cypress test spec: cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All very sensible, covered by tests and working as described. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 "Add cypress tests" does not apply, I skip. Provide a rebased patch if possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175441&action=edit Bug 34920: [23.11.x] Add cypress tests Run the agreements cypress test spec: cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #32 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks a lot Pedro "Add cypress tests" pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED CC| |jesse@bywatersolutions.com --- Comment #33 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34920 --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jesse Maseto from comment #33)
Not pushed to LTS. Marked Resolved.
If you feel this should be in LTS please reply with your reason.
Should definitely be considered for backport if the issue described in the test plan is still happening in 23.05.x as this is a bug fix. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org