https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |In Discussion CC| |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Removing it is easy and I understand the argument. But we could discuss if the statement "koha-misc4dev must be used instead" has full consensus. How do we make sure that it is in sync and that it meets our coding guidelines etc? It is easier to grep one git repo than two? The reason for putting it outside Koha probably relates to the tedious process of getting things signed off and pushed in Koha mainstream. Somehow we do not manage as community to get that more smoothly. But I still think we should address that and not just move code somewhere else. As an alternative approach, should we copy this script (or even more) at release time into the codebase? Formulate some procedure to sync them? Any opinions? @Katrin: could you include this in the weekly QA mail? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #3)

Removing it is easy and I understand the argument. But we could discuss if the statement "koha-misc4dev must be used instead" has full consensus.

Maybe a bit of history was needed. I submitted koha:populate_db.pl to have an handy script, but then realized that our process (SO+QA+push) was too slow to get things pushed quickly. So I created misc4dev and copied the script there, along with a lot of other stuffs for Koha devs. The things is that koha-misc4dev is now used by the sandbox and jenkins (koha-testing-docker), and so we need a super fast reactivity when something is broken there, and we now it's broken as the CI is failing in that case. I am the one who usually fix it https://gitlab.com/koha-community/koha-misc4dev/commits/master Most of the time the change is minor and trivial.

How do we make sure that it is in sync and that it meets our coding guidelines etc? It is easier to grep one git repo than two?

Those scripts cannot be part of Koha, as I said previously we need a fast push and cannot wait for review. I ask for review when I am adding new enhancements (and in that cases it usually takes several weeks).

The reason for putting it outside Koha probably relates to the tedious process of getting things signed off and pushed in Koha mainstream. Somehow we do not manage as community to get that more smoothly. But I still think we should address that and not just move code somewhere else.

How? :)

As an alternative approach, should we copy this script (or even more) at release time into the codebase? Formulate some procedure to sync them?

Nope, the script will be broken during the release cycle, and so the script will become obsolete. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It really is a Dev only script so I feel it indeed belongs in its own place. Happy for it to be removed from Koha's core repo. I think the Dev tools do get enough exposure living in misc4dev -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97238|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 97705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97705&action=edit Bug 24397: Remove out of sync script populate_db.pl populate_db.pl from koha-misc4dev must be used instead. This script existed before the creation of koha-misc4dev, it does no longer make sense to have it in Koha. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.