[Bug 32172] New: Random biblionumber passed when clicking 'Z3950 SRU/Search' from the search results in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 Bug ID: 32172 Summary: Random biblionumber passed when clicking 'Z3950 SRU/Search' from the search results in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The code for Z3950 popup: 393 /* this function open a popup to search on z3950 server. */ 394 function PopupZ3950() { 395 if( strQuery ){ 396 window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=" + biblionumber + strQuery,"z3950sear ch",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); 397 } 398 } 399 Picks a random biblionumber variable Seems to get defined when images are enabled, presumably from verify_cover_images We shouldn't ever be replacing a biblio from the results page, so lets just remove it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143728&action=edit Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 LeeAnn Nilsson <lnilsson@lewistonschools.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lnilsson@lewistonschools.ne | |t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 LeeAnn Nilsson <lnilsson@lewistonschools.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lnilsson@lewistonschools.ne | |t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143728|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143739&action=edit Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143739|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143951&action=edit Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker@gmail.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22548 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org