[Bug 29524] New: cannot set a new value for privacy_guarantor_checkouts in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Bug ID: 29524 Summary: cannot set a new value for privacy_guarantor_checkouts in memberentry.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: -Set AllowStaffToSetCheckoutsVisibilityForGuarantor to allow. -Look at what the value for privacy_guarantor_checkouts is in the database. -Find a juvenile patron and try to set the value of privacy_guarantor_checkouts opposite of what is in the DB, you cannot. The value stays that same whether you choose yes or no. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Depends on| |28935 CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused by commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28935 [Bug 28935] No filtering on patron's data on member entry pages (OPAC, self registration, staff interface) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127928&action=edit Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127928|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127931&action=edit Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127931|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 127935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127935&action=edit Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|cannot set a new value for |Cannot set a new value for |privacy_guarantor_checkouts |privacy_guarantor_checkouts |in memberentry.pl |in memberentry.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05,20.11.12 |21.11.00,21.05.05,20.11.12, released in| |20.05.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|21.11.00,21.05.05,20.11.12, |21.11.00,21.05.05,20.11.12, released in|20.05.18 |20.05.18,19.11.24 --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Backported: Pushed to 19.11.x branch for 19.11.24 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 29250 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29524 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org