https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152123&action=edit Bug 33909: Improve translation of title tags: Administration This patch updates administration templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following Administration pages have the correct title tags: - Libraries - Library groups - Item types - Authorized values - Patron categories - Circulation and fines rules - Patron attribute types - Library transfer limits - Library transfer limits advanced editor - Transport cost matrix - Item circulation alerts - Cities and towns - Curbside pickup - Patron restriction types - Debit types - Credit types - Cash registers - Manage plugins - Manage jobs - MARC bibliographic framework - Koha to MARC mapping - MARC Bibliographic framework test - Authority types - Classification configuration - Record matching rules - Record overlay rules - OAI sets configuration - Item search fields - Search engine configuration - Currencies and exchange rates - Budgets - Funds - EDI accounts - Library EANs - Network Printers - Identity providers - Z39.50/SRU servers - SMTP servers - Did you mean? - Table settings - Audio alerts - Share your usage statistics - Share content with Mana KB - Additional fields - Keyboard shortcuts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm just putting what I checked here. I wrote OK if I was able to confirm it was the same as before. I put a lot of comments too about consistency. Since this bug requires that we look at each page individually one after the other, it's easier to spot inconsistencies. I realize this is outside of the scope of this bug, but if the comment is not deemed too nit-picky, I can open a new bug report to fix it. OK Libraries OK New library - It was there before, but I wonder why the branchcode is there... If it's a new library, it won't have a branchcode yet? Unless I misunderstand what that line does OK Modify library - I wonder if we should have the name or branchcode of the library? OK Delete library confirmation OK Library groups OK Item types OK Add item type - All the other admin pages are titled 'New something' rather than 'Add something' OK Modify item type OK Delete item type confirmation - Phrased as a question rather than the more ubiquitous "Confirm deletion of ..." - Data deleted - I'm unable to get to this page, when I delete an item type, it brings me back to the main item types page... is it only when you delete the last one? OK Authorized values OK Authorized values in category - Same as main authorized values page, was like this before too. Should the title show what category we're in? OK New category OK New authorized value in category OK Modify authorized value - There is no delete confirmation page when deleting a category or authorized value, only a browser prompt. OK Patron categories OK New category OK Modify category OK Cannot delete category - Same as before, but the format is not the same, there is a colon OK Confirm deletion of category OK Circulation and fines rules OK Patron attribute types OK Add patron attribute type - Add vs New (see above) OK Modify patron attribute type - Should we add the code to this? OK Confirm deletion of patron attribute type OK Library transfer limits - It was like this before, but is it normal that the title, header and breadcrumb do not match the admin page and menu link? OK Library transfer limits advanced editor - Same as above, the title header and breadcrumb do not match the admin page and menu links OK Transport cost matrix - Header is inconsistent with other pages (Defining... rather than just the noun) OK Item circulation alerts OK Cities and towns OK New city OK Modify city - Should we add the code/city name? OK Confirm deletion of city - Should we add the code/city name? OK Curbside pickup OK Patron restriction types OK New restriction type OK Modify restriction type OK Confirm deletion of restriction type OK Debit types OK New debit type OK Modify debit type - Should we add the code? OK Credit types OK New credit type OK Modify credit type - Should we add the code? OK Cash registers OK New cash register - The header of the page is Add new cash register, rather than simply New cash register OK Modify cash register - Confirm deletion of cash register - I was not able to access this page. I am only able to archive cash registers, I don't see how to delete them. - Manage plugins - It's the same as before, but I don't see this page being changed in this patch. OK Manage jobs OK Details of job OK MARC bibliographic framework OK Add framework - Add vs New (see above) OK Modify framework OK Delete framework - Phrased as a question rather than the more ubiquitous "Confirm deletion of ..." OK Add tag - Add vs New (although I think it works in this case because you're adding *to* the framework?) - I'm not sure why there is a placeholder for "searchfield" here... if it's new, it shouldn't exist yet... Unless I misunderstand the use of this line. OK Modify tag OK Confirm deletion of tag OK Data deleted (after deleting tag) OK View subfields (MARC subfield structure) OK Edit subfields (Edit MARC subfield constraints) - Edit vs Modify (see bug 28184) OK Confirm deletion of subfield OK Koha to MARC mapping OK MARC Bibliographic framework test - The title and breadcrumb of this page are not consistent with other admin pages... OK Authority types OK New authority type - The heading is really big on this page, and also inside the white area rather than above OK Modify authority type - The heading is really big on this page, and also inside the white area rather than above OK Confirm deletion of authority type - Should we add the code? OK Authority MARC framework (Viewing a framework) - Should we add the code? OK New tag + New tag Default framework OK Modify tag + Modify tag Default framework - Should we add the tag number? OK Confirm deletion of tag - Should we add the tag number? OK Authority MARC subfield structure (Viewing subfields of a tag) - Should we add the tag number? - No special title for editing subfields - No special title for deleting subfields I didn't have time to finish, but I'll try again next week... Left to check: - Classification configuration - Record matching rules - Record overlay rules - OAI sets configuration - Item search fields - Search engine configuration - Currencies and exchange rates - Budgets - Funds - EDI accounts - Library EANs - Network Printers - Identity providers - Z39.50/SRU servers - SMTP servers - Did you mean? - Table settings - Audio alerts - Share your usage statistics - Share content with Mana KB - Additional fields - Keyboard shortcuts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I decided to go ahead and create bugs for the inconsistencies. That way, it's easier to see what needs to be corrected on this patch. I'm only checking if it is the same as before. OK Classification configuration OK Add classification source OK Modify classification source OK Add filing rule OK Modify filing rule OK Add splitting rule OK Modify splitting rule OK Record matching rules OK Add record matching rule OK Modify record matching rule OK Confirm deletion of record matching rule OK Record overlay rules OK OAI sets configuration OK Add a new OAI set OK Mappings OK Item search fields OK Search filters OK Search engine configuration - Currencies and exchange rates - There is an extra > in the title of this page ( > Currencies > Currencies and exchange rates > etc.) - New currency - There is an extra > in the title of this page (New currency >> Currencies and exchange rates > etc.) - Modify currency - There is an extra > in the title of this page (Modify currency 'Y' >> Currencies and exchange rates > etc.) - Confirm deletion of currency - There is an extra > in the title of this page (> Confirm deletion of currency 'Y' > Currencies and exchange rates > etc.) OK Budgets OK Add budget OK Modify budget OK Duplicate budget OK Close budget OK Delete budget - Data deleted - I was not able to access this page, I'm not sure how to. When I delete a budget it brings me back to the list of budgets. Maybe it's just when you delete the last one? OK Funds OK Add fund OK Modify fund - Plan by months - space missing between budget name and planning type OK EDI accounts OK Add account OK Modify account OK Confirm deletion of account OK Library EANs OK Add new library EAN OK Modify library EAN OK Confirm deletion of EAN - Network Printers - I don't have this option, not sure how to have it appear OK Identity providers OK New identity provider OK Edit identity provider OK Domains OK New email domain OK Edit identity provider domain OK Z39.50/SRU servers OK New Z39.50 server - Modify Z39.50 server used to have the code OK New SRU server - Modify SRU server used to have the code OK SMTP servers OK New SMTP server OK Edit SMTP sever OK Did you mean? OK Table settings OK Audio alerts OK Share your usage statistics OK Share content with Mana KB OK Additional fields OK Add additional field OK Modify field OK Keyboard shortcuts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153901&action=edit Bug 33909: (follow-up) QA fixes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> ---

- Page aqcontract was modified. It is in the /admin/ directory, but it's for acquisitions... is it misplaced?

OK Contracts OK New contract - Modify contract : there used to be single quotes around the contract name OK Confirm deletion ? Data recorded : I don't understand how to get to this page ? Contract deleted : I don't understand how to get to this page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Testing translations * Translations for titles are now in xx-XX-messages.po * %s have been replaced by {thing}. We'll have to inform translators not to translate what is between the curly brackets. However, I like knowing what it replaces. Most of the time, it was more or less obvious, but now it will be clear what it is, if it's a name, an ID, a code, etc. * My only negative comment would be that the strings go to messages.po and so, they are not together with the breadcrumbs and headers which are usually the same text. So we have to translate the strings basically twice (once in staff-prog.po and once in messages.po). It's not the end of the world, but it opens the door to errors and since most are already translated, it would be great if the translated strings could be reused (see below). * Other comment (OK I had two negative comments!), is that most of those strings are already translated (at least in French, and probably in all languages that are decently advanced in translating like German, Spanish, Portuguese, etc.) and this patch means that we have to translate them all over again. It's not that many in itself, but it adds up with all the rest. Mind, we already did it with breadcrumbs in 22.05 (I think?), so it's doable. I did not translate everything to test, I did maybe 10-15 pages on the lot and it works well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153057|0 |1 is obsolete| | --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 154003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154003&action=edit Bug 33909: Improve translation of title tags: Administration This patch updates administration templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following Administration pages have the correct title tags: - Libraries - Library groups - Item types - Authorized values - Patron categories - Circulation and fines rules - Patron attribute types - Library transfer limits - Library transfer limits advanced editor - Transport cost matrix - Item circulation alerts - Cities and towns - Curbside pickup - Patron restriction types - Debit types - Credit types - Cash registers - Manage plugins - Manage jobs - MARC bibliographic framework - Koha to MARC mapping - MARC Bibliographic framework test - Authority types - Classification configuration - Record matching rules - Record overlay rules - OAI sets configuration - Item search fields - Search engine configuration - Currencies and exchange rates - Budgets - Funds - EDI accounts - Library EANs - Network Printers - Identity providers - Z39.50/SRU servers - SMTP servers - Did you mean? - Table settings - Audio alerts - Share your usage statistics - Share content with Mana KB - Additional fields - Keyboard shortcuts Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154003|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154116&action=edit Bug 33909: Improve translation of title tags: Administration This patch updates administration templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following Administration pages have the correct title tags: - Libraries - Library groups - Item types - Authorized values - Patron categories - Circulation and fines rules - Patron attribute types - Library transfer limits - Library transfer limits advanced editor - Transport cost matrix - Item circulation alerts - Cities and towns - Curbside pickup - Patron restriction types - Debit types - Credit types - Cash registers - Manage plugins - Manage jobs - MARC bibliographic framework - Koha to MARC mapping - MARC Bibliographic framework test - Authority types - Classification configuration - Record matching rules - Record overlay rules - OAI sets configuration - Item search fields - Search engine configuration - Currencies and exchange rates - Budgets - Funds - EDI accounts - Library EANs - Network Printers - Identity providers - Z39.50/SRU servers - SMTP servers - Did you mean? - Table settings - Audio alerts - Share your usage statistics - Share content with Mana KB - Additional fields - Keyboard shortcuts Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- I propose to not backport to stable to avoid to much translation work -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34408 [Bug 34408] Inconsistencies in SMTP servers page titles, breadcrumbs, and header -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34382 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34382 [Bug 34382] Inconsistencies in Patron categories page titles, breadcrumbs, and header -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34381 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34381 [Bug 34381] Inconsistencies in Authorized values page title -- You are receiving this mail because: You are watching all bug changes.