[Bug 37911] New: Prototype vue islands within static pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Bug ID: 37911 Summary: Prototype vue islands within static pages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org This bug is just for easy sharing of some ideas for reactive islands in static pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37824 [Bug 37824] Replace webpack with rspack for fun and profit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171425&action=edit Bug 37911: Prototype vue islands within static pages This is pretty bare bones, but might still be interesting to take a look at. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171426&action=edit Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171432&action=edit Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead - This would require us to update vue to a new minor version. - We could then use the defineCustomElement function with the shadowRoot option set to false (this is important). - The current implementation in islands.ts is naive and would result in an intolerable bundle size. - The right way to do code splitting here is to use dynamic imports. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Vue ^3.5.x provides the perfect way to do this! Was too tired to get the dynamic imports right, but if you apply all three patches you'll see what magic could await us :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171439&action=edit Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- This looks great! I think the vue upgrade should 100% be done. When I tried this a while ago the shadowRoot option was exactly what I was missing - couldn't get any core CSS classes to work in the components Code splitting seems to work fine, I can see separate bundles for multiple islands (I created some extras to test). Its a shame there doesn't seem to be a `defineAsyncCustomElement` method so that we aren't loading all the bundles on each page even if we aren't using some of the islands -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Thanks for testing it Matt! There are some problems currently: - We need to define a way to provide the dependencies for the preexisting shared components (maybe you'd like to experiment on that one). - As you pointed out, we need to lazy load what's needed (currently on that one). - The chunk names are annoying (patch incoming). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171440&action=edit Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171445&action=edit Bug 37911: (follow-up) Scan for requested components in caller and lazy load This should ensure that we only load what's requested. Maybe we can also find a way to call the exported hydrate function on demand. To test: 1) Apply the patch 2) Run yarn js:watch and wait for the first build if necessary 3) Load mainpage.pl and note that only hello-islands.ts is imported. 4) Uncomment <hello-world></hello-world> in intranet-main.tt 5) Reload the page 6) Note that now both component chunks are imported on demand 7) Discuss -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Typo, should say hello-islands.js, not .ts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171459&action=edit Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171517&action=edit Bug 37911: (follow-up) Enable usage of dependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |pedro.amorim@ptfs-europe.co | |m, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171538&action=edit Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback - Additionally: - Use a type instead of an interface. - Add JSDoc to it. - Use optional chaining when checking for existence and length of config. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37939 [Bug 37939] Replace alert messages with toasts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171459|0 |1 is obsolete| | --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171608&action=edit Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171685&action=edit Bug 37911: (follow-up) Allow for initialisation of islands on demand - Split the rspack config into a umd and an esm section. - Don't hydrate by default. - Instead check the "init" attribute for the currentScript when using the umd. - Allow for manual import and call when using the esm. - Add examples for both in intranet-main.tt (to be removed). - Add a DialogIsland wrapper for the shared Dialog component (to map props to stored refs). - Move DialogIsland as well as Demo components into an Islands directory under components. - Add i18n initialisation to hydrate's idle callback. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172962&action=edit Bug 37911: (follow-up) Remove example islands for core submission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172962|0 |1 is obsolete| | --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 172963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172963&action=edit Bug 37911: (follow-up) Remove example islands for core submission Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171425|0 |1 is obsolete| | --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172965&action=edit Bug 37911: Prototype vue islands within static pages This is pretty bare bones, but might still be interesting to take a look at. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171426|0 |1 is obsolete| | --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172966&action=edit Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171432|0 |1 is obsolete| | --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172967&action=edit Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead - This would require us to update vue to a new minor version. - We could then use the defineCustomElement function with the shadowRoot option set to false (this is important). - The current implementation in islands.ts is naive and would result in an intolerable bundle size. - The right way to do code splitting here is to use dynamic imports. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171439|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172968&action=edit Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171440|0 |1 is obsolete| | --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172969&action=edit Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171445|0 |1 is obsolete| | --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172970&action=edit Bug 37911: (follow-up) Scan for requested components in caller and lazy load This should ensure that we only load what's requested. Maybe we can also find a way to call the exported hydrate function on demand. To test: 1) Apply the patch 2) Run yarn js:watch and wait for the first build if necessary 3) Load mainpage.pl and note that only hello-islands.ts is imported. 4) Uncomment <hello-world></hello-world> in intranet-main.tt 5) Reload the page 6) Note that now both component chunks are imported on demand 7) Discuss Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171517|0 |1 is obsolete| | --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172971&action=edit Bug 37911: (follow-up) Enable usage of dependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171538|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172972&action=edit Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback - Additionally: - Use a type instead of an interface. - Add JSDoc to it. - Use optional chaining when checking for existence and length of config. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171608|0 |1 is obsolete| | --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172973&action=edit Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171685|0 |1 is obsolete| | --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172974&action=edit Bug 37911: (follow-up) Allow for initialisation of islands on demand - Split the rspack config into a umd and an esm section. - Don't hydrate by default. - Instead check the "init" attribute for the currentScript when using the umd. - Allow for manual import and call when using the esm. - Add examples for both in intranet-main.tt (to be removed). - Add a DialogIsland wrapper for the shared Dialog component (to map props to stored refs). - Move DialogIsland as well as Demo components into an Islands directory under components. - Add i18n initialisation to hydrate's idle callback. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172963|0 |1 is obsolete| | --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 172975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172975&action=edit Bug 37911: (follow-up) Remove example islands for core submission Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Are you/we going to use it? I don't think we should include it if there are no follow-up plans. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #30 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I have a prototype in bug 38010 - it allows the acquisitions left menu to be migrated to Vue and used in a Vue app as well as in template files where required -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #31 from David Cook <dcook@prosentient.com.au> --- Applying: Bug 37911: Prototype vue islands within static pages Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt M rspack.config.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 37911: Prototype vue islands within static pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #32 from David Cook <dcook@prosentient.com.au> --- I'm trying to fix as I go, but I keep getting more and more conflicts. Please rebase and squash where possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #29)
Are you/we going to use it? I don't think we should include it if there are no follow-up plans.
It's too difficult to review using Splinter Review and I can't apply the patches, so I can't say for sure yet....but for a long time I've been asking us to bundle the Vue.js differently, so that we can use Vue.js for embedded web components to embed Vue components throughout other parts of Koha and in Koha plugins. I'd love for everyone to be across the Vue.js work, and for us to start moving ahead further with it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 [Bug 38941] Convert the acquisitions menu to a Vue island -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172965|0 |1 is obsolete| | --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176959&action=edit Bug 37911: Prototype vue islands within static pages This is pretty bare bones, but might still be interesting to take a look at. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172966|0 |1 is obsolete| | --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176960&action=edit Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172967|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176961&action=edit Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead - This would require us to update vue to a new minor version. - We could then use the defineCustomElement function with the shadowRoot option set to false (this is important). - The current implementation in islands.ts is naive and would result in an intolerable bundle size. - The right way to do code splitting here is to use dynamic imports. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172968|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176962&action=edit Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172969|0 |1 is obsolete| | --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176963&action=edit Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172970|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176964&action=edit Bug 37911: (follow-up) Scan for requested components in caller and lazy load This should ensure that we only load what's requested. Maybe we can also find a way to call the exported hydrate function on demand. To test: 1) Apply the patch 2) Run yarn js:watch and wait for the first build if necessary 3) Load mainpage.pl and note that only hello-islands.ts is imported. 4) Uncomment <hello-world></hello-world> in intranet-main.tt 5) Reload the page 6) Note that now both component chunks are imported on demand 7) Discuss Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172971|0 |1 is obsolete| | --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176965&action=edit Bug 37911: (follow-up) Enable usage of dependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172972|0 |1 is obsolete| | --- Comment #41 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176966&action=edit Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback - Additionally: - Use a type instead of an interface. - Add JSDoc to it. - Use optional chaining when checking for existence and length of config. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172973|0 |1 is obsolete| | --- Comment #42 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176967&action=edit Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172974|0 |1 is obsolete| | --- Comment #43 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176968&action=edit Bug 37911: (follow-up) Allow for initialisation of islands on demand - Split the rspack config into a umd and an esm section. - Don't hydrate by default. - Instead check the "init" attribute for the currentScript when using the umd. - Allow for manual import and call when using the esm. - Add examples for both in intranet-main.tt (to be removed). - Add a DialogIsland wrapper for the shared Dialog component (to map props to stored refs). - Move DialogIsland as well as Demo components into an Islands directory under components. - Add i18n initialisation to hydrate's idle callback. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172975|0 |1 is obsolete| | --- Comment #44 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176969&action=edit Bug 37911: (follow-up) Remove example islands for core submission Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #45 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176970&action=edit Bug 37911: (follow-up) Isolate yarn.lock changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #46 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Looks like the yarn.lock file was causing conflicts due to version changes since this was uploaded. I've isolated it into its own commit to make rebasing easier and allow the RM to decide whether to push that commit or drop it and generate a fresh lock file at the time of pushing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176970|0 |1 is obsolete| | --- Comment #47 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 176972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176972&action=edit Bug 37911: (follow-up) Isolate yarn.lock changes Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176959|0 |1 is obsolete| | --- Comment #48 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178256&action=edit Bug 37911: Prototype vue islands within static pages This is pretty bare bones, but might still be interesting to take a look at. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176960|0 |1 is obsolete| | --- Comment #49 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178257&action=edit Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176961|0 |1 is obsolete| | --- Comment #50 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178258&action=edit Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead - This would require us to update vue to a new minor version. - We could then use the defineCustomElement function with the shadowRoot option set to false (this is important). - The current implementation in islands.ts is naive and would result in an intolerable bundle size. - The right way to do code splitting here is to use dynamic imports. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176962|0 |1 is obsolete| | --- Comment #51 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178259&action=edit Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176963|0 |1 is obsolete| | --- Comment #52 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178260&action=edit Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176964|0 |1 is obsolete| | --- Comment #53 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178261&action=edit Bug 37911: (follow-up) Scan for requested components in caller and lazy load This should ensure that we only load what's requested. Maybe we can also find a way to call the exported hydrate function on demand. To test: 1) Apply the patch 2) Run yarn js:watch and wait for the first build if necessary 3) Load mainpage.pl and note that only hello-islands.ts is imported. 4) Uncomment <hello-world></hello-world> in intranet-main.tt 5) Reload the page 6) Note that now both component chunks are imported on demand 7) Discuss Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176965|0 |1 is obsolete| | --- Comment #54 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178262&action=edit Bug 37911: (follow-up) Enable usage of dependencies -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176966|0 |1 is obsolete| | --- Comment #55 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178263&action=edit Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback - Additionally: - Use a type instead of an interface. - Add JSDoc to it. - Use optional chaining when checking for existence and length of config. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176967|0 |1 is obsolete| | --- Comment #56 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178264&action=edit Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176968|0 |1 is obsolete| | --- Comment #57 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178265&action=edit Bug 37911: (follow-up) Allow for initialisation of islands on demand - Split the rspack config into a umd and an esm section. - Don't hydrate by default. - Instead check the "init" attribute for the currentScript when using the umd. - Allow for manual import and call when using the esm. - Add examples for both in intranet-main.tt (to be removed). - Add a DialogIsland wrapper for the shared Dialog component (to map props to stored refs). - Move DialogIsland as well as Demo components into an Islands directory under components. - Add i18n initialisation to hydrate's idle callback. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176969|0 |1 is obsolete| | --- Comment #58 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178266&action=edit Bug 37911: (follow-up) Remove example islands for core submission Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176972|0 |1 is obsolete| | --- Comment #59 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178267&action=edit Bug 37911: (follow-up) Isolate yarn.lock changes Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #60 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Rebased to include the new tidy work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL FAIL git manipulation The file has been added and deleted in the same patchset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |me@paulderscheid.xyz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|me@paulderscheid.xyz |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|matt.blenkinsop@ptfs-europe |me@paulderscheid.xyz |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Hackfest -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #61)
FAIL FAIL git manipulation The file has been added and deleted in the same patchset
I think that's being thrown due to this commit: "Remove example islands for core submission" However, personally I think it's a helpful piece of history to keep.. it gives an example to future developers of how the code should be used... That said.. we could squash that one and document the examples elsewhere.. I think we should have both really... but I also don't think we should hold this one back -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #63 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Can't we paste it into the wiki into the soon to be vue islands docs (;D) and squash the commit? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- If we have a commit id (from the PTFS-e repo) we can cherry-pick to get the example applied on current main that would be enough IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #65 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Can we focus on the feature, and then when this is PQA and we are happy with it, we just remove the sample stuff? Seems like an easy direction to take. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Jonathan Druart <jonathan.druart@gmail.com> --- Reviewed a squashed version: 1. This is wrong - "@babel/core": "^7.26.8", - "@koha-community/prettier-plugin-template-toolkit": "^2.0.2", 2. This line should be removed + [% INCLUDE 'calendar.inc' %] 3. We should either keep webpack.config.js in sync with rspack or remove it 4. dist files are listed in Makefile.PL 5. That's a lot of duplicated code in rspack.config.js, cannot we improve that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #67 from Paul Derscheid <paul.derscheid@lmscloud.de> --- That's even better: comment #64 To comment #66: 3) Agree that we should either keep rspack and webpack configs in sync or remove the webpack config. I think the removal is probably better to lower maintenance. 5) That's true, but I think we should wait a bit before we abstract to see how the config evolves. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #68 from David Cook <dcook@prosentient.com.au> --- Really looking forward to this change :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178256|0 |1 is obsolete| | --- Comment #69 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180113&action=edit Bug 37911: Prototype vue islands within static pages This is pretty bare bones, but might still be interesting to take a look at. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178257|0 |1 is obsolete| | --- Comment #70 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180114&action=edit Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178258|0 |1 is obsolete| | --- Comment #71 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180115&action=edit Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead - This would require us to update vue to a new minor version. - We could then use the defineCustomElement function with the shadowRoot option set to false (this is important). - The current implementation in islands.ts is naive and would result in an intolerable bundle size. - The right way to do code splitting here is to use dynamic imports. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178259|0 |1 is obsolete| | --- Comment #72 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180116&action=edit Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178260|0 |1 is obsolete| | --- Comment #73 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180117&action=edit Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178261|0 |1 is obsolete| | --- Comment #74 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180118&action=edit Bug 37911: (follow-up) Scan for requested components in caller and lazy load This should ensure that we only load what's requested. Maybe we can also find a way to call the exported hydrate function on demand. To test: 1) Apply the patch 2) Run yarn js:watch and wait for the first build if necessary 3) Load mainpage.pl and note that only hello-islands.ts is imported. 4) Uncomment <hello-world></hello-world> in intranet-main.tt 5) Reload the page 6) Note that now both component chunks are imported on demand 7) Discuss Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178262|0 |1 is obsolete| | --- Comment #75 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180119&action=edit Bug 37911: (follow-up) Enable usage of dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178263|0 |1 is obsolete| | --- Comment #76 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180120&action=edit Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback - Additionally: - Use a type instead of an interface. - Add JSDoc to it. - Use optional chaining when checking for existence and length of config. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178264|0 |1 is obsolete| | --- Comment #77 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180121&action=edit Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178265|0 |1 is obsolete| | --- Comment #78 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180122&action=edit Bug 37911: (follow-up) Allow for initialisation of islands on demand - Split the rspack config into a umd and an esm section. - Don't hydrate by default. - Instead check the "init" attribute for the currentScript when using the umd. - Allow for manual import and call when using the esm. - Add examples for both in intranet-main.tt (to be removed). - Add a DialogIsland wrapper for the shared Dialog component (to map props to stored refs). - Move DialogIsland as well as Demo components into an Islands directory under components. - Add i18n initialisation to hydrate's idle callback. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178266|0 |1 is obsolete| | --- Comment #79 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180123&action=edit Bug 37911: (follow-up) Remove example islands for core submission Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178267|0 |1 is obsolete| | --- Comment #80 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180124&action=edit Bug 37911: (follow-up) Isolate yarn.lock changes Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #81 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #82 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180125&action=edit Bug 37911: (follow-up) Remove webpack.config.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #83 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180129&action=edit Bug 37911: (follow-up) Remove unneeded include of calendar.inc in intranet-main.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amaury.gau@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #84 from Jonathan Druart <jonathan.druart@gmail.com> --- A note about the example: There is a warning in the console when the surprise pops up. We need this: - <dialog-island id="surprise"></dialog-island> + <dialog-island></dialog-island> - $("#surprise").attr("warning", `<span>Yes, this is <span class="font-monospace">Dialog.vue</span> (in a wrapper component)!</span><span class="d-none">${Math.random()}</span>`); + $("dialog-island").attr("warning", `<span>Yes, this is <span class="font-monospace">Dialog.vue</span> (in a wrapper component)!</span><span class="d-none">${Math.random()}</span>`); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #85 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I think the last problem we currently have is how to best handle the files that need to be included in Makefile.PL. Ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #86 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Just noticed that I overlooked something when rebasing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #87 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180696&action=edit Bug 37911: (follow-up) Tidy and remove leftover entry point for islands in first config block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #88 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180697&action=edit Bug 37911: (follow-up) Let style-, css-loader handle styles in Koha's Vue apps - Remove 'experiments: css' for the first config block since it seems to do 2 passes when building the css. - Remove style-, css-loader configuration for islands as I assume it is unneeded in this case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #89 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Paul Derscheid from comment #85)
I think the last problem we currently have is how to best handle the files that need to be included in Makefile.PL. Ideas?
It's a hard one, or I am missing something. I don't manage to make the list "dynamic" (pass a * for instance). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #90 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I think one way to do it is to sort of include the generated files in dist via mapping in a separate file. The question is just whether ExtUtils::MakeMaker supports that and whether we have to make many changes to Makefile.PL to support that? Would maybe be useful in other contexts as well, though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #91 from Jonathan Druart <jonathan.druart@gmail.com> --- Can you make this one ready for inclusion please? We need to remove all the code from the example, and make the QA script happy (currently failing for tidy on intranet-main.tt and rspack.config.js). Then, as a first step, do you think we can remove the contenthash from the generated filenames, and then add the paths we expect to Makefile.PL? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #92 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #91)
Can you make this one ready for inclusion please?
We need to remove all the code from the example, and make the QA script happy (currently failing for tidy on intranet-main.tt and rspack.config.js).
I forgot to apply the last patches, ignore that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #93 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. Todos IMO to make this ready we need to: a. Attach to this bug the patches that are about the islands concept b. Move to a branch the patches for the example b. Remove [contenthash] from the filenames 2. Question - Also, can you explain why do we need both .esm.js and .js files? 3. Confirm bug? There is something wrong I think, somewhere... I tried to test removing the contenthash and see which files were generated, on top of the example but with the last patches, and I get: ERROR in ./koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue?vue&type=style&index=0&id=060b00a6&scoped=true&lang=css (../../../../../../node_modules/vue-loader/dist/index.js??ruleSet[0]!./koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue?vue&type=style&index=0&id=060b00a6&scoped=true&lang=css) × Module parse failed: ╰─▶ × JavaScript parsing error: Expression expected ╭─[2:0] 1 │ 2 │ .modal { · ─ 3 │ position: fixed; 4 │ z-index: 9998; ╰──── The git log is: 2fce1bbd165 (HEAD) Bug 37911: (follow-up) Let style-, css-loader handle styles in Koha's Vue apps f0325f3235a Bug 37911: (follow-up) Tidy and remove leftover entry point for islands in first config block 472e8503bc9 Bug 37911: (follow-up) Remove webpack.config.js f0afb0a3e41 Bug 37911: (follow-up) Isolate yarn.lock changes 396442e8d13 Bug 37911: (follow-up) Allow for initialisation of islands on demand c10525beedb Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production bcd6b19c98f Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback 7b8bd7fec9b Bug 37911: (follow-up) Enable usage of dependencies 561ff807fcf Bug 37911: (follow-up) Scan for requested components in caller and lazy load 78e159d9001 Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names 6732a1c5a20 Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting 148c67f284a Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead 0f0779ace1d Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props 2c9b8c5925e Bug 37911: Prototype vue islands within static pages ef4d0aa5c58 (origin/main) Bug 39460: Fix koha-upgrade-schema when no DB change needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #94 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #93)
1. Todos IMO to make this ready we need to: a. Attach to this bug the patches that are about the islands concept b. Move to a branch the patches for the example c. Remove [contenthash] from the filenames
(it was c) If c. is possible and works, then d. add the filenames to Makefile.PL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #95 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Ah ok, so the error in comment #93 means that we do need to use style-, css-loader to preserve compatibility with the Koha Vue components. Wasn't sure, but that seems to confirm it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #96 from Paul Derscheid <paul.derscheid@lmscloud.de> --- The js vs esm are for different purposes, the regular js files are for:
- Instead check the "init" attribute for the currentScript when using the umd. To get an IIFE that immediately is accessible like a normal script. - Allow for manual import and call when using the esm. For usage with: <script type="module"> import { something } from "./something" ...
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #97 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 180714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180714&action=edit Bug 37911: (follow-up) Use style-, css-loader to preserve compatiblity with Koha's Vue components, e.g. Dialog.vue - For now let's not rely on rspack's native css loader to parse and bundle styles as we need to preserve compatibility. - Reintroduce configuration block for style-, css-loader for islands. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #98 from Paul Derscheid <paul.derscheid@lmscloud.de> --- The last patch should fix the error you were encountering Jonathan :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #99 from David Cook <dcook@prosentient.com.au> --- (In reply to Paul Derscheid from comment #90)
I think one way to do it is to sort of include the generated files in dist via mapping in a separate file.
The question is just whether ExtUtils::MakeMaker supports that and whether we have to make many changes to Makefile.PL to support that?
Would maybe be useful in other contexts as well, though.
I haven't been following this bug closely, but if you need any help with ExtUtils::MakeMaker, I'm happy to help. I've had to learn some of its intricacies over the years. If you look at "sub top_targets" in Makefile.PL you can see some work I've done in the past. (Not that I'm 100% happy with the Makefile text I output there. I can't remember why I used the all target, but I imagine I had my reasons and it works well enough...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #100 from David Cook <dcook@prosentient.com.au> --- (In reply to Paul Derscheid from comment #85)
I think the last problem we currently have is how to best handle the files that need to be included in Makefile.PL. Ideas?
As per my previous comment, if you can give me the precise problem, I'll do my best to help :). April is a crazy month for me but I'll try my best. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #101 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #100)
(In reply to Paul Derscheid from comment #85)
I think the last problem we currently have is how to best handle the files that need to be included in Makefile.PL. Ideas?
As per my previous comment, if you can give me the precise problem, I'll do my best to help :). April is a crazy month for me but I'll try my best.
I am not very familiar with this script or how it's supposed to be used. But from what I understand (please correct me if I'm wrong), we're supposed to follow these three steps: 1. perl Makefile.PL 2. make 3. sudo make install During the first step, we list the different files ($file_map), then we build the resource (build-resource.PL), and finally, we copy the files. The issue is that we are now generating multiple .js files into dists/, but they don't exist yet during step 1. One possible (though not ideal) solution could be to run build-resource.PL before generating the file map and inject `ls dists/*.js` into it. By the way, I'm not sure why both steps 2 and 3 call build-resource.PL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #102 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #101)
I am not very familiar with this script or how it's supposed to be used. But from what I understand (please correct me if I'm wrong), we're supposed to follow these three steps:
1. perl Makefile.PL 2. make 3. sudo make install
During the first step, we list the different files ($file_map), then we build the resource (build-resource.PL), and finally, we copy the files.
The issue is that we are now generating multiple .js files into dists/, but they don't exist yet during step 1.
One possible (though not ideal) solution could be to run build-resource.PL before generating the file map and inject `ls dists/*.js` into it.
I'm not sure that I understand. Currently, we add the names of generated .js files to Makefile.PL (e.g. koha-tmpl/intranet-tmpl/prog/js/vue/dist/erm.js) so that it can include them in the Makefile that is generated by "perl Makefile.PL", so that "make" knows what to build and what "make install" knows what to install. (Otherwise, it will complain that there are files there that it doesn't know about and fails to build.) Is the problem that we don't know the names of the generated files, so we can't pre-add them to Makefile.PL? Honestly, I think that there are make rules that we can add for dynamically generated files, so that we don't have to list them in Makefile.PL anymore... Some experimenting to do there...
By the way, I'm not sure why both steps 2 and 3 call build-resource.PL.
So step 1 just makes the makefile. Step 2 "make" then runs builds the default target which is "makemakerdflt". "makemakedflt" builds the "all" target. The "all" target builds "compile_css_js", "pure_all", "manify_pods". build-resource.PL is run when "compile_css_js" is built. Note: I am the person who added compile_css_js to "all". I can't recall why exactly. It's something I've been meaning to revisit as it seems inefficient/unnecessary to do it twice... Step 3 calls the "install target" which for some reason I don't know which dates back to at least 2007 also includes the "all" target, so that all gets built again. We can certainly look at improving this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #103 from David Cook <dcook@prosentient.com.au> --- If someone shares an error message with me or gives me the instructions to get to the problem point, I can take a look at fixing it. I've got ideas >_> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #104 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #102)
(In reply to Jonathan Druart from comment #101) I'm not sure that I understand.
I think you did, you rephrase what I said (or at least tried to say) in a more verbose way :D (In reply to David Cook from comment #103)
If someone shares an error message with me or gives me the instructions to get to the problem point, I can take a look at fixing it.
There is no error message. Just try: 0. rm -rf koha-tmpl/intranet-tmpl/prog/js/vue/dist/* 1. apply the patches, yarn install && yarn build 2. Notice that more than admin, preservation.js and erm.js have been generated in dist 3. Generate the makefile, make, make install and notice that only admin, erm.js, preservation.js have been copied to /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/js/vue/dist/ Expected: All the .js file should be copied. Note that I don't think we should copy the .esm.js files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #105 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #104)
There is no error message. Just try: 0. rm -rf koha-tmpl/intranet-tmpl/prog/js/vue/dist/* 1. apply the patches, yarn install && yarn build 2. Notice that more than admin, preservation.js and erm.js have been generated in dist 3. Generate the makefile, make, make install and notice that only admin, erm.js, preservation.js have been copied to /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/js/vue/dist/
Expected: All the .js file should be copied.
Interesting. I thought that make should complain about unknown files being there. Maybe I had it backwards and it only complains if known files are missing. Ok, I've got something in mind for this. I shouldn't work on it today, but I might take a few minutes...
Note that I don't think we should copy the .esm.js files.
While I haven't looked at the files yet, in theory I think we should copy the .esm.js files, as I'm quite interested in working with them in the future. I find it very nice working with ESM, especially for things like plugins or *UserJS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #106 from David Cook <dcook@prosentient.com.au> --- I tried doing "make install" as kohadev-koha and root but they both ran into issues when using the default config during "perl Makefile.PL", so I'll do an alternate test... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #107 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #104)
Just try: 0. rm -rf koha-tmpl/intranet-tmpl/prog/js/vue/dist/* 1. apply the patches, yarn install && yarn build 2. Notice that more than admin, preservation.js and erm.js have been generated in dist 3. Generate the makefile, make, make install and notice that only admin, erm.js, preservation.js have been copied to /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/js/vue/dist/
Expected: All the .js file should be copied.
So this procedure threw me into a bit of confusing, because I did not have the same experience with Step 3. It actually worked fine for me in Step 3 (at least when using the "single" installation method. But I'll explain below... If you run the yarn build BEFORE perl Makefile.PL, it appears that the Makefile.PL automagically finds islands.esm.js and adds it into all the right places in the Makefile. (Probably because of the "target_map".) Then when you do "make" and "make install", islands.esm.js gets installed into the deployment directory. *However* If you DO NOT run yarn build BEFORE perl Makefile.PL, the Makefile won't know about islands.esm.js and thus doesn't copy it into blib and doesn't install it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #108 from David Cook <dcook@prosentient.com.au> --- If I recall correctly, "dh_auto_install" in debian/rules has a Perl handler which automatically runs "perl Makefile.PL", "make", and "make install", and since the Debian packaging runs against a git checkout source tarball, there's no running "perl build-resources.PL" ahead of time. Plus, I recall we wanted to make it so that all installation methods worked the same way. In hindsight, I guess we could've always shelled out from Makefile.PL to do build-resources.PL before running "get_file_map()" in Makefile.PL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #109 from David Cook <dcook@prosentient.com.au> --- So I've realized that Koha really doesn't need "make" and "make install". We thought "build-resources.PL" was being repeated, but in reality *everything* done by "make" is done again in "make install" anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #110 from David Cook <dcook@prosentient.com.au> --- Created attachment 180805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180805&action=edit Bug 37911: Update Makefile.PL to handle generated "vue/dist" files This change modifies Makefile.PL so that we no longer have to manually add to the Makefile.PL all the files that end up in the "vue/dist" folder. Instead, we dynamically generate the files, and then copy them over to the build target. Test plan: 0. Apply all patches 1. Setup intall target sudo mkdir /opt/koha sudo chown kohadev-koha /opt/koha 2. Clean build env rm -rf koha-tmpl/intranet-tmpl/prog/js/vue/dist/* blib Makefile /opt/koha/* 3. perl Makefile.PL Installation mode (dev, single, standard) [standard] single Please specify the directory in which to install Koha [/var/lib/koha/kohadev/koha] /opt/koha NOTE: Otherwise accept all defaults 4. make install 5. "vue/dist" successfully installed Note all our expected files are installed including islands.esm.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #111 from David Cook <dcook@prosentient.com.au> --- Feel free to obsolete my patch, if I misunderstood the goal. It would've been easy enough to just add islands.esm.js to the file map like we've done with erm.js, preservation.js, and admin/record_sources.js. But this provides a totally dynamic way of managing "vue/js". Note that it copies *everything*, so that will include the *.js.map as well. Feel free to update that as needed. Hopefully the code and code comments make it clear what I'm doing there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39623 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180113|0 |1 is obsolete| | Attachment #180114|0 |1 is obsolete| | Attachment #180115|0 |1 is obsolete| | Attachment #180116|0 |1 is obsolete| | Attachment #180117|0 |1 is obsolete| | Attachment #180118|0 |1 is obsolete| | Attachment #180119|0 |1 is obsolete| | Attachment #180120|0 |1 is obsolete| | Attachment #180121|0 |1 is obsolete| | Attachment #180122|0 |1 is obsolete| | Attachment #180123|0 |1 is obsolete| | Attachment #180124|0 |1 is obsolete| | Attachment #180125|0 |1 is obsolete| | Attachment #180129|0 |1 is obsolete| | Attachment #180696|0 |1 is obsolete| | Attachment #180697|0 |1 is obsolete| | Attachment #180714|0 |1 is obsolete| | Attachment #180805|0 |1 is obsolete| | --- Comment #112 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181269&action=edit Bug 37911: Prototype vue islands within static pages This is pretty bare bones, but might still be interesting to take a look at. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #113 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181270&action=edit Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #114 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181271&action=edit Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead - This would require us to update vue to a new minor version. - We could then use the defineCustomElement function with the shadowRoot option set to false (this is important). - The current implementation in islands.ts is naive and would result in an intolerable bundle size. - The right way to do code splitting here is to use dynamic imports. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #115 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181272&action=edit Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #116 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181273&action=edit Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #117 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181274&action=edit Bug 37911: (follow-up) Scan for requested components in caller and lazy load This should ensure that we only load what's requested. Maybe we can also find a way to call the exported hydrate function on demand. To test: 1) Apply the patch 2) Run yarn js:watch and wait for the first build if necessary 3) Load mainpage.pl and note that only hello-islands.ts is imported. 4) Uncomment <hello-world></hello-world> in intranet-main.tt 5) Reload the page 6) Note that now both component chunks are imported on demand 7) Discuss Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #118 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181275&action=edit Bug 37911: (follow-up) Enable usage of dependencies Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #119 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181276&action=edit Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback - Additionally: - Use a type instead of an interface. - Add JSDoc to it. - Use optional chaining when checking for existence and length of config. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #120 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181277&action=edit Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #121 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181278&action=edit Bug 37911: (follow-up) Allow for initialisation of islands on demand - Split the rspack config into a umd and an esm section. - Don't hydrate by default. - Instead check the "init" attribute for the currentScript when using the umd. - Allow for manual import and call when using the esm. - Add examples for both in intranet-main.tt (to be removed). - Add a DialogIsland wrapper for the shared Dialog component (to map props to stored refs). - Move DialogIsland as well as Demo components into an Islands directory under components. - Add i18n initialisation to hydrate's idle callback. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #122 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181279&action=edit Bug 37911: (follow-up) Remove example islands for core submission Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #123 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181280&action=edit Bug 37911: (follow-up) Isolate yarn.lock changes Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #124 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181281&action=edit Bug 37911: (follow-up) Remove webpack.config.js Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #125 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181282&action=edit Bug 37911: (follow-up) Remove unneeded include of calendar.inc in intranet-main.tt Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #126 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181283&action=edit Bug 37911: (follow-up) Tidy and remove leftover entry point for islands in first config block Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #127 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181284&action=edit Bug 37911: (follow-up) Let style-, css-loader handle styles in Koha's Vue apps - Remove 'experiments: css' for the first config block since it seems to do 2 passes when building the css. - Remove style-, css-loader configuration for islands as I assume it is unneeded in this case. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #128 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181285&action=edit Bug 37911: (follow-up) Use style-, css-loader to preserve compatiblity with Koha's Vue components, e.g. Dialog.vue - For now let's not rely on rspack's native css loader to parse and bundle styles as we need to preserve compatibility. - Reintroduce configuration block for style-, css-loader for islands. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #129 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181286&action=edit Bug 37911: Update Makefile.PL to handle generated "vue/dist" files This change modifies Makefile.PL so that we no longer have to manually add to the Makefile.PL all the files that end up in the "vue/dist" folder. Instead, we dynamically generate the files, and then copy them over to the build target. Test plan: 0. Apply all patches 1. Setup intall target sudo mkdir /opt/koha sudo chown kohadev-koha /opt/koha 2. Clean build env rm -rf koha-tmpl/intranet-tmpl/prog/js/vue/dist/* blib Makefile /opt/koha/* 3. perl Makefile.PL Installation mode (dev, single, standard) [standard] single Please specify the directory in which to install Koha [/var/lib/koha/kohadev/koha] /opt/koha NOTE: Otherwise accept all defaults 4. make install 5. "vue/dist" successfully installed Note all our expected files are installed including islands.esm.js Amended-by: Jonathan Druart Tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #130 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #111)
Hopefully the code and code comments make it clear what I'm doing there.
Excellent, thanks a lot for your help here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #131 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #93)
1. Todos IMO to make this ready we need to: a. Attach to this bug the patches that are about the islands concept b. Move to a branch the patches for the example
Not addressed, but not blocker... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #132 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #130)
(In reply to David Cook from comment #111)
Hopefully the code and code comments make it clear what I'm doing there.
Excellent, thanks a lot for your help here!
Thanks for the thanks! It was an interesting challenge! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Keywords|Hackfest |rel_25_05_candidate, | |RM_priority --- Comment #133 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not trusting my self with Vue, can you please help and rebase ASAP? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 37911: Prototype vue islands within static pages Applying: Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props Applying: Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead Applying: Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting Applying: Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names Applying: Bug 37911: (follow-up) Scan for requested components in caller and lazy load Applying: Bug 37911: (follow-up) Enable usage of dependencies Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js M koha-tmpl/intranet-tmpl/prog/js/vue/stores/navigation.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/vue/stores/navigation.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/vue/stores/navigation.js Auto-merging koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js error: Failed to merge in the changes. Patch failed at 0001 Bug 37911: (follow-up) Enable usage of dependencies hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-37911-follow-up-Enable-usage-of-dependencies-dwhd9503.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #134 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Having a look, think it will be bug 37930 conflicting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181269|0 |1 is obsolete| | --- Comment #135 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181473&action=edit Bug 37911: Prototype vue islands within static pages This is pretty bare bones, but might still be interesting to take a look at. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181270|0 |1 is obsolete| | --- Comment #136 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181474&action=edit Bug 37911: (follow-up) Correct wishful thinking in displayed comment about changes to data-props Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181271|0 |1 is obsolete| | --- Comment #137 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181475&action=edit Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead - This would require us to update vue to a new minor version. - We could then use the defineCustomElement function with the shadowRoot option set to false (this is important). - The current implementation in islands.ts is naive and would result in an intolerable bundle size. - The right way to do code splitting here is to use dynamic imports. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181272|0 |1 is obsolete| | --- Comment #138 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181476&action=edit Bug 37911: (follow-up) Experimental introduction of dynamic imports for code splitting Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181273|0 |1 is obsolete| | --- Comment #139 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181477&action=edit Bug 37911: (follow-up) Use webpack import annotations for more concise chunk names Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181274|0 |1 is obsolete| | --- Comment #140 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181478&action=edit Bug 37911: (follow-up) Scan for requested components in caller and lazy load This should ensure that we only load what's requested. Maybe we can also find a way to call the exported hydrate function on demand. To test: 1) Apply the patch 2) Run yarn js:watch and wait for the first build if necessary 3) Load mainpage.pl and note that only hello-islands.ts is imported. 4) Uncomment <hello-world></hello-world> in intranet-main.tt 5) Reload the page 6) Note that now both component chunks are imported on demand 7) Discuss Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181275|0 |1 is obsolete| | --- Comment #141 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181479&action=edit Bug 37911: (follow-up) Enable usage of dependencies Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181276|0 |1 is obsolete| | --- Comment #142 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181480&action=edit Bug 37911: (follow-up) Move store initialisation into hydrate's idle callback - Additionally: - Use a type instead of an interface. - Add JSDoc to it. - Use optional chaining when checking for existence and length of config. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181277|0 |1 is obsolete| | --- Comment #143 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181481&action=edit Bug 37911: (follow-up) Prevent resolution failure of dynamic imports when building in mode --production Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181278|0 |1 is obsolete| | --- Comment #144 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181482&action=edit Bug 37911: (follow-up) Allow for initialisation of islands on demand - Split the rspack config into a umd and an esm section. - Don't hydrate by default. - Instead check the "init" attribute for the currentScript when using the umd. - Allow for manual import and call when using the esm. - Add examples for both in intranet-main.tt (to be removed). - Add a DialogIsland wrapper for the shared Dialog component (to map props to stored refs). - Move DialogIsland as well as Demo components into an Islands directory under components. - Add i18n initialisation to hydrate's idle callback. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181279|0 |1 is obsolete| | --- Comment #145 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181483&action=edit Bug 37911: (follow-up) Remove example islands for core submission Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181280|0 |1 is obsolete| | --- Comment #146 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181484&action=edit Bug 37911: (follow-up) Isolate yarn.lock changes Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181281|0 |1 is obsolete| | --- Comment #147 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181485&action=edit Bug 37911: (follow-up) Remove webpack.config.js Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181282|0 |1 is obsolete| | --- Comment #148 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181486&action=edit Bug 37911: (follow-up) Remove unneeded include of calendar.inc in intranet-main.tt Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181283|0 |1 is obsolete| | --- Comment #149 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181487&action=edit Bug 37911: (follow-up) Tidy and remove leftover entry point for islands in first config block Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181284|0 |1 is obsolete| | --- Comment #150 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181488&action=edit Bug 37911: (follow-up) Let style-, css-loader handle styles in Koha's Vue apps - Remove 'experiments: css' for the first config block since it seems to do 2 passes when building the css. - Remove style-, css-loader configuration for islands as I assume it is unneeded in this case. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181285|0 |1 is obsolete| | --- Comment #151 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181489&action=edit Bug 37911: (follow-up) Use style-, css-loader to preserve compatiblity with Koha's Vue components, e.g. Dialog.vue - For now let's not rely on rspack's native css loader to parse and bundle styles as we need to preserve compatibility. - Reintroduce configuration block for style-, css-loader for islands. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181286|0 |1 is obsolete| | --- Comment #152 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181490&action=edit Bug 37911: Update Makefile.PL to handle generated "vue/dist" files This change modifies Makefile.PL so that we no longer have to manually add to the Makefile.PL all the files that end up in the "vue/dist" folder. Instead, we dynamically generate the files, and then copy them over to the build target. Test plan: 0. Apply all patches 1. Setup intall target sudo mkdir /opt/koha sudo chown kohadev-koha /opt/koha 2. Clean build env rm -rf koha-tmpl/intranet-tmpl/prog/js/vue/dist/* blib Makefile /opt/koha/* 3. perl Makefile.PL Installation mode (dev, single, standard) [standard] single Please specify the directory in which to install Koha [/var/lib/koha/kohadev/koha] /opt/koha NOTE: Otherwise accept all defaults 4. make install 5. "vue/dist" successfully installed Note all our expected files are installed including islands.esm.js Amended-by: Jonathan Druart Tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #153 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #154 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- i am not sure if it's caused by this, but something with the prettier seems wrong - could it be due to the yarn.lock changes here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #155 from Paul Derscheid <paul.derscheid@lmscloud.de> --- What behaviour changes have you found? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #156 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Paul Derscheid from comment #155)
What behaviour changes have you found?
Look at Jenkins... and the results from testing David has noted on bug 39677. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #157 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Yeah, I think the prettier plugin was removed from package.json by accident during the rebase in 'Bug 37911: (follow-up) Update to vue ^3.5.4, use vue's web component implementation instead'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #158 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181566&action=edit Bug 37911: (follow-up) Reintroduce @koha-community/prettier-plugin-template-toolkit - This includes its dependency @babel/core. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #159 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 181567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181567&action=edit Bug 37911: (follow-up) Associated yarn.lock changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #160 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I think those last two patches should fix all the failing tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #161 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the quick work Paul, I will push first thing Monday morning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36546 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39849 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39849 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39849 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39849 [Bug 39849] Target dependency issue in Makefile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #162 from David Cook <dcook@prosentient.com.au> --- Looks like I made a mistake with that Makefile.PL patch. I've added the fix on bug 39849. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Bug 37911 depends on bug 37824, which changed state. Bug 37824 Summary: Replace webpack with rspack for fun and profit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37824 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #163 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 --- Comment #164 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 185538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185538&action=edit [24.11.x] Bug 37911: Prototype vue islands within static pages (squashed) This backport introduces Vue islands to 24.11.x, allowing Vue components to be embedded as web components within static HTML pages in Koha. In my opinion this is necessary as it is a base for potential future bugfixes. Summary: - Vue islands TypeScript module with component registry - Dual rspack configuration for regular and ESM module builds - Support for dynamic imports and code splitting - Integration with Pinia stores for state management - Updates to Makefile.PL to handle generated vue/dist files - Removal of deprecated webpack.config.js in favor of rspack Before pushing: - Verify yarn build (in all varieties) works as it is supposed to - That the Vue app bundles, e.g. ERM work exactly as before All 20 patches were squashed for a clean backport to 24.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40773 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40773 [Bug 40773] Improve build of "vue/dist" files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40150 [Bug 40150] Prevent uncaught error on multiple attempts to 'define' on 'CustomElementsRegistry' in islands.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37911 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |david@davidnind.com Resolution|--- |FIXED --- Comment #165 from David Nind <david@davidnind.com> --- Architecture related, no changes required to the manual as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org