http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12694 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |766 Assignee|oleonard@myacpl.org |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12694 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30475|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30611&action=edit Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on unimarc_field_4XX.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. If you have unimarc config, just go to one of the fields that use this plugin. If you don't, can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12694 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30611|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30895&action=edit [PASSED QA] Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on unimarc_field_4XX.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. If you have unimarc config, just go to one of the fields that use this plugin. If you don't, can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Verified plugin still seems to work: - item type pull down shows up correctly - search works and choosing a record will fill subfields Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.