[Bug 27661] New: Clarify error for message broker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Bug ID: 27661 Summary: Clarify error for message broker Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org 'Connection failed' is a bit strong for the case where RabbitMQ is not found. In reality, we fallback to polling the database so Koha will function reasonably without the overhead of RabbitMQ. We should clarify that on the about page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116575&action=edit Bug 27661: Update about for message broker status This patch updates the about page with regards to the message broker status and adds some small formatting improvements for displaying the status. Test plan 1/ Run through the yarn build process to update the CSS file. 2/ View the about page without RabbitMQ installed 3/ View the about page with RabbitMQ installed 4/ Note the formatting and message change and signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116575|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116848&action=edit Bug 27661: Update about for message broker status This patch updates the about page with regards to the message broker status and adds some small formatting improvements for displaying the status. Test plan 1/ Run through the yarn build process to update the CSS file. 2/ View the about page without RabbitMQ installed 3/ View the about page with RabbitMQ installed 4/ Note the formatting and message change and signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116848|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116855&action=edit Bug 27661: Update about for message broker status This patch updates the about page with regards to the message broker status and adds some small formatting improvements for displaying the status. Test plan 1/ Run through the yarn build process to update the CSS file. 2/ View the about page without RabbitMQ installed 3/ View the about page with RabbitMQ installed 4/ Note the formatting and message change and signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116856&action=edit Bug 27661: (QA follow-up) Capitalization Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- +.status_fatal { + background-color: #FF6347 !important; Why tomato? :) We already have .error { color: #CC0000; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This change is actually not advertised by the patch and not directly linked with what we are doing here. Can we remove it from the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #5)
+.status_fatal { + background-color: #FF6347 !important;
Why tomato? :)
We already have .error { color: #CC0000; }
Fair point, I had forgotten we had 'error' already.. kinda annoying this table has it's own classing in the first place to be honest. Would you prefer a css change to fix the color to match our .error class.. or wider template followup to convert to using the existing classes.. I'm thinking the latter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I find the stark red as a background a bit challenging to read.. that's probably why I went for Tomato.. Must admit, I find the inconsistency in the about page upsets my OCD.. some status's are on their own line, others are inline.. some have background colors applied to a span, whilst others still have the whole row highlighted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117006&action=edit Bug 27661: (QA follow-up) Use bootstrap classes This patch removes the local status_* css rules in favour of using the bg-* rules that are shipped with the bootstrap version we are using and then updates the relevant lines in the template to use those classes. We also update the default table styling which adds background color to the odd table rows so that our local classes take precidence. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Setting back to signed off to attract a second QA run here.. I think the final followup gives us a much cleaner approach to the styling which will allow for more global use of the bootstrap bg-* options for tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://getbootstrap.com/docs/3.4/css/#helper-classes-backgrounds for reference of the bootstrap classes I'm talking about -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117006|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117010&action=edit Bug 27661: (QA follow-up) Use bootstrap classes This patch removes the local status_* css rules in favour of using the bg-* rules that are shipped with the bootstrap version we are using and then updates the relevant lines in the template to use those classes. We also update the default table styling which adds background color to the odd table rows so that our local classes take precidence. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- We are advertizing here that we support SQL polling and Rabbit MQ. Is that really the way we want to go? Support both ways for any new case where we would like to use RabbitMQ? The SQL polling has been added to the initial use of RabbitMQ as a fallback and probably for building some confidence. Since I doubt that we will be supporting both ways, I would propose rewording. Any thoughts? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #13)
We are advertizing here that we support SQL polling and Rabbit MQ. Is that really the way we want to go? Support both ways for any new case where we would like to use RabbitMQ? The SQL polling has been added to the initial use of RabbitMQ as a fallback and probably for building some confidence.
Since I doubt that we will be supporting both ways, I would propose rewording. Any thoughts?
See misc/background_jobs_worker.pl lines 58-63, there is no additional code, and it applies to all jobs. It shouldn't hurt to have it and keep it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #14)
(In reply to Marcel de Rooy from comment #13)
We are advertizing here that we support SQL polling and Rabbit MQ. Is that really the way we want to go? Support both ways for any new case where we would like to use RabbitMQ? The SQL polling has been added to the initial use of RabbitMQ as a fallback and probably for building some confidence.
Since I doubt that we will be supporting both ways, I would propose rewording. Any thoughts?
See misc/background_jobs_worker.pl lines 58-63, there is no additional code, and it applies to all jobs. It shouldn't hurt to have it and keep it.
Thx for clarifying. Had the impression that it was written for a specific job. Which is not the case. Revisiting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117022&action=edit Bug 27661: Use td.bg-success for ES and memcached as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116855|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 117023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117023&action=edit Bug 27661: Update about for message broker status This patch updates the about page with regards to the message broker status and adds some small formatting improvements for displaying the status. Test plan 1/ Run through the yarn build process to update the CSS file. 2/ View the about page without RabbitMQ installed 3/ View the about page with RabbitMQ installed 4/ Note the formatting and message change and signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116856|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 117024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117024&action=edit Bug 27661: (QA follow-up) Capitalization Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117010|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 117025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117025&action=edit Bug 27661: (QA follow-up) Use bootstrap classes This patch removes the local status_* css rules in favour of using the bg-* rules that are shipped with the bootstrap version we are using and then updates the relevant lines in the template to use those classes. We also update the default table styling which adds background color to the odd table rows so that our local classes take precidence. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117022|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 117026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117026&action=edit Bug 27661: Use td.bg-success for ES and memcached as well Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #13)
We are advertizing here that we support SQL polling and Rabbit MQ. Is that really the way we want to go? Support both ways for any new case where we would like to use RabbitMQ? The SQL polling has been added to the initial use of RabbitMQ as a fallback and probably for building some confidence.
Since I doubt that we will be supporting both ways, I would propose rewording. Any thoughts?
I think it would be trivial to drop update the change here at the same time as deprecating the polling fallback should we do that in the future. I'm actually wondering if things might go the other way... I was wary of adding yet another system to run and maintain when we added RabbitMQ personally.. I'm really not sure we need all that it offers and personally would have preferred an approach where we started with an SQL based queue and migrated to a bigger broker only as and when we found we needed it/found that polling was a performance issue. I'd also like to drop the 'required' state of the STOMP dependency as we don't actually require it to function.. we just require it at the moment as we use it to work out if RabbitMQ is present in the worker daemon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice addition also using the classes for ES and Memcached :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27661 Bug 27661 depends on bug 22417, which changed state. Bug 22417 Summary: Add a task queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org