[Bug 18902] New: Course Reserves still accessible by URL even if turned OFF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Bug ID: 18902 Summary: Course Reserves still accessible by URL even if turned OFF Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alex.sassmannshausen@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com You can access the course reserves functionality at https://kas-staff.koha-ptfs.co.uk/cgi-bin/koha/course_reserves/course-reserv... even if the syspref is turned off. A patch should implement redirection from that page when the syspref is off. Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 --- Comment #1 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 64853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64853&action=edit Bug 18902: Disable access to CourseReserves if syspref off. * course_reserves/course-reserves.pl: Add syspref check. * course_reserves/mod_course.pl: Add syspref check. * opac/opac-course-reserves.pl: Add syspref check. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64853|0 |1 is obsolete| | --- Comment #2 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 64854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64854&action=edit Bug 18902: Disable access to CourseReserves if syspref off. * course_reserves/course-reserves.pl: Add syspref check. * course_reserves/mod_course.pl: Add syspref check. * opac/opac-course-reserves.pl: Add syspref check. Test Plan: - Before applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. - After applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + None will be accessible. + Ensure UseCourseReserves is switched on + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.sassmannshausen@ptfs-e |ity.org |urope.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64854|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 65289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65289&action=edit Bug 18902: Disable access to CourseReserves if syspref off. * course_reserves/course-reserves.pl: Add syspref check. * course_reserves/mod_course.pl: Add syspref check. * opac/opac-course-reserves.pl: Add syspref check. Test Plan: - Before applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. - After applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + None will be accessible. + Ensure UseCourseReserves is switched on + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It sounds like it would be better to display a message on the staff interface, but not that easy. However do not you think that we need to modify all course_reserves/* scripts? The module may have been enabled then disabled later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65289|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65308&action=edit Bug 18902: Disable access to CourseReserves if syspref off. * course_reserves/course-reserves.pl: Add syspref check. * course_reserves/mod_course.pl: Add syspref check. * opac/opac-course-reserves.pl: Add syspref check. Test Plan: - Before applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. - After applying this patch: + Ensure UseCourseReserves is switched off + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + None will be accessible. + Ensure UseCourseReserves is switched on + visit OPAC: cgi-bin/koha/opac-course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/course-reserves.pl + visit Intranet: /cgi-bin/koha/course_reserves/mod_course.pl + All will be accessible. Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4)
It sounds like it would be better to display a message on the staff interface, but not that easy. However do not you think that we need to modify all course_reserves/* scripts? The module may have been enabled then disabled later.
This needs an answer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
(In reply to Jonathan Druart from comment #4)
It sounds like it would be better to display a message on the staff interface, but not that easy. However do not you think that we need to modify all course_reserves/* scripts? The module may have been enabled then disabled later.
This needs an answer
Overlooked your comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Elizabeth John <elizabethjohn6654@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elizabethjohn6654@gmail.com --- Comment #8 from Elizabeth John <elizabethjohn6654@gmail.com> --- The students may significantly face problem in academics and generating assignments, essays and other documents can take the services from the online platforms and online sites like https://dissertationwritinghelp.uk/buy-master-dissertation-service/ and many other sites. These services providing platforms are highly reliable and authentic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18902 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #9 is|1 |0 private| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org