[Bug 30541] New: Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Bug ID: 30541 Summary: Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table. This bug appears to only exist in 21.11 at this time. It was fixed by a combination of bugs 29495 and 28588. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 133300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133300&action=edit Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table. This bug appears to only exist in 21.05 at this time. It was fixed by a combination of bugs 29495 and 28588. Test Plan: 1) Set MarkLostItemsAsReturned for return claims 2) Mark a checkout as claims returned 3) Verify the checkout is no longer on the patron record 4) Resolve the claim 5) Note the attempt "hangs" but refreshing the page shows it worked 6) Apply this patch, restart all the things! 7) Repeat steps 2-4 8) It works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Typo, this bug appears to only exist in 21.05 at this time. Not 21.11 as previously stated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133300|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 133301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133301&action=edit Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table. This bug appears to only exist in 21.05 at this time. It was fixed by a combination of bugs 29495 and 28588. Test Plan: 1) Set MarkLostItemsAsReturned for return claims 2) Mark a checkout as claims returned 3) Verify the checkout is no longer on the patron record 4) Resolve the claim 5) Note the attempt "hangs" but refreshing the page shows it worked 6) Apply this patch, restart all the things! 7) Repeat steps 2-4 8) It works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133301|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 133357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133357&action=edit Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table. This bug appears to only exist in 21.05 at this time. It was fixed by a combination of bugs 29495 and 28588. Test Plan: 1) Set MarkLostItemsAsReturned for return claims 2) Mark a checkout as claims returned 3) Verify the checkout is no longer on the patron record 4) Resolve the claim 5) Note the attempt "hangs" but refreshing the page shows it worked 6) Apply this patch, restart all the things! 7) Repeat steps 2-4 8) It works! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133357|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 133377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133377&action=edit Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table. This bug appears to only exist in 21.05 at this time. It was fixed by a combination of bugs 29495 and 28588. Test Plan: 1) Set MarkLostItemsAsReturned for return claims 2) Mark a checkout as claims returned 3) Verify the checkout is no longer on the patron record 4) Resolve the claim 5) Note the attempt "hangs" but refreshing the page shows it worked 6) Apply this patch, restart all the things! 7) Repeat steps 2-4 8) It works! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Christine Lee <chlee@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133377|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133387&action=edit Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims Basically, if MarkLostItemsAsReturned is set for return claims, the code will crash while trying to pull the checkout so it can update the lost status of the item. This is because the code assumes there must be a checkout and never checks the old_checkouts table. This bug appears to only exist in 21.05 at this time. It was fixed by a combination of bugs 29495 and 28588. Test Plan: 1) Set MarkLostItemsAsReturned for return claims 2) Mark a checkout as claims returned 3) Verify the checkout is no longer on the patron record 4) Resolve the claim 5) Note the attempt "hangs" but refreshing the page shows it worked 6) Apply this patch, restart all the things! 7) Repeat steps 2-4 8) It works! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Christine Lee <chlee@pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple fix that causes no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable Version(s)| |21.05.14 released in| | CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Note about oldstable: It has been pushed to 21.05.x for 21.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30541 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org