[Bug 41740] New: Add count of new curbside pickups to button on circulation home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 Bug ID: 41740 Summary: Add count of new curbside pickups to button on circulation home Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com The koha mainpage displays when there are new curbside pickups - it owuld be nice on the circulation homepage to show this too -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192272&action=edit Bug 41740: Add count of pending curbside pickups to circulation home To test: 1 - Enable the Curbside pickup module http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CurbsidePickup 2 - Enable the module for Centerville: http://localhost:8081/cgi-bin/koha/admin/curbside_pickup.pl 3 - Allow 'Patron pickup' and add a slot for the current day of the week from 00:00 to 23:59 4 - Sign in to OPAC 5 - PLace a hold 6 - Go to your account 7 - Click 'Curbside pickups' 8 - Schedule a pickup 9 - Return to staff interface 10 - Note the homepage has a link for 'New curbside pickups (1)' 11 - Go to Circulation 12 - Note the Curbside button has no extra info 13 - Apply patch 14 - Reload circulation homepage 15 - Note button now has "( 1 new )" 16 - Click the button 17 - Mark the request as 'Staged and ready' 18 - Reload circulation home 19 - Confirm the button shows no new requests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 192282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192282&action=edit Bug 41740: Add count of pending curbside pickups to circulation home To test: 1 - Enable the Curbside pickup module http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CurbsidePickup 2 - Enable the module for Centerville: http://localhost:8081/cgi-bin/koha/admin/curbside_pickup.pl 3 - Allow 'Patron pickup' and add a slot for the current day of the week from 00:00 to 23:59 4 - Sign in to OPAC 5 - PLace a hold 6 - Go to your account 7 - Click 'Curbside pickups' 8 - Schedule a pickup 9 - Return to staff interface 10 - Note the homepage has a link for 'New curbside pickups (1)' 11 - Go to Circulation 12 - Note the Curbside button has no extra info 13 - Apply patch 14 - Reload circulation homepage 15 - Note button now has "( 1 new )" 16 - Click the button 17 - Mark the request as 'Staged and ready' 18 - Reload circulation home 19 - Confirm the button shows no new requests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I think the "( 1 new )" should be "(1 new)" - without the spaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 197111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197111&action=edit Bug 41740: (QA follow-up) Pass curbside count to template When testing, I noticed the curbside pickup count would sometimes disappear on page refresh and then reappear on a subsequent refresh. This follow-up passes a plain count to the template instead of the resultset object, which makes the template logic simpler and more predictable. It also removes extra spacing in the display text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197111|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 197113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197113&action=edit Bug 41740: (QA follow-up) Pass curbside count to template When testing, I noticed the curbside pickup count would sometimes disappear on page refresh and then reappear on a subsequent refresh. This follow-up passes a plain count to the template instead of the resultset object, which makes the template logic simpler and more predictable. It also removes extra spacing in the display text. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |indicator for the number of | |new curbside pickups to the | |circulation page, for | |example "Curbside pickups | |(1 new)", when | |CurbsidePickup is enabled | |(Circulation > Holds and | |bookings). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org