https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I don't think there's an easy way to update existing AUTO_RENEWALS_DGST notices, but we should update the mandatory sample notices at least. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 167054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167054&action=edit Bug 36741: Skip auto_too_soon issues in auto renew digest This change adds a line to skip auto_too_soon issues/checkouts in the auto renew digest template. Since auto_too_soon do not trigger notifications and don't require any special action, let's skip them in the breakdown of checkouts in the AUTO_RENEWALS_DGST email. Test plan: 0. Apply the patch 1. reset_all (in koha-testing-docker) 2. Note the following line in the AUTO_RENEWALS_DGST template: [% NEXT IF (checkout.auto_renew_error == 'auto_too_soon') %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167054|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 167137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167137&action=edit Bug 36741: Skip auto_too_soon issues in auto renew digest This change adds a line to skip auto_too_soon issues/checkouts in the auto renew digest template. Since auto_too_soon do not trigger notifications and don't require any special action, let's skip them in the breakdown of checkouts in the AUTO_RENEWALS_DGST email. Test plan: 0. Apply the patch 1. reset_all (in koha-testing-docker) 2. Note the following line in the AUTO_RENEWALS_DGST template: [% NEXT IF (checkout.auto_renew_error == 'auto_too_soon') %] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- If you use [% NEXT IF (checkout.auto_renew_error == 'auto_too_soon') %] will it not lead to an erroneous count here: "There were [% error %] items that were not renewed." ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Cook from comment #6)

(In reply to Lucas Gass from comment #5)

...

If you use [% NEXT IF (checkout.auto_renew_error == 'auto_too_soon') %] will it not lead to an erroneous count here:

"There were [% error %] items that were not renewed."

?

Nope. auto_too_soon isn't added to the error count, so it would actually be more accurate.

$renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{error}++ unless $success || $error eq 'auto_too_soon';

$renew_digest->{ $auto_renew->borrowernumber }->{error}++ unless $success || $error eq 'auto_too_soon';

Ah, great! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167137|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168140&action=edit Bug 36741: Skip auto_too_soon issues in auto renew digest This change adds a line to skip auto_too_soon issues/checkouts in the auto renew digest template. Since auto_too_soon do not trigger notifications and don't require any special action, let's skip them in the breakdown of checkouts in the AUTO_RENEWALS_DGST email. Test plan: 0. Apply the patch 1. reset_all (in koha-testing-docker) 2. Note the following line in the AUTO_RENEWALS_DGST template: [% NEXT IF (checkout.auto_renew_error == 'auto_too_soon') %] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #9)

I am wondering about this one. Won't this create an empty notice if all items are "auto_too_soon"?

No, because notices only go out if the "updated" flag in the $renew_digest hashref is set to 1, and if all items are "auto_too_soon", the "updated" flag won't be set to 1: $renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{updated} = 1 if $updated && (!$error || $error ne 'auto_too_soon'); $renew_digest->{ $auto_renew->borrowernumber }->{updated} = 1 if $updated && (!$error || $error ne 'auto_too_soon'); Resetting to Passed QA. -- I've had this running in production for about 2 months now, and so far so good. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was wondering if we should not "remove" those items from the loop so we can do without additional code in the sample notices. The notices get a bit harder to read/understand for librarians that way, but I think it gives flexibility for those who might want to include a note about these items. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the release notes| |AUTO_RENEWALS_DGST notice | |so that items where it is | |too soon to renew aren't | |included in the notice to | |patrons when the automatic | |renewals cron job is run | |(based on the circulation | |rules settings). These | |items were previously | |included in the notice. | | | |NOTE: This notice is only | |updated for new | |installations. Existing | |installations should update | |this notice if they only | |want to show the actual | |items automatically | |renewed. CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- I'm not sure if I described this correctly in the release notes - please update to correct my mistakes. I've never really got my head around these settings for the circulation rules! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.