[Bug 34022] New: Barcode is not accepting upon confirmation of order receiving after upgrading to 23.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Bug ID: 34022 Summary: Barcode is not accepting upon confirmation of order receiving after upgrading to 23.05 Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: librarian@pilani.bits-pilani.ac.in QA Contact: testopia@bugs.koha-community.org Created attachment 152377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152377&action=edit steps followed for receiving an order The acquisition module, the system failed to save the barcode at the time of receiving items in an order. Clicking on confirmation and finishing the receipt while cataloguing showing Holding 0 though in the acquisition details button it is showing received 1 copy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Ranjan <librarian@pilani.bits-pilani.ac.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In your PDF, the actual receive form is missing, also the basket summary page. On the receive form, do you have the item form on the left? Koha can create items in acq on ordering, on receiving or not at all. It depends on your setting for each basket. So copies don't need to be linked to items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #2 from Ranjan <librarian@pilani.bits-pilani.ac.in> --- Yes... at the time of receiving all data are showing perfectly including currency and the right side barcode, but after confirmation, in the summery showing the item under Already received (as shown in the attached file) but without the barcodes which I had assigned at the time of receiving the copies. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do you see the item form or where do you enter the barcode? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #4 from Ranjan <librarian@pilani.bits-pilani.ac.in> --- Created attachment 152383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152383&action=edit All steps -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #5 from Ranjan <librarian@pilani.bits-pilani.ac.in> --- Submitted new attachments showing the setup at AcqCreateItem - receiving an order in Global preference and order receiving worksheet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Barcode is not accepting |Adding items on receive is |upon confirmation of order |broken |receiving after upgrading | |to 23.05 | Severity|enhancement |blocker CC| |michaela.sieber@kit.edu, | |tomascohen@gmail.com --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Ranjan, thanks a lot for providing the updated document. I can confirm that adding items on receive in master and 23.05 is broken. I am updating this bug to high severity. Testing notes: * Create a basket with 'create items on receive' * Create an order line * Close basket * Receive shipment * Enter invoice number * Click on Receive link in the table * Fill out item form, make sure all mandatory fields are set * Save * Verify that the order line is marked as 'received' * Verify that there has been no item created on the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #7 from Ranjan <librarian@pilani.bits-pilani.ac.in> --- Thanks Katrin Fischer I am perfect with all this steps. Only problem is on clicking on the Confirmation button, the barcode is not saving and showing holding as zero. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34057 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Ranjan <librarian@pilani.bits-pilani.ac.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- blocker is worse than critical ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #10 from Ranjan <librarian@pilani.bits-pilani.ac.in> --- Hope the community is working on this for solving the problem quickly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34046 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #12 from Ranjan <librarian@pilani.bits-pilani.ac.in> --- Today I have observed that, on receiving, the system is not showing any result at the bottom immediately. Just after refresh, the result is coming. I have tested with one record, tried to give the barcode by edit item option from catalogue module, KOHA failed to carry the Item wise Price, and vendor information from acqusition. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8179 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Ranjan from comment #12)
Today I have observed that, on receiving, the system is not showing any result at the bottom immediately. Just after refresh, the result is coming. I have tested with one record, tried to give the barcode by edit item option from catalogue module, KOHA failed to carry the Item wise Price, and vendor information from acqusition.
There is a separate bug for this already: Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
(In reply to Ranjan from comment #12)
Today I have observed that, on receiving, the system is not showing any result at the bottom immediately. Just after refresh, the result is coming. I have tested with one record, tried to give the barcode by edit item option from catalogue module, KOHA failed to carry the Item wise Price, and vendor information from acqusition.
There is a separate bug for this already: Bug 34036 - Single receive doesn't reload data and order lines appears as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #13) pending -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 152581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152581&action=edit Bug 34022: Adjust items data structure When creating items at receiving, the generated data structure didn't match what the code expected, so this patch adapts the code to match the new data structure introduced by bug 8179. Once I fixed that, I noticed that the $.ajax request payload, when it contains an array parameter, it renames it like `param[]`. So the finishreceive.pl controller is adjusted to this behaviour for the 'on receiving' use case. To test: 1. Apply this patch 2. Create a basket with 'create items on receive' 3. Create an order line 4. Close basket 5. Receive shipment 6. Enter invoice number 7. Click on Receive link in the table 8. Fill out item form, make sure all mandatory fields are set 9. Save 10. Verify that the order line is marked as 'received' 11. Verify that there item is created on the record => SUCCESS: Works as expected 12. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152581|0 |1 is obsolete| | --- Comment #16 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 152612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152612&action=edit Bug 34022: Adjust items data structure When creating items at receiving, the generated data structure didn't match what the code expected, so this patch adapts the code to match the new data structure introduced by bug 8179. Once I fixed that, I noticed that the $.ajax request payload, when it contains an array parameter, it renames it like `param[]`. So the finishreceive.pl controller is adjusted to this behaviour for the 'on receiving' use case. To test: 1. Apply this patch 2. Create a basket with 'create items on receive' 3. Create an order line 4. Close basket 5. Receive shipment 6. Enter invoice number 7. Click on Receive link in the table 8. Fill out item form, make sure all mandatory fields are set 9. Save 10. Verify that the order line is marked as 'received' 11. Verify that there item is created on the record => SUCCESS: Works as expected 12. Sign off :-D Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Michaela! Starting QA, but if someone else wants to have a look, the more eyes the better. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152612|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152619&action=edit Bug 34022: Adjust items data structure When creating items at receiving, the generated data structure didn't match what the code expected, so this patch adapts the code to match the new data structure introduced by bug 8179. Once I fixed that, I noticed that the $.ajax request payload, when it contains an array parameter, it renames it like `param[]`. So the finishreceive.pl controller is adjusted to this behaviour for the 'on receiving' use case. To test: 1. Apply this patch 2. Create a basket with 'create items on receive' 3. Create an order line 4. Close basket 5. Receive shipment 6. Enter invoice number 7. Click on Receive link in the table 8. Fill out item form, make sure all mandatory fields are set 9. Save 10. Verify that the order line is marked as 'received' 11. Verify that there item is created on the record => SUCCESS: Works as expected 12. Sign off :-D Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 [Bug 34109] When adding items on receive, mandatory fields are not checked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tested the various workflows (in cataloging, on order, on receive) with single and multiple items. Found 2 more bugs in the process: Bug 34109 - When adding items on receive, mandatory fields are not checked (major) Bug 34108 - When items are added on receive, item selection gets lost on editing items (normal) Also noticed this one again, it also needs an urgent fix: Bug 34036 - Single receive doesn't reload data and order lines appears as pending -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to stable |Needs documenting --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Not backporting to 22.11.x, missing dependency 8719 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34022 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |aude.charillon@ptfs-europe. | |com Status|Needs documenting |RESOLVED --- Comment #23 from Aude Charillon <aude.charillon@ptfs-europe.com> --- No updates to the Koha Manual needed. Moving this to Resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org