[Bug 20944] New: Add routes to add credits and debits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Bug ID: 20944 Summary: Add routes to add credits and debits to a patron's account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |20942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 [Bug 20942] Add route to get patron's account balance -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Patrons_account_l | |ines_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 [Bug 20997] Add Koha::Account::Line::apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes to add credits |Add routes to add credits |and debits to a patron's |to a patron's account |account | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21043 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15165 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 [Bug 15165] REST API routes to list, edit and pay borrower's accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Bug 20944 depends on bug 20978, which changed state. Bug 20978 Summary: Add Koha::Account::add_credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 76815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76815&action=edit Bug 20944: OpenAPI spec for /patrons/{patron_id}/account/credits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 76816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76816&action=edit Bug 20944: Add route to add credits to a patron's account This patch adds the /patrons/{patron_id}/account/credits endpoint, that can be used to add credits to a patron's account. It is implemented so the new credits are used to pay existing debts. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Make your favourite REST testing tool (RESTer on Firefox?) do: POST /api/v1/patrons/{patron_id}/account/credits { "amount": 100 } - Play with other possible attributes on the credit object. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76815|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77645&action=edit Bug 20944: OpenAPI spec for /patrons/{patron_id}/account/credits Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76816|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 77646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77646&action=edit Bug 20944: Add route to add credits to a patron's account This patch adds the /patrons/{patron_id}/account/credits endpoint, that can be used to add credits to a patron's account. It is implemented so the new credits are used to pay existing debts. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Make your favourite REST testing tool (RESTer on Firefox?) do: POST /api/v1/patrons/{patron_id}/account/credits { "amount": 100 } - Play with other possible attributes on the credit object. - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ooops, I thought I'd already signed this one off.. Looks good, works well.. no breakages and completes the functionality off nicely for working with patron accounts. Signing Off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77645|0 |1 is obsolete| | Attachment #77646|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77928&action=edit Bug 20944: OpenAPI spec for /patrons/{patron_id}/account/credits Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77929&action=edit Bug 20944: Add route to add credits to a patron's account This patch adds the /patrons/{patron_id}/account/credits endpoint, that can be used to add credits to a patron's account. It is implemented so the new credits are used to pay existing debts. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons_accounts.t => SUCCESS: Tests pass! - Make your favourite REST testing tool (RESTer on Firefox?) do: POST /api/v1/patrons/{patron_id}/account/credits { "amount": 100 } - Play with other possible attributes on the credit object. - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Bug 20944 depends on bug 20942, which changed state. Bug 20942 Summary: Add route to get patron's account balance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20942 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 78329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78329&action=edit Bug 20944: Fix perlcritic issues Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #9)
Created attachment 78329 [details] [review] Bug 20944: Fix perlcritic issues
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Followup pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Introduces the API endpoint release notes| |for dealing with patron | |account credits, a highly | |requested feature for | |third-party integrations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786 [Bug 21786] Routes for credits should include library_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Bug 20944 depends on bug 20997, which changed state. Bug 20997 Summary: Add Koha::Account::Line::apply https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29453 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28544 [Bug 28544] Add API's for account transactions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org