[Bug 34446] New: Typo: Can be guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Bug ID: 34446 Summary: Typo: Can be guarantee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The setting's label in administration > patron categories is missing a colon at the end: Can be guarantee: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |Laura.escamilla@bywatersolu | |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 156012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156012&action=edit Bug 34446: Added missing colon to Can be guarantee To test: 1. Go to Administration > patron categories and edit or create a new category. Notice that “Can be guarantee” does not have a colon. 2. Apply patch and refresh the page. 3. Can be guarantee now has a colon — yay! 4. Sign off and have a great day. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Laura, your patch is missing the nice test plan you wrote - I believe you might have added it in the 'git bz attach' patch. This only adds it to bugzilla, but not to your patch file. You need to add it with "git commit". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156012|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156021&action=edit Bug 34446: Added missing colon to Can be guarantee To test: 1. Go to Administration > patron categories and edit or create a new category. Notice that “Can be guarantee” does not have a colon. 2. Apply patch and refresh the page. 3. Can be guarantee now has a colon — yay! 4. Sign off and have a great day. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156022&action=edit Bug 34446: (QA follow-up) Add colons on delete confirm page This adds the missing colon on the 'confirm deletion' page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Using my super powers :) - PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #2)
Hi Laura, your patch is missing the nice test plan you wrote - I believe you might have added it in the 'git bz attach' patch. This only adds it to bugzilla, but not to your patch file. You need to add it with "git commit".
I'll make sure to do that next time. Thank you, Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34446 --- Comment #9 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org