[Bug 41211] New: Cannot cancel patron holds in some cases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Bug ID: 41211 Summary: Cannot cancel patron holds in some cases Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com The workflow here is specific. To recreate: 1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d. 2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858 3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected". 4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined 5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation". 6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber= 7. IF you go back to the patron record the hold is not cancelled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189231&action=edit Bug 41211: Deal with findborrower in holds_table_patron_page function To test: 1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d. 2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858 3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected". 4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined 5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation". 6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber= 7. IF you go back to the patron record the hold is not cancelled. 8. APPLY PATCH and clear the browser cache. 9. Try again, eveything should work! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189231|0 |1 is obsolete| | --- Comment #2 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 189365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189365&action=edit Bug 41211: Deal with findborrower in holds_table_patron_page function To test: 1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d. 2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858 3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected". 4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined 5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation". 6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber= 7. IF you go back to the patron record the hold is not cancelled. 8. APPLY PATCH and clear the browser cache. 9. Try again, eveything should work! Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g Status|Needs Signoff |Signed Off --- Comment #3 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Patch works as described, canceling works again when pulling up patron record with findborrower. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189684&action=edit Bug 41211: Deal with findborrower in holds_table_patron_page function To test: 1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d. 2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858 3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected". 4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined 5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation". 6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber= 7. IF you go back to the patron record the hold is not cancelled. 8. APPLY PATCH and clear the browser cache. 9. Try again, eveything should work! Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 ayoung <ayoung@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ayoung@oslri.net --- Comment #6 from ayoung <ayoung@oslri.net> --- Any chance we can backport to 25.05? Some of our staff have been running into this and it is causing a bit of confusion! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- @ayoung depends on a tree of enhancements, so probably no. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 --- Comment #8 from ayoung <ayoung@oslri.net> --- (In reply to Paul Derscheid from comment #7)
@ayoung depends on a tree of enhancements, so probably no.
Aw, shucks. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41211 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |Needs documenting --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org