[Bug 35630] New: Add ability to log changes to Authorized Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Bug ID: 35630 Summary: Add ability to log changes to Authorized Values Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com With the increase in number of authorized values, and with the newer sys pref CreateAVFromCataloguing, it is becoming essential to be able to determine who/when/how changes are made to authorized values, and this not currently being logged. It would be a great help to be able to log these changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] [Omnibus] Improve and extend logging in Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #1 from Laura O'Neil <laura@bywatersolutions.com> --- +1, this would be extremely useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Alban Peyrat <alban.peyrat_koha@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alban.peyrat_koha@yahoo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Chris Rowlands <chris.rowlands6@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.rowlands6@nhs.net --- Comment #2 from Chris Rowlands <chris.rowlands6@nhs.net> --- As a system librarian trying to work out if I've made a change to an auth value, or someone else did it without my input, I'd love this feature to exist! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 168747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168747&action=edit Bug 35630: Add new system preference 'AuthorizedValuesLog' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 168748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168748&action=edit Bug 35630: Add ability to log creation, modification, and deletion of authorized values These patches enable librarians to log any changes to authorized values. The feature is dependent on the new 'AuthorizedValuesLog' system preference. To test: 1) Apply patch, updatedatabase, restart_all 2) In Administration->System preferences, search for 'AuthorizedValuesLog' and change to 'Log'. Save your changes. 3) Now go to Administration->Authorized values. Keep this tab open 4) In a new tab, go to Tools -> Log viewer. Ensure that "Authorized values" is checked. 5) Now in AV, click on a category and create a new authorized value. 6) Refresh your log viewer, and the creation should be logged appropiately. 7) Modify an authroized value, this should also be logged correctly. 8) Now delete and authorized value, ensure the logging is correct here as well. 9) Now turn off the system preferece. 10) In the log viewer, 'Authorized values' should have a black triangle next to it, indicating the preference is turned off. 11) Change an AV, this should not be logged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | CC| |samalau@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- It works as described it test plan, but: 1. QA - Not blocker: Sysprefs IntranetAddMastheadLibraryPulldown is bad placed (see bug 10610) 2. What should be recorded into 'info' column in action_logs table? Value before modification or value after mod.? For bibliographic record it is value before modification. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #6 from Sam Lau <samalau@gmail.com> --- (In reply to Roman Dolny from comment #5)
It works as described it test plan, but:
1. QA - Not blocker: Sysprefs IntranetAddMastheadLibraryPulldown is bad placed (see bug 10610)
This is unrelated to this bug.
2. What should be recorded into 'info' column in action_logs table? Value before modification or value after mod.?
I would think the value after modification. If you wanted to see the value before modifcation, then you would just go back into the logs.
For bibliographic record it is value before modification.
I see what you are saying about editing a record, but there's examples where it goes the other way as well. For example, when editing a specific item, the logs show the value after. I think this is better behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- (In reply to Sam Lau from comment #6)
...
2. What should be recorded into 'info' column in action_logs table? Value before modification or value after mod.?
I would think the value after modification. If you wanted to see the value before modifcation, then you would just go back into the logs.
This works for new values and subsequent modifications of values before logging begins. But not for the first modification of values currently existing in the database. (But I'm not sure if this is really important.) Maybe we should record the old and new value in the "info" column? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> ---
Maybe we should record the old and new value in the "info" column?
I think that is confusing. Why not just log the new value as MODIFY? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to log changes |Add ability to log changes |to Authorized Values |to authorized values CC| |kyle@bywatersolutions.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We pushed bug 25159 to the end of the cycle and I feel like we should make use of it when adding new logs now. Adding Kyle and also a topic to next meeting agenda: https://wiki.koha-community.org/w/index.php?title=Development_IRC_meeting_17_July_2024&action=submit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #10 from Sam Lau <samalau@gmail.com> --- Created attachment 169027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169027&action=edit Bug 35630: Handle library limits inside the store function This patch makes use of the diff action_logs as mentioned in comment 9. Furthermore, to fix the issue of calling store twice when creating a new AV, the "replace_library_limits" call has been moved inside to the store function. Use test plan from previous patch to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168747|0 |1 is obsolete| | Attachment #168748|0 |1 is obsolete| | Attachment #169027|0 |1 is obsolete| | --- Comment #11 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169044&action=edit Bug 35630: Add new system preference 'AuthorizedValuesLog' Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #12 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169045&action=edit Bug 35630: Add ability to log creation, modification, and deletion of authorized values These patches enable librarians to log any changes to authorized values. The feature is dependent on the new 'AuthorizedValuesLog' system preference. To test: 1) Apply patch, updatedatabase, restart_all 2) In Administration->System preferences, search for 'AuthorizedValuesLog' and change to 'Log'. Save your changes. 3) Now go to Administration->Authorized values. Keep this tab open 4) In a new tab, go to Tools -> Log viewer. Ensure that "Authorized values" is checked. 5) Now in AV, click on a category and create a new authorized value. 6) Refresh your log viewer, and the creation should be logged appropiately. 7) Modify an authroized value, this should also be logged correctly. 8) Now delete and authorized value, ensure the logging is correct here as well. 9) Now turn off the system preferece. 10) In the log viewer, 'Authorized values' should have a black triangle next to it, indicating the preference is turned off. 11) Change an AV, this should not be logged. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #13 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169046&action=edit Bug 35630: Handle library limits inside the store function This patch makes use of the diff action_logs as mentioned in comment 9. Furthermore, to fix the issue of calling store twice when creating a new AV, the "replace_library_limits" call has been moved inside to the store function. Use test plan from previous patch to test. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Failing tests with this patch applied. Probably need to add tests here to cover the change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Maybe instead of converting the object to in Log.pm ( $infos = Data::Dumper::Dumper( $infos ) if ref $infos; ) which makes me a bit nervous it could be done in AuthorisedValue.pm and only when dealing with AUTHORIZEDVALUE changes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172629&action=edit Bug 35630: Move Data::Dump to AuthorisedValue.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucas@bywatersolutions.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- I think it's prudent to now get a 2nd sign-off, returning this one to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |william.lavoie@inLibro.com --- Comment #18 from William Lavoie <william.lavoie@inLibro.com> --- Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 --- Comment #19 from Angela Berrett <angela.berrett@familysearch.org> --- I'm hoping that this is still a small patch that can be easily implemented. It seems to have fallen off the radar. We would love to see this happen. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35630 Paula Doty <PaulaDoty@admin.nv.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |PaulaDoty@admin.nv.gov --- Comment #20 from Paula Doty <PaulaDoty@admin.nv.gov> --- +1 on logging changes to authorized values - CoOp member here and we have lots of folks who have the ability to make changes with unintended consequences to other library branches. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org