[Bug 12280] New: "Others..." reason for suggestions not showing in Bootstrap OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Bug ID: 12280 Summary: "Others..." reason for suggestions not showing in Bootstrap OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org You you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. To test: - Create a suggestion - Accept or reject it entering a reason manually instead of picking one from the pull down list - Switch to prog theme - Look at the suggestion in the OPAC, verify the reason displays - Switch to bootstrap theme - Verify in OPAC that the reason doesn't display -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 28448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28448&action=edit Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC If you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. This patch corrects the problem. This patch also adds a missing [% USE AuthorisedValues %] which would cause errors if the template tried to display a custom suggestion status as defined in the SUGGEST_STATUS authorized value category. To test, accept or reject a suggestion and specify a custom reason. View that suggestion in the Bootstrap OPAC and confirm that the custom reason is displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28448|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 28577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28577&action=edit [SIGNED-OFF] Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC If you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. This patch corrects the problem. This patch also adds a missing [% USE AuthorisedValues %] which would cause errors if the template tried to display a custom suggestion status as defined in the SUGGEST_STATUS authorized value category. To test, accept or reject a suggestion and specify a custom reason. View that suggestion in the Bootstrap OPAC and confirm that the custom reason is displayed. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28577|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28617&action=edit Bug 12280 - "Others..." reason for suggestions not showing in Bootstrap OPAC If you accept or reject a suggestion using the "Others..." option and entering a reason manually, the text is not showing up in the Bootstrap OPAC theme as it does in CCSR and prog. This patch corrects the problem. This patch also adds a missing [% USE AuthorisedValues %] which would cause errors if the template tried to display a custom suggestion status as defined in the SUGGEST_STATUS authorized value category. To test, accept or reject a suggestion and specify a custom reason. View that suggestion in the Bootstrap OPAC and confirm that the custom reason is displayed. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12280 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org