http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-09-16 15:34:40 UTC --- Moving compilation of the module code from compile to runtime seems a bit counter intuitive. Certainly if we start running the code in any kind of persistent framework we want to do the opposite. One thing that aids maintenenance is to only pollute (I mean import into ) your namespace those subroutines that you need. i.e, use Module qw( function1 function2); It also flags up to those who come after you how much of that module is used. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:21:31 UTC --- Created attachment 5497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5497 Bug 6875 de-nesting C4/Branch.pm use C4::Koha was loaded only to call C4::Koha::get_infos_of in get_branchinfos_of the sub get_branchinfos_of was used nowhere (checked with "grep -R get_branchinfos_of *") only one reference was made to get_branchinfos_of, in reserve/request.pl, but the sub was not used in fact (maybe removed previously & silently) This patch removes sub get_branchinfos_of and use C4::Koha in C4::Branch, as well as the reference in request.pl and the t test The patch don't remove use C4::Branch in reserve/request.pl, it must be checked that it's useless first -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:22:11 UTC --- Created attachment 5499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5499 Bug 6875 de-nesting C4/Serials * use C4::Branch is loaded only to call GetBranchNAme in PrepareSerialsData and set branchname in the hashresult. This sub PrepareSerialsData is used in the following scripts : opac/opac-serial-issues.pl: my $subscriptioninformation=PrepareSerialsData($subscriptions); => no use of branchname after serials/serials-collection.pl: $subscriptions=PrepareSerialsData(\@subscriptioninformation); => no use of branchname after => we can remove the ->{branchname} from the result, and remove the C4::Branch dependancy * moves use C4::Items to require C4::Items, to call AddItemFromMarc, when receiving a serial, with Recieving create an item set in the subscription. * removed use C4::Letters and C4::Search, that are useless -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:23:09 UTC --- Created attachment 5501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5501 Bug 6875 de nesting C4::Biblio C4::Biblio is used in many many places. The goal of this cleaning is to do from C4::Biblio a package with as many dependancies as possible. * C4::Heading is called only in 1 place, highly rarely used (only in 1 misc/link_bibs_to_authorities.pl), moving to require * PrepareItemrecordDisplay is a sub that is more related to Items, moving it here. It means some scripts that used this sub must be checked against use C4::Items * C4::Items is needed in EmbedItemsInMarcBiblio, moving it only in this sub, and switching to require * 2 subs are totally useless z3950_extended_services and set_service_options, removing them -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:23:33 UTC --- Created attachment 5503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5503 Bug 6875 de-nesting C4::Items C4::Branch is used only in CheckItemPresave, moving from a use to a require in the sub C4::Reserve: This package is loaded just for C4::Reserves::CheckReserves called in C4::Items::GetItemsInfo The GetItemsInfo stores the result of CheckReserves in a hash entry, count_reserve, that is used only in opac_detail to display the status of a hold. We could remove the reserve_count hash entry and inline C4::Reserves::CheckReserves directly from opac-detail.pl page in opac-detail.pl, instead of if( $itm->{'count_reserves'} eq "Waiting"){ $itm->{'waiting'} = 1; } write : if ( C4::Reserves::CheckReserves(<<parameters>>) eq "Waiting"){ $itm->{'waiting'} = 1; } C4::Acquisition is used only in MoveItemFromBiblio, a sub that is rarely called. Moving from a use to a require in the sub C4::Charset is used only in _parse_unlinked_item_subfields_from_xml. Moving from a use to require in the sub -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:23:55 UTC --- Created attachment 5505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5505 bug 6875 de-nesting C4::Member * working on GetMemberDetails. This sub must be optimized, as it is called on each page by C4::Auth. The sub call everytime patronflags, that need to load Reserves and Overdues. The patronflag returns a hash with various flags (overdues, fines, ...). It's not related to permissionflags, that are loaded elsewhere. Most of the time, we do nothing with those flags. The strategy is to split the GetMemberDetails in 2 subs : * GetMemberDetails, same as previously, without the flags * GetMemberFlags, that will return just the flags when needed (and will load when needed Reserves package) The following scripts call GetMemberDetails : * admin/aqbudget.pl = no use is done with flags, the splitting changes nothing * C4/SIP/ILS/Patron.pm = the flags are used later, so we call GetMemberFlags as well * C4/SIP/interactive_members_dump.pl = nothing is done with the flags, we change nothing * C4/Print.pm = used by printslip, that don't do anything with flags, we change nothing * C4/VirtualShelves = used to check permission to access to a virtualshelf, nothing done with flags, we change nothing * C4/Reserves = used in CheckReserves. With the result, we call _GetCircControlBranch only, that does nothing with flags, we change nothing * C4/Auth = used in get_template_and_user. The return from GetMemberDetails is stored in the session, I don't see any change, flags are useless * C4/Circulation.pm = used many times * in CanBookBeIssued, just to retrieve the name/cardnumber/borrowernumber of a book already issued to someone else * in CanBookBeIssued, just to retrieve the name/cardnumber/borrowernumber of a book already reserved by someone else * in AddReturn, the result of GetMemberDetails is returned. It's then used in return.pl, to display patron flags. Retrieving flags with GetMemberFlags in return.pl * in AddRenewal, to retrieve some information, nothing done with flags, we change nothing * in GetRenewCount, to retrieve name & categorycode, nothing done with flags, we change nothing * in ILSDI/Services.pm, GetMemberDetails is called many times. Only once we check for charges, that is in the flags, so retrieving flags with GetMemberFlags * in catalogue/detail.pl, GetMemberDetails is called to retrieve the name of a patron that has placed a hold on a book, we change nothing * in circ/transferstoreceive, GetMemberDetails is called to retrieve the name of a patron, (and address), we change nothing * in circ/circulation.pl, we must retrieve the flags to display them (like for return.pl) * in circ/waitingreserves.pl, GetMemberDetails is called to retrieve the name of the patron, nothing to change * in members/moremember.pl, GetMemberDetails is called to retrieve name, surname, borrowernumber, we change nothing * in members/deletemem.pl, GetMemberDetails is followed by a $flag = $bor->{flags}, replacing by a call to GetMemberDetails * in members/messaging.pl, GetMemberDetails is called to retrieve name, category, nothing to change * members/member-flags.pl is here for permissions, nothing to deal with patron flags, nothing to change * opac/opac-passwd.pl, nothing related to flags, nothing to change * opac/opac-ics.pl, nothing related to flags, nothing to change * opac/opac-renew.pl, used to retrieve only branchcode, nothing to change * opac/opac-account.pl, nothing to change, the core part of this script is to display fines that are retrieved by GetMemberAccountRecords * opac/opac-reserve.pl, nothing related to flags, nothing to change * opac/opac-userdetail.pl, script that retrieve only a few dates and other infos from GetMemberDetails, nothing to change * opac/opac-showreviews.pl, retrieve only name & email from GetMemberDetails, nothing to change * opac/SCO/sco-main.pl, calls canbookbeissued, that need flags, so retrieving them * opac/opac-readingrecord.pl, use GetMemberDetails to retrieve patron name, address... nothing to change * opac/opac-messaging.pl, use GetMemberDetails to retrieve sms informations, nothing to change * opac/opac-userupdate.pl, use GetMemberDetails to display member information that can be updated by the patron, nothing related to flags, nothing to change * opac/opac-privacy.pl, loaded just to retrieve name & privacy flag info, nothing to change * opac/opac-user.pl, use GetMemberDetails to display patron information, but not flags one, nothing to change * opac/opac-suggestion.pl use GetMemberDetails to retrieve the branchcode, nothing to change * reserve/request.pl use GetMemberDetails to retrieve many informations displayed (name, branchcode,...), but none related to flags. Nothing to change GetMemberDetails also launches 2 SQL queries, the 2nd being superfluous : the enrolmentperiod is already available in the 1st query, just return it ! => C4::Reserves & C4::Overdues are now used only in GetMemberFlags sub, that is not always called, so switching from a use to a require inside the sub C4::Accounts is used only in AddMember and ExtendMemberSubscriptionTo, and only if there is a fee for subscription, switching from use to require sub GetMemberAccountRecords the SQL query has been completed. With a LEFT JOIN, we retrieve directly the title & biblionumber. Thus the call to GetBiblioByItemNumber is now useless and the use C4::Biblio can be removed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:24:14 UTC --- Created attachment 5507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5507 Bug 6875 de-nesting C4/Print.pm removing use C4::Circulation, that is useless -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:24:36 UTC --- Created attachment 5509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5509 Bug 6875 cleaning mainpage.pl AutoritiesMarc is loaded for nothing : we don't display authorities anywhere, so removing the dependancy as well as the useless code -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:25:05 UTC --- Created attachment 5511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5511 Bug 6875 cleaning opac-detail.pl C4::Tags and C4::Reviews used only if the feature is activated. Changing the use to a require inside the if (after testing it's activated) For libraries that have activated both, that means no change, but for others, it's an improvement -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff AssignedTo|gmcharlt@gmail.com |paul.poulain@biblibre.com --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-21 15:36:33 UTC --- (In reply to comment #2)

Moving compilation of the module code from compile to runtime seems a bit counter intuitive. Certainly if we start running the code in any kind of persistent framework we want to do the opposite. One thing that aids maintenenance is to only pollute (I mean import into ) your namespace those subroutines that you need. i.e, use Module qw( function1 function2);

I agree it seems counter intuitive (well, it's illogic in fact ;-) ) However, as long as we don't have persistency, it's good to have those tweakings, as my tests shows. I've attached the 17 patches i've done, and here are some results : * Biblio.pm is well isolated and load only what's needed * Members is correctly isolated and doesn't load only what's needed * Reserves and Circulation still require a lot of investigations. They load almost everything and it can't be simplified easily. Circulation & Reserve are loading recursively Test on mainpage.pl : Profile of mainpage.pl for 1.08s (of 1.43s), executing 118729 statements and 29826 subroutine calls in 132 source files and 41 string evals. To compare with the same page before the de-nesting: Profile of mainpage.pl for 1.73s (of 2.18s), executing 155108 statements and 41041 subroutine calls in 249 source files and 64 string evals. ==> -36379 statements (-24% !) Test on opac-main.pl Before de-nesting & cleaning = Profile of opac/opac-main.pl for 1.96s (of 2.61s), executing 218971 statements and 51466 subroutine calls in 248 source files and 61 string evals. After de-nesting & cleaning = Profile of opac/opac-main.pl for 1.29s (of 1.88s), executing 182574 statements and 40411 subroutine calls in 138 source files and 38 string evals. ==> -36397 statements (-16%) The timings are not fully relevants, they depend on too much things (like mysql having the data in cache or no). All tests have been done without any tweaking (ie : no memcache, basic mysql/apache config...)

It also flags up to those who come after you how much of that module is used.

??? I don't understand what you mean here ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7034 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7035 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7036 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7037 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5508|0 |1 is obsolete| | --- Comment #26 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-18 13:49:29 UTC --- Comment on attachment 5508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5508 Bug 6875 de-nesting C4::Reserve, 1st step Marking obsolete, since I'm moving this patch to it's specific bug report (7051) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |Rel_3_8 --- Comment #27 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:37:59 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7119 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5512|0 |1 is obsolete| | --- Comment #29 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-06 11:36:06 UTC --- Comment on attachment 5512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5512 Bug 6875 C4::Context cleaning Moving C4::Context cleaning patch to bug 7188 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5443|1 |0 is patch| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Bug 6875 depends on bug 7051, which changed state. Bug 7051 Summary: Unnecessary C4::Search dependency in C4::Reserves http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7051 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5496|0 |1 is obsolete| | --- Comment #32 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 14:00:34 UTC --- Created attachment 7359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7359 Bug 6875 de-nesting Auth.pm * removed use C4::Koha that is useless * moved "use C4::Members" to "require C4::Members" just before GetMemberDetails call. This will avoid loading C4::Member everytime a page is called by someone not logged * still to do = work on C4::VirtualShelves, that can be optimized, definetly ! Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased on latest master, 28 Jan 2012 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5509|0 |1 is obsolete| | --- Comment #34 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 14:11:45 UTC --- Created attachment 7361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7361 Bug 6875 cleaning mainpage.pl AutoritiesMarc is loaded for nothing : we don't display authorities anywhere, so removing the dependancy as well as the useless code Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5499|0 |1 is obsolete| | --- Comment #36 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 14:21:02 UTC --- Created attachment 7363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7363 Bug 6875 de-nesting C4/Serials * use C4::Branch is loaded only to call GetBranchNAme in PrepareSerialsData and set branchname in the hashresult. This sub PrepareSerialsData is used in the following scripts : opac/opac-serial-issues.pl: my $subscriptioninformation=PrepareSerialsData($subscriptions); => no use of branchname after serials/serials-collection.pl: $subscriptions=PrepareSerialsData(\@subscriptioninformation); => no use of branchname after => we can remove the ->{branchname} from the result, and remove the C4::Branch dependancy * moves use C4::Items to require C4::Items, to call AddItemFromMarc, when receiving a serial, with Recieving create an item set in the subscription. * removed use C4::Letters and C4::Search, that are useless Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5504|0 |1 is obsolete| | --- Comment #38 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 14:31:36 UTC --- Created attachment 7365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7365 Bug 6875 de-nesting C4::VirtualShelves * C4::Circulation is unused, removing it * C4::Members used only in ShelfPossibleAction, switching from use to require * C4::Auth used only in RefreshShelvesSummary, a sub called only in opac-addbybiblionumber.pl script, moving the require inside the sub Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #40 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-31 08:47:12 UTC --- (In reply to comment #39)

I would like to encourage the QA team to review the patches that I signed off on so that they can be pushed to Master, rather than waiting for revised patches for the four that I didn't sign off on. Agreed, as all those patches are independant from each other, and change nothing to the Koha behaviour (at least if they're not bugguy ;-) )

I'll ask Marcel & Ian by pm : they are small patches, should be easy to QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #42 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-15 12:14:17 UTC --- Testing the second one: Applying: Bug 6875 de-nesting C4::Items error: patch failed: C4/Items.pm:1218 error: C4/Items.pm: patch does not apply fatal: sha1 information is lacking or useless (C4/Items.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-15 12:17:56 UTC --- Additional comment on the third one: I see reference to t/db_dependent/lib/KohaTest/Members.pm. I already sent Paul a request to delete those failing tests in that subdir. They are not working (anymore). Please do not include it here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5501|Bug 6875 de nesting |[NOT_APPLY][PATCH 01]Bug description|C4::Biblio |6875 de nesting C4::Biblio -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5505|bug 6875 de-nesting |[FAILED_QA][PATCH 03]bug description|C4::Member |6875 de-nesting C4::Member -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #46 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-15 12:24:43 UTC --- Testing the 5th: Reacting on this line: * still to do = work on C4::VirtualShelves, that can be optimized, definetly ! I would propose to wait with that. I have a patch forthcoming for bug 7310 (large one) with a lot of work for virtual shelves. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7360|Bug 6875 de-nesting |[PASSED_QA][PATCH 06]Bug description|C4::Koha.pm |6875 de-nesting C4::Koha.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #49 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-15 12:46:40 UTC --- Patch 7 (cleaning mainpage.pl) Removing useless code. Great! Passed QA too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7362|Bug 6875 cleaning |[PASSED_QA][PATCH 08]Bug description|opac-main.pl |6875 cleaning opac-main.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #51 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-15 13:01:15 UTC --- Comments on 9th patch for Serials.pm: Does take out 6 use statements, adds 2 requires. Due to circular module dependency between Serials and Biblio, compiling Serials still results in many subroutine redefinition warnings. But this is the case already now (just observing it). Subroutine GetSuppliersWithLateIssues redefined at C4/Serials.pm line 87. Subroutine GetLateIssues redefined at C4/Serials.pm line 110. [etc][etc] Since this patch makes a move in the right direction, marking it as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7364|Bug 6875 de-nesting |[PASSED_QA][PATCH 10]Bug description|C4::Heading |6875 de-nesting C4::Heading -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7365|Bug 6875 de-nesting |[PASSED_QA][PATCH 11]Bug description|C4::VirtualShelves |6875 de-nesting | |C4::VirtualShelves -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5501|0 |1 is obsolete| | Attachment #5503|0 |1 is obsolete| | Attachment #5505|0 |1 is obsolete| | Attachment #5511|0 |1 is obsolete| | Attachment #7360|0 |1 is obsolete| | Attachment #7361|0 |1 is obsolete| | Attachment #7362|0 |1 is obsolete| | Attachment #7363|0 |1 is obsolete| | Attachment #7364|0 |1 is obsolete| | Attachment #7365|0 |1 is obsolete| | Attachment #7652|0 |1 is obsolete| | --- Comment #54 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 14:45:25 UTC --- Created attachment 7654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7654 Bug 6875 de nesting C4::Biblio C4::Biblio is used in many many places. The goal of this cleaning is to do from C4::Biblio a package with as many dependancies as possible. * C4::Heading is called only in 1 place, highly rarely used (only in 1 misc/link_bibs_to_authorities.pl), moving to require * PrepareItemrecordDisplay is a sub that is more related to Items, moving it here. It means some scripts that used this sub must be checked against use C4::Items * C4::Items is needed in EmbedItemsInMarcBiblio, moving it only in this sub, and switching to require * 2 subs are totally useless z3950_extended_services and set_service_options, removing them -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #56 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 14:45:54 UTC --- Created attachment 7656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7656 bug 6875 de-nesting C4::Member * working on GetMemberDetails. This sub must be optimized, as it is called on each page by C4::Auth. The sub call everytime patronflags, that need to load Reserves and Overdues. The patronflag returns a hash with various flags (overdues, fines, ...). It's not related to permissionflags, that are loaded elsewhere. Most of the time, we do nothing with those flags. The strategy is to split the GetMemberDetails in 2 subs : * GetMemberDetails, same as previously, without the flags * GetMemberFlags, that will return just the flags when needed (and will load when needed Reserves package) The following scripts call GetMemberDetails : * admin/aqbudget.pl = no use is done with flags, the splitting changes nothing * C4/SIP/ILS/Patron.pm = the flags are used later, so we call GetMemberFlags as well * C4/SIP/interactive_members_dump.pl = nothing is done with the flags, we change nothing * C4/Print.pm = used by printslip, that don't do anything with flags, we change nothing * C4/VirtualShelves = used to check permission to access to a virtualshelf, nothing done with flags, we change nothing * C4/Reserves = used in CheckReserves. With the result, we call _GetCircControlBranch only, that does nothing with flags, we change nothing * C4/Auth = used in get_template_and_user. The return from GetMemberDetails is stored in the session, I don't see any change, flags are useless * C4/Circulation.pm = used many times * in CanBookBeIssued, just to retrieve the name/cardnumber/borrowernumber of a book already issued to someone else * in CanBookBeIssued, just to retrieve the name/cardnumber/borrowernumber of a book already reserved by someone else * in AddReturn, the result of GetMemberDetails is returned. It's then used in return.pl, to display patron flags. Retrieving flags with GetMemberFlags in return.pl * in AddRenewal, to retrieve some information, nothing done with flags, we change nothing * in GetRenewCount, to retrieve name & categorycode, nothing done with flags, we change nothing * in ILSDI/Services.pm, GetMemberDetails is called many times. Only once we check for charges, that is in the flags, so retrieving flags with GetMemberFlags * in catalogue/detail.pl, GetMemberDetails is called to retrieve the name of a patron that has placed a hold on a book, we change nothing * in circ/transferstoreceive, GetMemberDetails is called to retrieve the name of a patron, (and address), we change nothing * in circ/circulation.pl, we must retrieve the flags to display them (like for return.pl) * in circ/waitingreserves.pl, GetMemberDetails is called to retrieve the name of the patron, nothing to change * in members/moremember.pl, GetMemberDetails is called to retrieve name, surname, borrowernumber, we change nothing * in members/deletemem.pl, GetMemberDetails is followed by a $flag = $bor->{flags}, replacing by a call to GetMemberDetails * in members/messaging.pl, GetMemberDetails is called to retrieve name, category, nothing to change * members/member-flags.pl is here for permissions, nothing to deal with patron flags, nothing to change * opac/opac-passwd.pl, nothing related to flags, nothing to change * opac/opac-ics.pl, nothing related to flags, nothing to change * opac/opac-renew.pl, used to retrieve only branchcode, nothing to change * opac/opac-account.pl, nothing to change, the core part of this script is to display fines that are retrieved by GetMemberAccountRecords * opac/opac-reserve.pl, nothing related to flags, nothing to change * opac/opac-userdetail.pl, script that retrieve only a few dates and other infos from GetMemberDetails, nothing to change * opac/opac-showreviews.pl, retrieve only name & email from GetMemberDetails, nothing to change * opac/SCO/sco-main.pl, calls canbookbeissued, that need flags, so retrieving them * opac/opac-readingrecord.pl, use GetMemberDetails to retrieve patron name, address... nothing to change * opac/opac-messaging.pl, use GetMemberDetails to retrieve sms informations, nothing to change * opac/opac-userupdate.pl, use GetMemberDetails to display member information that can be updated by the patron, nothing related to flags, nothing to change * opac/opac-privacy.pl, loaded just to retrieve name & privacy flag info, nothing to change * opac/opac-user.pl, use GetMemberDetails to display patron information, but not flags one, nothing to change * opac/opac-suggestion.pl use GetMemberDetails to retrieve the branchcode, nothing to change * reserve/request.pl use GetMemberDetails to retrieve many informations displayed (name, branchcode,...), but none related to flags. Nothing to change GetMemberDetails also launches 2 SQL queries, the 2nd being superfluous : the enrolmentperiod is already available in the 1st query, just return it ! => C4::Reserves & C4::Overdues are now used only in GetMemberFlags sub, that is not always called, so switching from a use to a require inside the sub C4::Accounts is used only in AddMember and ExtendMemberSubscriptionTo, and only if there is a fee for subscription, switching from use to require sub GetMemberAccountRecords the SQL query has been completed. With a LEFT JOIN, we retrieve directly the title & biblionumber. Thus the call to GetBiblioByItemNumber is now useless and the use C4::Biblio can be removed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #58 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-15 14:46:05 UTC --- Created attachment 7658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7658 C4::Members follow-up Overdues already loaded, must set full sub patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7545 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7654|0 |1 is obsolete| | --- Comment #60 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-20 11:04:58 UTC --- Created attachment 7770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7770 [PASSED_QA]Bug 6875 Biblio module Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> No test plan included, but tested some opac and cataloging functions. Code looks good. Marked as Passed QA. NOTE: Includes changes to obsolete test files. Should actually be removed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7656|bug 6875 de-nesting |[HAS_SOME_PROBLEM]bug 6875 description|C4::Member |de-nesting C4::Member -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #62 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-20 12:00:09 UTC --- QA Comment on patch cleaning up opac-detail.pl: Use of C4::Tags is replaced by later require. Introduces following problem: [error] opac-detail.pl: Too late to run INIT block at /usr/share/koha/testclone/C4/Tags.pm line 64. Marked this one as Failed QA in name of patch attachment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7770|0 |1 is obsolete| | --- Comment #64 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-20 15:45:27 UTC --- Comment on attachment 7770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7770 [PASSED_QA]Bug 6875 Biblio module this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #67 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2012-02-22 12:27:51 UTC --- (In reply to comment #66)

The patch pushed to master has a bug: C4::Items calls _find_value() that is in Biblio. Good catch, Srdjan! Anyone already working on this one? Paul perhaps??

-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #69 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-22 16:07:01 UTC --- Created attachment 7808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7808 Bug 6875 follow-up for Items/Biblio de-nesting the sub _find_value is used only in PrepareItemRecord sub, that has been moved to Items package This patch moves the _find_value in Items as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7808|0 |1 is obsolete| | --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-24 06:08:12 UTC --- Created attachment 7844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7844 [SIGNED-OFF] Bug 6875 follow-up for Items/Biblio de-nesting the sub _find_value is used only in PrepareItemRecord sub, that has been moved to Items package This patch moves the _find_value in Items as well. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Editing an already arrived serial issue with an attached item resulted in an error. After applying the patch it's fixed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7844|[SIGNED-OFF] Bug 6875 |[PASSED_QA] Bug 6875 description|follow-up for Items/Biblio |follow-up for Items/Biblio |de-nesting |de-nesting -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7844|0 |1 is obsolete| | --- Comment #74 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-27 10:13:21 UTC --- Comment on attachment 7844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7844 [PASSED_QA] Bug 6875 follow-up for Items/Biblio de-nesting this patch has been pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7658|0 |1 is obsolete| | --- Comment #75 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8095&action=edit C4::Members follow-up Overdues already loaded, must set full sub patch http://bugs.koha-community.org/show_bug.cgi?id=6875 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Fixes issue with circ/branchoverdues.pl Passes tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #76 from Liz Rea <wizzyrea@gmail.com> --- setting to signed off for C4::Members follow-up. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #77 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #76)

setting to signed off for C4::Members follow-up.

It is only useful in connection with the first Members patch. And that appears to be still in construction. And could be done in one pass then. Changing status to reflect that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #79 from Ian Walls <koha.sekjal@gmail.com> --- Created attachment 8133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8133&action=edit Bug 6875 Followup: De-nesting C4::Items breaks bulkmarcimport Removing 'use C4::Branch' in favour of a subroutine-specific 'require C4::Branch' causes the GetBranchName subroutine to return an error, as it's not defined in C4::Items. Adding "C4::Branch::" scoping fixes the error, which is what's done here. To confirm problem: 1. Attempt to run bulkmarcimport.pl before applying the patch. You should get ERROR: Adding items to bib 435 failed: Undefined subroutine &C4::Items::GetBranchName called at /home/sekjal/kohaclone/C4/Items.pm line 656, <GEN13> line 435. To test: 2. apply patch 3. run bulkmarcimport again. Error should disappear. Signed-off-by: Ian Walls <koha.sekjal@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #80 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8134&action=edit Bug 6875 Followup: De-nesting C4::Items breaks bulkmarcimport Removing 'use C4::Branch' in favour of a subroutine-specific 'require C4::Branch' causes the GetBranchName subroutine to return an error, as it's not defined in C4::Items. Adding "C4::Branch::" scoping fixes the error, which is what's done here. To confirm problem: 1. Attempt to run bulkmarcimport.pl before applying the patch. You should get ERROR: Adding items to bib 435 failed: Undefined subroutine &C4::Items::GetBranchName called at /home/sekjal/kohaclone/C4/Items.pm line 656, <GEN13> line 435. To test: 2. apply patch 3. run bulkmarcimport again. Error should disappear. Signed-off-by: Ian Walls <koha.sekjal@gmail.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Note that this problem only appears when importing records with item (952) fields. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8133|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8095|0 |1 is obsolete| | --- Comment #84 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 8095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8095 C4::Members follow-up this patch has been pushed (on master branch directly) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #86 from Chris Cormack <chris@bigballofwax.co.nz> --- Also, are THERE problems with it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 Bug 6875 depends on bug 7025, which changed state. Bug 7025 Summary: C4::Items depends on C4::Reserves (which in turn depends on C4::Items...) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7025 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875 --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 closing -- You are receiving this mail because: You are watching all bug changes.