[Bug 26199] New: Record matching rule match check should include Leader/LDR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Bug ID: 26199 Summary: Record matching rule match check should include Leader/LDR Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org At the moment, record matching rule match checks can only use control fields and data fields. It would be great if they could also use the leader. This is very useful for matching against LDR06 for instance when you want to make sure that you're getting text instead of an audiobook for instance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1, I've had libraries ask for this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 114468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114468&action=edit Bug 26199: Include LDR for match check/match point This patch adds the ability to specify the LDR instead of a numeric tag when defining match checks in record matching rules. This is particularly useful for checking LDR6 "Type of record" when importing records. Test plan: 0. prove t/Matcher.t 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 2. Click "Save" and choose "MARCXML" 3. Copy bib-1.marcxml to bib-1-mod.marcxml 4. Change "01344cam a22003014i 4500" to "01344cmm a22003014i 4500" 5. Go to http://localhost:8081/cgi-bin/koha/admin/matching-rules.pl?op=edit_matching_rule&matcher_id=3 6. Click "Add match check" 7. Fill out the match checks: Source: Tag: LDR Offset: 6 Length: 1 Target: Tag: LDR Offset: 6 Length: 1 8. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 9. Choose "bib-1-mod.marcxml" and click "Upload file" 10. Choose "KohaBiblio (999$c)" for "Record matching rule" 11. Click "Stage for import" 12. Click "Manage staged records" on resulting page 13. Note the "Match type" says "No match" 14. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 15. Choose "bib-1.marcxml" and click "Upload file" 16. Choose "KohaBiblio (999$c)" for "Record matching rule" 17. Click "Stage for import" 18. Click "Manage staged records" on resulting page 19. Note the Match type says "Match found" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114468|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 114478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114478&action=edit Bug 26199: Include LDR for match check/match point This patch adds the ability to specify the LDR instead of a numeric tag when defining match checks in record matching rules. This is particularly useful for checking LDR6 "Type of record" when importing records. Test plan: 0. prove t/Matcher.t 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 2. Click "Save" and choose "MARCXML" 3. Copy bib-1.marcxml to bib-1-mod.marcxml 4. Change "01344cam a22003014i 4500" to "01344cmm a22003014i 4500" 5. Go to http://localhost:8081/cgi-bin/koha/admin/matching-rules.pl?op=edit_matching_rule&matcher_id=3 6. Click "Add match check" 7. Fill out the match checks: Source: Tag: LDR Offset: 6 Length: 1 Target: Tag: LDR Offset: 6 Length: 1 8. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 9. Choose "bib-1-mod.marcxml" and click "Upload file" 10. Choose "KohaBiblio (999$c)" for "Record matching rule" 11. Click "Stage for import" 12. Click "Manage staged records" on resulting page 13. Note the "Match type" says "No match" 14. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 15. Choose "bib-1.marcxml" and click "Upload file" 16. Choose "KohaBiblio (999$c)" for "Record matching rule" 17. Click "Stage for import" 18. Click "Manage staged records" on resulting page 19. Note the Match type says "Match found" Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27087 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thanks David! I added a See Also to bug 27087, which is sort of tangential, just in case it catches your eye :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Andrew Fuerste-Henry from comment #4)
Thanks David! I added a See Also to bug 27087, which is sort of tangential, just in case it catches your eye :)
Thanks for testing! And that bug sounds interesting! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114478|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 117788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117788&action=edit Bug 26199: Include LDR for match check/match point This patch adds the ability to specify the LDR instead of a numeric tag when defining match checks in record matching rules. This is particularly useful for checking LDR6 "Type of record" when importing records. Test plan: 0. prove t/Matcher.t 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 2. Click "Save" and choose "MARCXML" 3. Copy bib-1.marcxml to bib-1-mod.marcxml 4. Change "01344cam a22003014i 4500" to "01344cmm a22003014i 4500" 5. Go to http://localhost:8081/cgi-bin/koha/admin/matching-rules.pl?op=edit_matching_rule&matcher_id=3 6. Click "Add match check" 7. Fill out the match checks: Source: Tag: LDR Offset: 6 Length: 1 Target: Tag: LDR Offset: 6 Length: 1 8. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 9. Choose "bib-1-mod.marcxml" and click "Upload file" 10. Choose "KohaBiblio (999$c)" for "Record matching rule" 11. Click "Stage for import" 12. Click "Manage staged records" on resulting page 13. Note the "Match type" says "No match" 14. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 15. Choose "bib-1.marcxml" and click "Upload file" 16. Choose "KohaBiblio (999$c)" for "Record matching rule" 17. Click "Stage for import" 18. Click "Manage staged records" on resulting page 19. Note the Match type says "Match found" Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looks good to me. Bit cheating in the code where we pretend that LDR is a field tag. Same for the interface. We need to make clear in the manual that we support this now. Release notes ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This patch extends the release notes| |functionality of the | |existing record matching | |rules by allowing | |comparisons based on the | |fixed-length MARC leader. | |To reference the leader in | |a matching rule, enter | |"LDR" for the MARC tag in | |your matching rule setup. | |The offset and length | |values can be used to | |further refine your match. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.04 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small useful enhancement, I choose to backport. Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org