https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179516&action=edit Bug 39395: Fix #wrapper closing tag in sco The module was displayed at the bottom of the screen. It's caused by the closing tag of #wrapper that has been added by bug 38664 inside the include file. It is wrong, the div.main should be within #wrapper. The correct fix is to move #wrapper out of the include file, so that the HTML structure is correct (and the prettier plugin is happy) in the .tt files Test plan: Confirm the bug Apply this patch Go to the SCO module and confirm that the module is correctly placed at the top of the screen Please review this patch using `git show -w HEAD` -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179516|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 179898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179898&action=edit Bug 39395: Fix #wrapper closing tag in sco The module was displayed at the bottom of the screen. It's caused by the closing tag of #wrapper that has been added by bug 38664 inside the include file. It is wrong, the div.main should be within #wrapper. The correct fix is to move #wrapper out of the include file, so that the HTML structure is correct (and the prettier plugin is happy) in the .tt files Test plan: Confirm the bug Apply this patch Go to the SCO module and confirm that the module is correctly placed at the top of the screen Please review this patch using `git show -w HEAD` Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 179899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179899&action=edit Screenshot 1: Self checkout login screen - before the patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the self |This fixes the self release notes|checkout system login page |checkout system login page |- there was a large |- there was a large |vertical gap between the |vertical gap between the |header of page, and the |header of the page, and the |actual login form. |actual login form. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179898|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180059&action=edit Bug 39395: Fix #wrapper closing tag in sco The module was displayed at the bottom of the screen. It's caused by the closing tag of #wrapper that has been added by bug 38664 inside the include file. It is wrong, the div.main should be within #wrapper. The correct fix is to move #wrapper out of the include file, so that the HTML structure is correct (and the prettier plugin is happy) in the .tt files Test plan: Confirm the bug Apply this patch Go to the SCO module and confirm that the module is correctly placed at the top of the screen Please review this patch using `git show -w HEAD` Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|sco login form not |Self checkout login form |correctly placed |not correctly place -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39395 Bug 39395 depends on bug 38664, which changed state. Bug 38664 Summary: Tidy the whole codebase https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.