[Bug 28104] New: last line of sitemapindex.xml lacks EOL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28104 Bug ID: 28104 Summary: last line of sitemapindex.xml lacks EOL Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: bargioni@pusc.it QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, robin@catalyst.net.nz CC: jonathan.druart@bugs.koha-community.org $ /usr/sbin/koha-sitemap --generate instance generates file /var/lib/koha/instance/sitemap/sitemapindex.xml without the EOL of the last line. XML parsers can complain, e.g.: $ xmllint --format /var/lib/koha/instance/sitemap/sitemapindex.xml /var/lib/koha/instance/sitemap/sitemapindex.xml:22: parser error : expected '>' </sitemapindex> ^ /var/lib/koha/instance/sitemap/sitemapindex.xml:22: parser error : Premature end of data in tag sitemapindex line 3 </sitemapindex> ^ --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't recreate the problem. Can you provide more detail please? $ perl debian/scripts/koha-sitemap --enable kohadev Sitemap enabled for kohadev $ perl debian/scripts/koha-sitemap --generate kohadev Sitemap directory for kohadev doesn't exist. Creating. $ xmllint --format /var/lib/koha/kohadev/sitemap/sitemapindex.xml <?xml version="1.0" encoding="UTF-8"?> <sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> <sitemap> <loc>http://kohadev.myDNSname.org:8080/sitemap0001.xml</loc> <lastmod>2021-04-09</lastmod> </sitemap> </sitemapindex> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28104 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (tested on master) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28104 --- Comment #3 from Stefano Bargioni <bargioni@pusc.it> --- Sorry: don't use xmllint to test it. Use vi instead: a [noeol] message is shown at the bottom of the screen. Anyway, this is a less than minor bug. Please, feel free to move it to trivial or even to delete it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can see the [noeol] note in vim, but no error in xmllint. After looking into it a bit, it doesn't seem to have any negative effect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org