[Bug 10129] New: Babeltheque does not depend on COinSinOPACResults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Bug ID: 10129 Summary: Babeltheque does not depend on COinSinOPACResults Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com The Babeltheque information are displayed only if the COinSinOPACResults syspref is enabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17716&action=edit Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch breaks display of existing approved tags and of local star ratings. When I apply this patch I no longer see approved tags in search results, and all star ratings indicators are grey even for titles which have ratings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #2)
This patch breaks display of existing approved tags and of local star ratings. When I apply this patch I no longer see approved tags in search results, and all star ratings indicators are grey even for titles which have ratings.
Owen, thanks for testing. I cannot reproduce but I found some inconsistent things. There are 3 'next' statements which might cause problems. I will provide a new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17716|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17884&action=edit Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Jonathan: I'm interested in testing your patch, but I'm not sure how to get Babeltheque information to display (is it simply enough to turn on the system preference? Are there some known items that I could import via z39.50 to use to test this?). Also, what types of information should be displaying? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7470 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #5)
Jonathan:
I'm interested in testing your patch, but I'm not sure how to get Babeltheque information to display (is it simply enough to turn on the system preference? Are there some known items that I could import via z39.50 to use to test this?).
Also, what types of information should be displaying?
David, Babeltheque is a service for french libraries. It requires a account for testing it, so it is not possible to test this feature. But it is possible to test features related to others syspref. I apply the patch on a vm where the feature is configured: http://catalogue.master33-dev.biblibre.com/cgi-bin/koha/opac-search.pl?q=har... Syspref values are: COinSinOPACResults = 0 Babeltheque = 1 TagsEnabled = 1 TagsShowOnList = 6 OpacStarRatings = all Code is based on master + this patch. I just found a bug on the detail page when Babeltheque is enabled (js error), I will open a new report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17884|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17932&action=edit [SIGNED-OFF] Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This revised patch works fine for me, thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.12 |3.14 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This influences quite a lot of system preferences - maybe this is better included in 3.14/3.12.1 with a bit more testing? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17932|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18099&action=edit [PASSED QA] Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This revised patch works fine for me, thanks. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Verified following system preferences still work as expected: - COinSinOPACResults on/off - TagsEnabled, TagsShowOnList, TagsInputOnList on/off - OpacStarRatings Couldn't test Babeltheque functionality as this requires an account. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|3.14 |master --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Version back to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org