[Bug 22723] New: Syntax error on confess call in Koha/MetadataRecord/Authority.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Bug ID: 22723 Summary: Syntax error on confess call in Koha/MetadataRecord/Authority.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I had this error with authorities indexing with Elasticsearch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 88187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88187&action=edit Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I dont know how I could create a test plan but maybe it is not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88187|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 88188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88188&action=edit Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. Also missing use Carp to call confess. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88188|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88616&action=edit Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. Also missing use Carp to call confess. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88616|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88689&action=edit Bug 22723: Correct syntax error on confess call in Koha/MetadataRecord/Authority.pm In Koha/MetadataRecord/Authority.pm the call to confess is missing string quotes. It may generates this error : Can't locate object method "confess" via package "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. " (perhaps you forgot to load "Empty String at /usr/share/perl5/MARC/File/XML.pm line 448. "?) at /home/koha/src/Koha/MetadataRecord/Authority.pm line 186. Simply missing double quotes. Also missing use Carp to call confess. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22723 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org