[Bug 20529] New: Return to results link is truncated when the search contains a double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Bug ID: 20529 Summary: Return to results link is truncated when the search contains a double quote Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com == Reproduce == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result. 2. Click on the first result 3. Check the "Return to results" It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' == Cause == Something about escaping in koha-tmpl/intranet-tmpl/js/browser.js Search for BROWSER_RETURN_TO_SEARCH -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 74251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74251&action=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74553&action=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 74554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74554&action=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #6 from Séverine Queune <severine.queune@bulac.fr> --- Works with both Zebra (Biblibre's sandbox #10) and ElasticSearch (Biblibre's sandbox #12), with the original navigation tool and the new " BrowseResultSelection" option. Thanks Victor ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Thanks Séverine for testing with ES! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74554|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74610&action=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why this occurrence and not the others? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #10 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Because I wasn't able to trigger the code of the other occurrences ^^" https://gitlab.com/koha-community/Koha/blob/95031b035b5de87211d0de2040eb685a... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I guess it's: go to first, next, previous, go to last, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #12 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> ---
go to first, next, previous, go to last, etc.
It doesn't work, placed few console.log() and those next to the two occurrences of the usage of `decodeURIComponent(current_search.query)` weren't triggered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Reading the code I'd say these 2 switches prevent wrong calls to browseRecords (like you call it with movement != 1 and -1) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #14 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Unfortunately I'm out of time to expand much more [1] the scope of this issue. 1. Is the fix simple enough to be applied without having a test plan? 2. Is it okay to keep the scope as it is? 3. Should the patch stay pending waiting until someone to complete it? [1] implementation (not much work) + test plan that is still a mystery for me about how to expand it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd say we could go without test plan, if the changes make sense and work in that case it must work for the "special" cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Séverine Queune <severine.queune@bulac.fr> --- Sorry Victor, it failed when I tried. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Why keeping decodeURIComponent() for current_search.limit ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jonathan Druart from comment #15)
I'd say we could go without test plan, if the changes make sense and work in that case it must work for the "special" cases.
Ok, thanks for the additional analysis. (In reply to Séverine Queune from comment #16)
Sorry Victor, it failed when I tried.
Thanks for testing. (In reply to Fridolin SOMERS from comment #17)
Why keeping decodeURIComponent() for current_search.limit ?
I mostly lost the context. I guess that was because it didn't relate to the bug. Should decodeURIComponent be also removed for current_search.limit? The good news is that this part is known how to be tested. As opposed to the other occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- What does this bug need ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch needs a major rebase, since we since moved some things around like changing the way we do the translations on this script. But the problem remains. I tested with: a "test" The link back to the results turns it into a search for: a ++<<<<<<< HEAD + var searchURL = '/cgi-bin/koha/catalogue/search.pl?' + decodeURIComponent(current_search.query) + '&limit=' + decodeURIComponent(current_search.limit) + '&sort_by=' + current_search.sort + '&searchid=' + me.searchid + '&offset=' + me.offset; ++======= + var searchURL = '/cgi-bin/koha/catalogue/search.pl?' + current_search.query + '&limit=' + decodeURIComponent(current_search.limit) + '&sort=' + current_search.sort + '&searchid=' + me.searchid + '&offset=' + me.offset; ++>>>>>>> Bug 20529: Fix "Return to results" link broken by a double quote -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22070 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74610|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 120816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120816&action=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased and solved conflict. ====
The patch needs a major rebase, since we since moved some things around like changing the way we do the translations on this script.
Does it? Test plan work on my instance. ====
But the problem remains. I tested with: a "test"
With sample data, the test plan succeeds with «a "test"» -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120816|0 |1 is obsolete| | --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 122626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122626&action=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- I totally reproduce bug and patch fixes it. We already see : decodeURIComponent(current_search.limit) It is logical to use : decodeURIComponent(current_search.query) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122626|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122736&action=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #24)
I totally reproduce bug and patch fixes it.
We already see : decodeURIComponent(current_search.limit) It is logical to use : decodeURIComponent(current_search.query)
Hum? What do you mean? If it makes sense to remove this decode call then we should remove other occurrences from this file. I don't see the point of decodeURIComponent to generate an URI, unless we are doing weird stuffs somewhere else (or it's Friday afternoon and I am tired). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122751&action=edit Bug 20529: Remove other occurrences of decodeURIComponent from browser.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can someone stress the feature with this patch? IIRC weird bugs usually happens "on the edge" of the pagination. Like search with your favourite weird terms and click the last records from the page, then next, previous. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #28)
Can someone stress the feature with this patch? IIRC weird bugs usually happens "on the edge" of the pagination.
Like search with your favourite weird terms and click the last records from the page, then next, previous.
This needs feedback from the author -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Can someone stress the feature with this patch?
What do you mean? Is the patch name too vague? The first 3 steps of the test plan show the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #30)
Can someone stress the feature with this patch?
What do you mean? Is the patch name too vague? The first 3 steps of the test plan show the issue.
I've explained it: "Like search with your favourite weird terms and click the last records from the page, then next, previous." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 28866 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122736|0 |1 is obsolete| | Attachment #122751|0 |1 is obsolete| | --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124329&action=edit Bug 20529: Fix "Return to results" link broken by a double quote (in the search query) cause: decodeURIComponent used when URI encoding was necessary. (At least in main usecase of this feature) It could have been a copy and paste error. From the above browseRecords() function. == Test plan == 1. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 2. Click on the first result 3. Check the "Return to results" link It should be like staff_url://cgi-bin/koha/catalogue/search.pl?idx=kw&q=a This is the bug. Because when clicking the link, your search will be 'kw,wrdl: a' instead of 'kw,wrdl: a "alice"' 4. Apply this patch. 5. Search in the staff catalogue «a "alice"» Replace a and alice with whatever than will return a result for you 6. Click on the first result 7. Check the "Return to results" link The link should preserve the full query Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124330&action=edit Bug 20529: Remove other occurrences of decodeURIComponent from browser.js Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Moving to PQA - I tested with as many odd searches as I could, easier to break search and get no results than to break this. Any search with ccode will break without these patches as we double quote their values in the search code (in case they contain strange values, but we don't care about other auth_values?) so I think we should get this in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.04 |21.11.00,21.05.04,20.11.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #38 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #39 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org