[Bug 28394] New: Improve style of patron category entry form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Bug ID: 28394 Summary: Improve style of patron category entry form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are some issues with alignment, padding, and other styles that I'd like to correct on admin/categories.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121191&action=edit Bug 28394: Improve style of patron category entry form This patch makes some style and structure changes to the patron cartegory entry form: - Margin added to the enrollment period fieldset so that it aligns with the rest of the form. - Informational text inside the form wrapped in <div class="hint"> like it is on other pages. - Converted heading tag to legend tag in the messaging preferences fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Go to Administration -> Patron categories -> New category and confirm that the style updates look good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121191|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121202&action=edit Bug 28394: Improve style of patron category entry form This patch makes some style and structure changes to the patron cartegory entry form: - Margin added to the enrollment period fieldset so that it aligns with the rest of the form. - Informational text inside the form wrapped in <div class="hint"> like it is on other pages. - Converted heading tag to legend tag in the messaging preferences fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Go to Administration -> Patron categories -> New category and confirm that the style updates look good. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Very nice improvements! Looks good on all screen sizes (all screen sizes that I test at least) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121202|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123135&action=edit Bug 28394: Improve style of patron category entry form This patch makes some style and structure changes to the patron cartegory entry form: - Margin added to the enrollment period fieldset so that it aligns with the rest of the form. - Informational text inside the form wrapped in <div class="hint"> like it is on other pages. - Converted heading tag to legend tag in the messaging preferences fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Go to Administration -> Patron categories -> New category and confirm that the style updates look good. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28394 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported for 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org